René's URL Explorer Experiment


Title: fix(DI): make DI work on Components/Directives inherited from Angular by hannahhoward · Pull Request #8991 · angular/angular · GitHub

Open Graph Title: fix(DI): make DI work on Components/Directives inherited from Angular by hannahhoward · Pull Request #8991 · angular/angular

X Title: fix(DI): make DI work on Components/Directives inherited from Angular by hannahhoward · Pull Request #8991 · angular/angular

Description: Please check if the PR fulfills these requirements [X ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format [X ] Tests for the changes have been added (for bug fixes / features) [X ] Docs have been added / updated (for bug fixes / features) What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) [X ] Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Other... Please describe: What is the current behavior? (You can also link to an open issue here) See #8700 When an application attempts to extend a built-in Angular 2 Component, Directive, or Service, unless it is using the Angular Template Compiler instead of the vanilla Typescript, DI does not work properly What is the new behavior? Fixes #8700 An application can extend a built-in Angular 2 Component, Directive, or Service, using a standard typescript compiler and DI will still work. Does this PR introduce a breaking change? Yes [ X] No If this PR contains a breaking change, please describe the impact and migration path for existing applications: ... Other information: Makes it DI work when inheriting Components/Directives/Services from built-in Angular 2 Components/Directives/Services while using standard typescript compiler Fixes #8700 Explanation of fix: Currently, the reflector always prioritizes the properties emitted by tsickle over any metadata generated through decorators. In a scenario where one is extending a built Angular 2 component, while using standard typescript compilation, it will have tsickle properties from the built-in component and decorator metadata from the extending component. The solution is to use the Reflect.metadata API's getOwnMetadata method to see if metadata is present on the subclass that extends Angular, and prioritize that metadata over tsickle properties if it is present. Building a test for this was not trivial, and the only way I could think to do it was with an E2E_test -- see modules/playground/inherit_from_angular. This also neccesitated modifiying the build script to copy the typescript library to dist/all/playground/vendor. There may be code clean-up neccesary here - I am open to suggestions. But this at minimum illustrates the problem and one path to a solution.

Open Graph Description: Please check if the PR fulfills these requirements [X ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format [X ] Tests f...

X Description: Please check if the PR fulfills these requirements [X ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format [X ] Tests f...

Opengraph URL: https://github.com/angular/angular/pull/8991

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d380db92-2c98-5bd5-dfc6-2f5ad2630e29
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECA0:11486D:A50198:D70C01:6B00E640
html-safe-nonce660437ecbe809bc777e86c19c962e8d7e1caec54df701b013fa0796fd5ac59b1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0EwOjExNDg2RDpBNTAxOTg6RDcwQzAxOjZCMDBFNjQwIiwidmlzaXRvcl9pZCI6IjQwMTI5NTI4OTg5NjE5OTEyMzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacaccc7ef73c4a9e91a9a97e1da9607d18239a3abc4b9e109b9401c57b8748c48a
hovercard-subject-tagpull_request:72460064
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/8991/files
twitter:imagehttps://avatars.githubusercontent.com/u/1450680?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1450680?s=400&v=4
og:image:altPlease check if the PR fulfills these requirements [X ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format [X ] Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/8991/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F8991%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F8991%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/8991/files
Reloadhttps://github.com/angular/angular/pull/8991/files
Reloadhttps://github.com/angular/angular/pull/8991/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
hannahhowardhttps://github.com/hannahhoward
angular:masterhttps://github.com/angular/angular/tree/master
hannahhoward:DI_inherited_directives_8700https://github.com/hannahhoward/angular/tree/DI_inherited_directives_8700
Conversation 12 https://github.com/angular/angular/pull/8991
Commits 1 https://github.com/angular/angular/pull/8991/commits
Checks 0 https://github.com/angular/angular/pull/8991/checks
Files changed https://github.com/angular/angular/pull/8991/files
Please reload this pagehttps://github.com/angular/angular/pull/8991/files
fix(DI): make DI work on Components/Directives inherited from Angular https://github.com/angular/angular/pull/8991/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/8991/files
cb63472 fix(DI): make DI work on Components/Directives inherited from Angular… hannahhoward Jun 3, 2016 https://github.com/angular/angular/pull/8991/commits/cb6347243cf781c5555686db75dad91d09d55093
Clear filters https://github.com/angular/angular/pull/8991/files
Please reload this pagehttps://github.com/angular/angular/pull/8991/files
Please reload this pagehttps://github.com/angular/angular/pull/8991/files
build.sh https://github.com/angular/angular/pull/8991/files#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823
reflection_capabilities.ts https://github.com/angular/angular/pull/8991/files#diff-cbc03e424ec5ce887249a7dc55e4efb3593a7adb40533eb46ac56e0fa0a1ff91
inherit_from_angular_spec.dart https://github.com/angular/angular/pull/8991/files#diff-4d7e693cfe136a9e067f1bce4d67bca25a96e2a2d2c523413d97df491f748388
inherit_from_angular_spec.ts https://github.com/angular/angular/pull/8991/files#diff-1426fcef67b38181f5af6b643c6230e4103e11e91f6ba17c575f1d327a989894
index.html https://github.com/angular/angular/pull/8991/files#diff-dceb600dccc40e3974b28221bb2cade7216c3d7c9cce57338ca1ee6d3f429667
index.ts https://github.com/angular/angular/pull/8991/files#diff-4db0117594195e2889801814da919e9445da86d5c7b886272903764316e49f7d
build.shhttps://github.com/angular/angular/pull/8991/files#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823
View file https://github.com/hannahhoward/angular/blob/cb6347243cf781c5555686db75dad91d09d55093/build.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/8991/{{ revealButtonHref }}
https://github.com/angular/angular/pull/8991/files#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823
https://github.com/angular/angular/pull/8991/files#diff-4d2a8eefdf2a9783512a35da4dc7676a66404b6f3826a8af9aad038722da6823
modules/@angular/core/src/reflection/reflection_capabilities.tshttps://github.com/angular/angular/pull/8991/files#diff-cbc03e424ec5ce887249a7dc55e4efb3593a7adb40533eb46ac56e0fa0a1ff91
View file https://github.com/hannahhoward/angular/blob/cb6347243cf781c5555686db75dad91d09d55093/modules/%40angular/core/src/reflection/reflection_capabilities.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/8991/{{ revealButtonHref }}
https://github.com/angular/angular/pull/8991/files#diff-cbc03e424ec5ce887249a7dc55e4efb3593a7adb40533eb46ac56e0fa0a1ff91
tboschhttps://github.com/tbosch
Jun 27, 2016https://github.com/angular/angular/pull/8991/files#r68656376
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/8991/files
https://github.com/angular/angular/pull/8991/files#diff-cbc03e424ec5ce887249a7dc55e4efb3593a7adb40533eb46ac56e0fa0a1ff91
https://github.com/angular/angular/pull/8991/files#diff-cbc03e424ec5ce887249a7dc55e4efb3593a7adb40533eb46ac56e0fa0a1ff91
https://github.com/angular/angular/pull/8991/files#diff-cbc03e424ec5ce887249a7dc55e4efb3593a7adb40533eb46ac56e0fa0a1ff91
https://github.com/angular/angular/pull/8991/files#diff-cbc03e424ec5ce887249a7dc55e4efb3593a7adb40533eb46ac56e0fa0a1ff91
modules/playground/e2e_test/inherit_from_angular/inherit_from_angular_spec.darthttps://github.com/angular/angular/pull/8991/files#diff-4d7e693cfe136a9e067f1bce4d67bca25a96e2a2d2c523413d97df491f748388
View file https://github.com/hannahhoward/angular/blob/cb6347243cf781c5555686db75dad91d09d55093/modules/playground/e2e_test/inherit_from_angular/inherit_from_angular_spec.dart
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/8991/{{ revealButtonHref }}
modules/playground/e2e_test/inherit_from_angular/inherit_from_angular_spec.tshttps://github.com/angular/angular/pull/8991/files#diff-1426fcef67b38181f5af6b643c6230e4103e11e91f6ba17c575f1d327a989894
View file https://github.com/hannahhoward/angular/blob/cb6347243cf781c5555686db75dad91d09d55093/modules/playground/e2e_test/inherit_from_angular/inherit_from_angular_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/8991/{{ revealButtonHref }}
modules/playground/src/inherit_from_angular/index.htmlhttps://github.com/angular/angular/pull/8991/files#diff-dceb600dccc40e3974b28221bb2cade7216c3d7c9cce57338ca1ee6d3f429667
View file https://github.com/hannahhoward/angular/blob/cb6347243cf781c5555686db75dad91d09d55093/modules/playground/src/inherit_from_angular/index.html
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/8991/{{ revealButtonHref }}
modules/playground/src/inherit_from_angular/index.tshttps://github.com/angular/angular/pull/8991/files#diff-4db0117594195e2889801814da919e9445da86d5c7b886272903764316e49f7d
View file https://github.com/hannahhoward/angular/blob/cb6347243cf781c5555686db75dad91d09d55093/modules/playground/src/inherit_from_angular/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/8991/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.