René's URL Explorer Experiment


Title: feat(common/datePipe):fix date formatter correct pattern сloses #7008 by laskoviymishka · Pull Request #8154 · angular/angular · GitHub

Open Graph Title: feat(common/datePipe):fix date formatter correct pattern сloses #7008 by laskoviymishka · Pull Request #8154 · angular/angular

X Title: feat(common/datePipe):fix date formatter correct pattern сloses #7008 by laskoviymishka · Pull Request #8154 · angular/angular

Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Fix for issue when date pipe not correctly formatted, closes #7008 add regular expression to parse date parts add date part creator function replace tokens in pattern to parsed parts What is the current behavior? (You can also link to an open issue here) See plnkr: http://plnkr.co/edit/nNpBNaB8z7DEnZdpj7gM?p=preview Currently formatter only looking on your locale and what you pass in pattern string not how (MM dd yyyy and dd MM yyyy is really same pattern for him). It have no affect to any formatting inside this pattern. In a fact it strongly coupled to https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat global object. What is the new behavior (if this is a feature change)? We parse pattern to date token, which materialized according to passed date and current locale (with DateTimeFormat global object as well). After parsing and materializing date parts we replace tokens to materialized parts. See plnkr: http://plnkr.co/edit/BVfVx27Ko76PQPOu8Xl7?p=preview There is new version of date pipe that show how new formatter works Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) no Other information:

Open Graph Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format Tests for the ch...

X Description: Please check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format Tests for the ch...

Opengraph URL: https://github.com/angular/angular/pull/8154

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ebdce0e2-6a19-f3da-0a43-2aeadc7a9973
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0E4:1C94F:118FC49:166B6B6:6B015C9D
html-safe-noncee83b019ff9a5d55060ebba4255347593d33a483699aa1c08c83281b911da751a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEU0OjFDOTRGOjExOEZDNDk6MTY2QjZCNjo2QjAxNUM5RCIsInZpc2l0b3JfaWQiOiI0NzYyNjkyNTY5MjI0MjczMDUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacef469d5808f9c37e3ed6c6f21a23d0207348a0d8c99d462971ba94e1665d8765
hovercard-subject-tagpull_request:67181427
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/8154/files
twitter:imagehttps://avatars.githubusercontent.com/u/2754361?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2754361?s=400&v=4
og:image:altPlease check if the PR fulfills these requirements The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format Tests for the ch...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/8154/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F8154%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F8154%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/8154/files
Reloadhttps://github.com/angular/angular/pull/8154/files
Reloadhttps://github.com/angular/angular/pull/8154/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
mheveryhttps://github.com/mhevery
angular:masterhttps://github.com/angular/angular/tree/master
laskoviymishka:feature/date-formatterhttps://github.com/laskoviymishka/angular/tree/feature/date-formatter
Conversation 5 https://github.com/angular/angular/pull/8154
Commits 1 https://github.com/angular/angular/pull/8154/commits
Checks 0 https://github.com/angular/angular/pull/8154/checks
Files changed https://github.com/angular/angular/pull/8154/files
Please reload this pagehttps://github.com/angular/angular/pull/8154/files
feat(common/datePipe):fix date formatter correct pattern сloses #7008 https://github.com/angular/angular/pull/8154/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/8154/files
3229c01 feat(common/datePipe): change date formatter to use correct pattern c… laskoviymishka Apr 20, 2016 https://github.com/angular/angular/pull/8154/commits/3229c015b3af1e1a9add501fe0774a861a668c67
Clear filters https://github.com/angular/angular/pull/8154/files
Please reload this pagehttps://github.com/angular/angular/pull/8154/files
Please reload this pagehttps://github.com/angular/angular/pull/8154/files
date_pipe_spec.ts https://github.com/angular/angular/pull/8154/files#diff-4cbfd966272d99cc31318f7b77d8fc2ba00a440d5023ea5a990f8a7b57259aff
intl.ts https://github.com/angular/angular/pull/8154/files#diff-8493e34b9699bfe2e6e8c7785947946437d79968d06a4f15618df61432380298
modules/@angular/common/test/pipes/date_pipe_spec.tshttps://github.com/angular/angular/pull/8154/files#diff-4cbfd966272d99cc31318f7b77d8fc2ba00a440d5023ea5a990f8a7b57259aff
View file https://github.com/laskoviymishka/angular/blob/3229c015b3af1e1a9add501fe0774a861a668c67/modules/%40angular/common/test/pipes/date_pipe_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/8154/{{ revealButtonHref }}
https://github.com/angular/angular/pull/8154/files#diff-4cbfd966272d99cc31318f7b77d8fc2ba00a440d5023ea5a990f8a7b57259aff
https://github.com/angular/angular/pull/8154/files#diff-4cbfd966272d99cc31318f7b77d8fc2ba00a440d5023ea5a990f8a7b57259aff
modules/@angular/facade/src/intl.tshttps://github.com/angular/angular/pull/8154/files#diff-8493e34b9699bfe2e6e8c7785947946437d79968d06a4f15618df61432380298
View file https://github.com/laskoviymishka/angular/blob/3229c015b3af1e1a9add501fe0774a861a668c67/modules/%40angular/facade/src/intl.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/8154/{{ revealButtonHref }}
https://github.com/angular/angular/pull/8154/files#diff-8493e34b9699bfe2e6e8c7785947946437d79968d06a4f15618df61432380298
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.