René's URL Explorer Experiment


Title: fix(forms): resync select when the text of an option without a value changes by lutzleonhardt · Pull Request #72147 · angular/angular · GitHub

Open Graph Title: fix(forms): resync select when the text of an option without a value changes by lutzleonhardt · Pull Request #72147 · angular/angular

X Title: fix(forms): resync select when the text of an option without a value changes by lutzleonhardt · Pull Request #72147 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? In Signal Forms, a change of an option's text ({{ label() }}) does not inform the select control, not even when the option has no value attribute and the text is its value. In B the select stays empty after label.set('two'), although the option now matches the field value. Issue Number: #71443 What is the new behavior? In B a text change now informs the select control: it selects the option once the text matches the field value, and shows nothing when the text no longer matches. A is unchanged, because with a value attribute the text is not the value of the option. Does this PR introduce a breaking change? Yes No Other information I followed the review in #71444: A text change is only relevant when the parent of the changed text node is an is not handled; but we can cover this case as well (closest('option')) if preferred I added the two requested tests and a third one: text changes away from the field value an option with an explicit value) one test for the text changing to the field value I also updated the doc comments in select.ts (the first one was stale, the second one missed the @param/@returns tags) and declares a return type of boolean.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...

Opengraph URL: https://github.com/angular/angular/pull/72147

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9339cc52-53e3-c750-4635-b77e01ed86e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id942A:31D532:DF8609:1288C49:6B01D222
html-safe-nonce206062f050f242319852177fbabe3db98ce95b0706792ad08a8a50d8d2f0dc6a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDJBOjMxRDUzMjpERjg2MDk6MTI4OEM0OTo2QjAxRDIyMiIsInZpc2l0b3JfaWQiOiIyNTEwNjE4MTMxMDM1MTgxNjAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac388e6af6bc276f4fc5ca46ab07610b04a8f3f2a9fab76976d111e403d63fc304
hovercard-subject-tagpull_request:5422766617
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/72147/files
twitter:imagehttps://avatars.githubusercontent.com/u/11898898?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11898898?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/72147/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72147%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72147%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/72147/files
Reloadhttps://github.com/angular/angular/pull/72147/files
Reloadhttps://github.com/angular/angular/pull/72147/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
lutzleonhardthttps://github.com/lutzleonhardt
angular:mainhttps://github.com/angular/angular/tree/main
lutzleonhardt:select-option-text-resynchttps://github.com/lutzleonhardt/angular/tree/select-option-text-resync
Conversation 0 https://github.com/angular/angular/pull/72147
Commits 2 https://github.com/angular/angular/pull/72147/commits
Checks 13 https://github.com/angular/angular/pull/72147/checks
Files changed 2 https://github.com/angular/angular/pull/72147/files
fix(forms): resync select when the text of an option without a value changes https://github.com/angular/angular/pull/72147/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/72147/files
9eaeb6b fix(forms): resync select when the text of an option without a value … lutzleonhardt Nov 20, 2026 https://github.com/angular/angular/pull/72147/commits/9eaeb6b9c8584d814d30cb0d876f4c55953ccf6b
5ea68b4 docs(forms): correct the select mutation observer doc comments lutzleonhardt Nov 21, 2026 https://github.com/angular/angular/pull/72147/commits/5ea68b49838546467f7865bbd5e405619b05a64f
Clear filters https://github.com/angular/angular/pull/72147/files
Please reload this pagehttps://github.com/angular/angular/pull/72147/files
Please reload this pagehttps://github.com/angular/angular/pull/72147/files
select.ts https://github.com/angular/angular/pull/72147/files#diff-54d5243f72f2568b9a3fee064247b6afd3028d50cfe36f4ae0bb8e664dfc5c6e
form_field.spec.ts https://github.com/angular/angular/pull/72147/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
packages/forms/signals/src/directive/select.tshttps://github.com/angular/angular/pull/72147/files#diff-54d5243f72f2568b9a3fee064247b6afd3028d50cfe36f4ae0bb8e664dfc5c6e
View file https://github.com/angular/angular/blob/5ea68b49838546467f7865bbd5e405619b05a64f/packages/forms/signals/src/directive/select.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72147/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72147/files#diff-54d5243f72f2568b9a3fee064247b6afd3028d50cfe36f4ae0bb8e664dfc5c6e
https://github.com/angular/angular/pull/72147/files#diff-54d5243f72f2568b9a3fee064247b6afd3028d50cfe36f4ae0bb8e664dfc5c6e
https://github.com/angular/angular/pull/72147/files#diff-54d5243f72f2568b9a3fee064247b6afd3028d50cfe36f4ae0bb8e664dfc5c6e
https://github.com/angular/angular/pull/72147/files#diff-54d5243f72f2568b9a3fee064247b6afd3028d50cfe36f4ae0bb8e664dfc5c6e
https://github.com/angular/angular/pull/72147/files#diff-54d5243f72f2568b9a3fee064247b6afd3028d50cfe36f4ae0bb8e664dfc5c6e
packages/forms/signals/test/web/form_field.spec.tshttps://github.com/angular/angular/pull/72147/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
View file https://github.com/angular/angular/blob/5ea68b49838546467f7865bbd5e405619b05a64f/packages/forms/signals/test/web/form_field.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72147/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72147/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
https://github.com/angular/angular/pull/72147/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.