Title: fix(forms): resync select when the text of an option without a value changes by lutzleonhardt · Pull Request #72147 · angular/angular · GitHub
Open Graph Title: fix(forms): resync select when the text of an option without a value changes by lutzleonhardt · Pull Request #72147 · angular/angular
X Title: fix(forms): resync select when the text of an option without a value changes by lutzleonhardt · Pull Request #72147 · angular/angular
Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? In Signal Forms, a change of an option's text ({{ label() }}) does not inform the select control, not even when the option has no value attribute and the text is its value. In B the select stays empty after label.set('two'), although the option now matches the field value. Issue Number: #71443 What is the new behavior? In B a text change now informs the select control: it selects the option once the text matches the field value, and shows nothing when the text no longer matches. A is unchanged, because with a value attribute the text is not the value of the option. Does this PR introduce a breaking change? Yes No Other information I followed the review in #71444: A text change is only relevant when the parent of the changed text node is an is not handled; but we can cover this case as well (closest('option')) if preferred I added the two requested tests and a third one: text changes away from the field value an option with an explicit value) one test for the text changing to the field value I also updated the doc comments in select.ts (the first one was stale, the second one missed the @param/@returns tags) and declares a return type of boolean.
Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
Opengraph URL: https://github.com/angular/angular/pull/72147
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9339cc52-53e3-c750-4635-b77e01ed86e6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 942A:31D532:DF8609:1288C49:6B01D222 |
| html-safe-nonce | 206062f050f242319852177fbabe3db98ce95b0706792ad08a8a50d8d2f0dc6a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDJBOjMxRDUzMjpERjg2MDk6MTI4OEM0OTo2QjAxRDIyMiIsInZpc2l0b3JfaWQiOiIyNTEwNjE4MTMxMDM1MTgxNjAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 388e6af6bc276f4fc5ca46ab07610b04a8f3f2a9fab76976d111e403d63fc304 |
| hovercard-subject-tag | pull_request:5422766617 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/72147/files |
| twitter:image | https://avatars.githubusercontent.com/u/11898898?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/11898898?s=400&v=4 |
| og:image:alt | PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width