René's URL Explorer Experiment


Title: fix(core): clear reactive consumer when creating node injectables by arturovt · Pull Request #72133 · angular/angular · GitHub

Open Graph Title: fix(core): clear reactive consumer when creating node injectables by arturovt · Pull Request #72133 · angular/angular

X Title: fix(core): clear reactive consumer when creating node injectables by arturovt · Pull Request #72133 · angular/angular

Description: Please note that this fixes a real production issue; it wasn't found speculatively through AI code analysis. R3Injector.hydrate clears the active reactive consumer before it runs a provider factory. getNodeInjectable does not. It already saves and restores four other things, but not the consumer. So creating an injectable is not reactive with the environment injector, but it is reactive with the node injector. This only shows up when a node-level provider or view provider is created late, after the view already exists. That happens through injector.get(), through runInInjectionContext(), and when a signal query reads a provider with read:. Components and directives are created in renderView, where the consumer is already null, and ɵɵpipe calls the pipe factory itself, so those do not go through this path. Here is a component with a node-level provider that is created late: @Component({ template: '{{ label }}', providers: [Lazy], }) class App { private injector = inject(Injector); get label() { return this.injector.get(Lazy).label(); } } Two problems come from this. First, a signal write in a constructor throws NG0600. The template consumer does not allow writes. A computed does not allow them either, which is how a signal query hits this too. Second, a signal read in a constructor becomes a dependency of the consumer around it. Another signal can then make that consumer dirty, and it keeps the consumer alive. There is no error, so nobody sees it. We saw the first problem in production. Lazy is our code with new names. A field initializer turned an observable into a signal: class Lazy { // field initializer, runs inside `getNodeInjectable` readonly label = toSignal(this.data.label$, { initialValue: '' }); } toSignal subscribes right away, inside its own call. It does not wait for an effect. Our source emitted a value during that subscribe. So the next handler of toSignal called .set before the constructor finished, and the template consumer of App was still active. Two things made this hard to find. The source did not look synchronous. It ends with a forkJoin, and forkJoin emits from its finalize handler. So the value came during teardown and not from a simple of(). Also, publishSignalConfiguration builds the message only when ngDevMode is on. In production it throws RuntimeError(-600, ''). Our report had only NG0600 and a short minified stack. The last frames were the toSignal callback and RxJS code. The stack did not show our class or our component. Now getNodeInjectable clears the consumer around the factory call and restores it in the finally block that is already there. This is what the environment injector does.

Open Graph Description: Please note that this fixes a real production issue; it wasn't found speculatively through AI code analysis. R3Injector.hydrate clears the active reactive consumer before it runs a provider fa...

X Description: Please note that this fixes a real production issue; it wasn't found speculatively through AI code analysis. R3Injector.hydrate clears the active reactive consumer before it runs a provide...

Opengraph URL: https://github.com/angular/angular/pull/72133

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b04ee101-ae23-5fad-d65f-166108fe4065
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id800A:136CDA:DE69B1:126DB09:6B01D15B
html-safe-nonce58bee80417d5bd5e12f35f0689e2b90529ad602acf46e8cbf96f19d1345a380a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDBBOjEzNkNEQTpERTY5QjE6MTI2REIwOTo2QjAxRDE1QiIsInZpc2l0b3JfaWQiOiIzNzE5NTE0NjI0ODMzNDk4NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb1d908722e997f38e3512f6adf4b4713751b7bd954bdc2bdf48875f0d580d83c
hovercard-subject-tagpull_request:5403020699
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/72133/files
twitter:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
og:image:altPlease note that this fixes a real production issue; it wasn't found speculatively through AI code analysis. R3Injector.hydrate clears the active reactive consumer before it runs a provider fa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/72133/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72133%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72133%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/72133/files
Reloadhttps://github.com/angular/angular/pull/72133/files
Reloadhttps://github.com/angular/angular/pull/72133/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
arturovthttps://github.com/arturovt
angular:mainhttps://github.com/angular/angular/tree/main
arturovt:fix/core-untrack-node-injectorhttps://github.com/arturovt/angular/tree/fix/core-untrack-node-injector
Conversation 3 https://github.com/angular/angular/pull/72133
Commits 1 https://github.com/angular/angular/pull/72133/commits
Checks 19 https://github.com/angular/angular/pull/72133/checks
Files changed 3 https://github.com/angular/angular/pull/72133/files
fix(core): clear reactive consumer when creating node injectables https://github.com/angular/angular/pull/72133/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/72133/files
39d7be0 fix(core): clear reactive consumer when creating node injectables arturovt Nov 19, 2026 https://github.com/angular/angular/pull/72133/commits/39d7be0453f8971abd8f7507a4b038fc42b3d69d
Clear filters https://github.com/angular/angular/pull/72133/files
Please reload this pagehttps://github.com/angular/angular/pull/72133/files
Please reload this pagehttps://github.com/angular/angular/pull/72133/files
di.ts https://github.com/angular/angular/pull/72133/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
signal_queries_spec.ts https://github.com/angular/angular/pull/72133/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
reactive_safety_spec.ts https://github.com/angular/angular/pull/72133/files#diff-5837ed4bab37c4de63dff69e598f47cbb1026573d64f18daaa2ee85a72ceb66c
packages/core/src/render3/di.tshttps://github.com/angular/angular/pull/72133/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
View file https://github.com/angular/angular/blob/39d7be0453f8971abd8f7507a4b038fc42b3d69d/packages/core/src/render3/di.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72133/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72133/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/72133/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/72133/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/72133/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/72133/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
packages/core/test/acceptance/authoring/signal_queries_spec.tshttps://github.com/angular/angular/pull/72133/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
View file https://github.com/angular/angular/blob/39d7be0453f8971abd8f7507a4b038fc42b3d69d/packages/core/test/acceptance/authoring/signal_queries_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72133/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72133/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
https://github.com/angular/angular/pull/72133/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
https://github.com/angular/angular/pull/72133/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
https://github.com/angular/angular/pull/72133/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
packages/core/test/render3/reactive_safety_spec.tshttps://github.com/angular/angular/pull/72133/files#diff-5837ed4bab37c4de63dff69e598f47cbb1026573d64f18daaa2ee85a72ceb66c
View file https://github.com/angular/angular/blob/39d7be0453f8971abd8f7507a4b038fc42b3d69d/packages/core/test/render3/reactive_safety_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72133/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72133/files#diff-5837ed4bab37c4de63dff69e598f47cbb1026573d64f18daaa2ee85a72ceb66c
https://github.com/angular/angular/pull/72133/files#diff-5837ed4bab37c4de63dff69e598f47cbb1026573d64f18daaa2ee85a72ceb66c
https://github.com/angular/angular/pull/72133/files#diff-5837ed4bab37c4de63dff69e598f47cbb1026573d64f18daaa2ee85a72ceb66c
https://github.com/angular/angular/pull/72133/files#diff-5837ed4bab37c4de63dff69e598f47cbb1026573d64f18daaa2ee85a72ceb66c
https://github.com/angular/angular/pull/72133/files#diff-5837ed4bab37c4de63dff69e598f47cbb1026573d64f18daaa2ee85a72ceb66c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.