René's URL Explorer Experiment


Title: fix(core): avoid NG0502 for nodes after `` or `@let` in content that is not projected by floxcristian · Pull Request #72131 · angular/angular · GitHub

Open Graph Title: fix(core): avoid NG0502 for nodes after `` or `@let` in content that is not projected by floxcristian · Pull Request #72131 · angular/angular

X Title: fix(core): avoid NG0502 for nodes after `` or `@let` in content that is not projected by floxcristian · Pull Request #72131 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) No docs change: the fix makes a supported case (content that is not projected) work as documented. PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #72129 With hydration enabled, server rendering fails with NG0502: During serialization, Angular was unable to find an element in the DOM when a node follows an slot or a @let declaration inside content that is not projected. For example, a component places and then an @if block inside , and app-container renders its own inside an @if that is false. An slot or a @let declaration has no DOM node, so serializeLView stores a full path for the node that follows it (annotate.ts, projection branch). It did so even when that node is disconnected from the DOM, and calcPathForNode throws for a node it can't find. What is the new behavior? One rule decides which disconnected nodes are skipped. serializeLView already annotates content-projected nodes that are disconnected from the DOM as disconnected (line 613), and the client creates those nodes instead of hydrating them. The rule: that check moves into a helper, isDisconnectedContentProjectedNode(tNode, lView), used both for that annotation and for the nodes after an slot or a @let declaration. What is skipped: after a slot or a declaration, the loop that already skips other slots and declarations also skips the nodes annotated as disconnected. The first connected node after them gets the path, so the client can locate it even when its previous sibling is disconnected. What is kept: any other node missing from the DOM keeps the NG0502 serialization error, for example a node in the component's own template that a third-party script removed. Unchanged: the projection-head check, which handles a different case. - if (isDisconnectedNode(tNode, lView) && isContentProjectedNode(tNode)) { + if (isDisconnectedContentProjectedNode(tNode, lView)) { appendDisconnectedNodeIndex(ngh, tNode); continue; } ... while ( nextTNode !== null && - nextTNode.type & (TNodeType.Projection | TNodeType.LetDeclaration) + (nextTNode.type & (TNodeType.Projection | TNodeType.LetDeclaration) || + isDisconnectedContentProjectedNode(nextTNode, lView)) ) { nextTNode = nextTNode.next; } ... +function isDisconnectedContentProjectedNode(tNode: TNode, lView: LView): boolean { + return isDisconnectedNode(tNode, lView) && isContentProjectedNode(tNode); +} Tests in packages/platform-server/test/full_app_hydration_spec.ts, under partial projection, next to "should support cases when some element nodes are not projected (@if)": "should support nodes after when the content is not projected (@if)": Components: a container (@if (open) { }), a wrapper (@if (true) {

after

}), and an app that projects text into the wrapper. Assertions: SSR succeeds, the projected content is absent from the server HTML, all nodes are claimed for hydration and the client and server contents match. Once open becomes true, the projected text and

after

render inside the container. "should support nodes after @let when the content is not projected": Components: the same container, with @let label = 'after'; followed by @if (true) {

{{ label }}

} as its content. The @let is read in a nested view, so the compiler keeps it as a @let node. Assertions: the same checks, then

after

renders once the container opens. describe('disconnected nodes that are not content projected'): pins the kept diagnostic. A directive removes an element from the DOM on the server, as a third-party script would. The element sits in the projector component's own template, so it is not content projected. "should throw NG0502 for a node after that was removed from the DOM": the projector template is

after

. "should throw NG0502 for a node after @let that was removed from the DOM": the projector template is @let label = 'after'; followed by

with the @let read in a nested @if. How they assert: both expect ssr(...) to reject with NG0502: During serialization, Angular was unable to find an element in the DOM. The promise is resolved to its error before the assertion, as getHydrationError does in this file, so a render that succeeds fails the test. describe('connected nodes after disconnected nodes'): a connected node that follows an slot or a @let declaration and one or more disconnected content-projected nodes. Each test checks that the connected node is claimed for hydration (verifyAllNodesClaimedForHydration), that the client and server contents match, and that its text renders. Multi-slot: , a

in a hidden slot, then a

in a visible slot; and the same after a @let. These already hydrated before the review change, because

is a slot head and gets a path from the projection head handling. Same slot: , a

in a hidden slot, then a

projected into the same slot as the . The

's predecessor in the slot is the projection node, which both the projection head handling and conditionallyAnnotateNodePath skip, so only this loop can anchor it. Removed node:

ok
in projected content, and the same with a @let. //packages/platform-server/test:test results, 427 specs: annotate.ts Result Failing tests main, without the fix 7 failures the two original tests and the five connected nodes after disconnected nodes tests, with NG0502 from serializeLView → appendSerializedNodePath → calcPathForNode Skipping every disconnected node after the loop (!isDisconnectedNode(nextTNode, lView)) 2 failures (422 specs, before the new tests) the two diagnostic tests: the server render succeeds, so the NG0502 is lost Skipping the next node only, without advancing the loop (first commit of this PR) 3 failures the same-slot case and the two removed-node cases, with NG0500 on the client This PR 0 failures none All targets under //packages/platform-server/... pass with this PR, as do //packages/core/test:test, //packages/core/test/acceptance:acceptance and //packages/core/test/bundling/hydration:test / :symbol_test. Does this PR introduce a breaking change? Yes No Other information Formatting: ng-dev format also reflows one existing template in full_app_hydration_spec.ts ({{ spanText }}. becomes {{ spanText }}.). That file is not Prettier-clean on main with the pinned Prettier 3.10.1, and the pre-commit formatter applies the change. It only removes whitespace inside a closing tag, so the template renders the same. Test inputs: the test components use @Input() instead of signal inputs. This target compiles the specs with TypeScript and the components JIT, so input() fields are not recognised there (NG0303), and no other test in the file uses them. Component state uses signal, and updates use await appRef.whenStable(). Out of scope: a separate problem with content that is not projected. With
in such content, server rendering succeeds even without this fix, but once the content is shown after hydration the
stays empty. ɵɵprojection does not apply the projection while hydrating, even though that
was disconnected on the server and is created fresh on the client. This PR does not change that behavior. It is reported in #72132.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...

Opengraph URL: https://github.com/angular/angular/pull/72131

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8f010845-589b-4c8d-e061-120dc870e335
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFDA:31D532:DE07FC:1269607:6B01D19A
html-safe-nonce869423d82bd05492a2a11946f09c7311b07b95615cb6b78260ebaea192d00700
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkRBOjMxRDUzMjpERTA3RkM6MTI2OTYwNzo2QjAxRDE5QSIsInZpc2l0b3JfaWQiOiI2NDQwMjY3MTY1Mzc4NjYyODEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4dc6e0959d105233431fb47d7c4f8ef5ac77339dcad00673d4b9d64531d7cca6
hovercard-subject-tagpull_request:5401237939
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/72131/files
twitter:imagehttps://avatars.githubusercontent.com/u/28737734?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/28737734?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/72131/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72131%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72131%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/72131/files
Reloadhttps://github.com/angular/angular/pull/72131/files
Reloadhttps://github.com/angular/angular/pull/72131/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
floxcristianhttps://github.com/floxcristian
angular:mainhttps://github.com/angular/angular/tree/main
floxcristian:fix-hydration-projection-disconnected-siblinghttps://github.com/floxcristian/angular/tree/fix-hydration-projection-disconnected-sibling
Conversation 3 https://github.com/angular/angular/pull/72131
Commits 2 https://github.com/angular/angular/pull/72131/commits
Checks 19 https://github.com/angular/angular/pull/72131/checks
Files changed 2 https://github.com/angular/angular/pull/72131/files
fix(core): avoid NG0502 for nodes after or @let in content that is not projected https://github.com/angular/angular/pull/72131/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/72131/files
249047d fix(core): avoid NG0502 for nodes after `` or `@let` in c… floxcristian Nov 19, 2026 https://github.com/angular/angular/pull/72131/commits/249047db7800918d6e5d64b6f99832f8496c9e1c
5b03697 fix(core): anchor the first connected node after `` or `@… floxcristian Nov 20, 2026 https://github.com/angular/angular/pull/72131/commits/5b036979567077ed30f5e4494f9ccd1843b51833
Clear filters https://github.com/angular/angular/pull/72131/files
Please reload this pagehttps://github.com/angular/angular/pull/72131/files
Please reload this pagehttps://github.com/angular/angular/pull/72131/files
annotate.ts https://github.com/angular/angular/pull/72131/files#diff-bf8ba0babd1375efd507768cc09a97f0107f23739689de00469af8134920fea9
full_app_hydration_spec.ts https://github.com/angular/angular/pull/72131/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
packages/core/src/hydration/annotate.tshttps://github.com/angular/angular/pull/72131/files#diff-bf8ba0babd1375efd507768cc09a97f0107f23739689de00469af8134920fea9
View file https://github.com/angular/angular/blob/5b036979567077ed30f5e4494f9ccd1843b51833/packages/core/src/hydration/annotate.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72131/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72131/files#diff-bf8ba0babd1375efd507768cc09a97f0107f23739689de00469af8134920fea9
https://github.com/angular/angular/pull/72131/files#diff-bf8ba0babd1375efd507768cc09a97f0107f23739689de00469af8134920fea9
https://github.com/angular/angular/pull/72131/files#diff-bf8ba0babd1375efd507768cc09a97f0107f23739689de00469af8134920fea9
https://github.com/angular/angular/pull/72131/files#diff-bf8ba0babd1375efd507768cc09a97f0107f23739689de00469af8134920fea9
https://github.com/angular/angular/pull/72131/files#diff-bf8ba0babd1375efd507768cc09a97f0107f23739689de00469af8134920fea9
https://github.com/angular/angular/pull/72131/files#diff-bf8ba0babd1375efd507768cc09a97f0107f23739689de00469af8134920fea9
packages/platform-server/test/full_app_hydration_spec.tshttps://github.com/angular/angular/pull/72131/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
View file https://github.com/angular/angular/blob/5b036979567077ed30f5e4494f9ccd1843b51833/packages/platform-server/test/full_app_hydration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72131/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72131/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
https://github.com/angular/angular/pull/72131/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
https://github.com/angular/angular/pull/72131/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
https://github.com/angular/angular/pull/72131/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.