René's URL Explorer Experiment


Title: fix(common): update KeyValuePipe when input key order changes by nagahara-naoki · Pull Request #72115 · angular/angular · GitHub

Open Graph Title: fix(common): update KeyValuePipe when input key order changes by nagahara-naoki · Pull Request #72115 · angular/angular

X Title: fix(common): update KeyValuePipe when input key order changes by nagahara-naoki · Pull Request #72115 · angular/angular

Description: Hi Angular team, This fixes the case in #72114 where reversing a Map leaves keyvalue: null showing its previous order. The same thing happens with objects whose property order changes. PR Type Bugfix What is the current behavior? The key-value differ reports additions, removals and value changes. Reordering the same entries leaves the pipe's cached array in its original order, even when the caller asks for the input's natural order. What is the new behavior? When the comparator is null and the differ and comparator are unchanged, the pipe compares the input keys with its cached output. It stops at the first mismatch and rebuilds in input order. If the order matches, it returns the same array instance. This adds a linear key scan in the unchanged natural-order case (and an Object.keys array for plain objects). The default and custom comparator paths skip that scan. Fixes #72114. Does this PR introduce a breaking change? No Tests Added regression tests for reordered Maps and objects, including a Map reordered in place and unchanged-order reference checks. Both new specs failed before the fix and passed afterwards. The common Node suite, TSLint, format check and commit message validation passed locally. The KeyValuePipe specs also passed in Chromium and Firefox. The full browser suites had two date-related failures that I reproduced on unmodified main. One Firefox run also failed a viewport scrolling spec, which passed on rerun.

Open Graph Description: Hi Angular team, This fixes the case in #72114 where reversing a Map leaves keyvalue: null showing its previous order. The same thing happens with objects whose property order changes. PR Type Bu...

X Description: Hi Angular team, This fixes the case in #72114 where reversing a Map leaves keyvalue: null showing its previous order. The same thing happens with objects whose property order changes. PR Type Bu...

Opengraph URL: https://github.com/angular/angular/pull/72115

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:76d11752-d4ac-12b5-5650-7b8bb75bc0e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEA4:29AEE8:2D6FA26:3C904BD:6B01D237
html-safe-noncebb6970ba6b07bfadc65f7bde474b4100738c5864313c789629501822d58bcb02
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUE0OjI5QUVFODoyRDZGQTI2OjNDOTA0QkQ6NkIwMUQyMzciLCJ2aXNpdG9yX2lkIjoiMTg1NjIzNTY0NjgwMTI2OTMwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9a900aff937143bed739f3607e0d2ab6eb67a00758a343775ee4817a69cd480e
hovercard-subject-tagpull_request:5395481406
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/72115/files
twitter:imagehttps://avatars.githubusercontent.com/u/118710021?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/118710021?s=400&v=4
og:image:altHi Angular team, This fixes the case in #72114 where reversing a Map leaves keyvalue: null showing its previous order. The same thing happens with objects whose property order changes. PR Type Bu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/72115/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72115%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72115%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/72115/files
Reloadhttps://github.com/angular/angular/pull/72115/files
Reloadhttps://github.com/angular/angular/pull/72115/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
nagahara-naokihttps://github.com/nagahara-naoki
angular:mainhttps://github.com/angular/angular/tree/main
nagahara-naoki:codex/keyvalue-natural-orderhttps://github.com/nagahara-naoki/angular/tree/codex/keyvalue-natural-order
Conversation 4 https://github.com/angular/angular/pull/72115
Commits 3 https://github.com/angular/angular/pull/72115/commits
Checks 11 https://github.com/angular/angular/pull/72115/checks
Files changed 2 https://github.com/angular/angular/pull/72115/files
fix(common): update KeyValuePipe when input key order changes https://github.com/angular/angular/pull/72115/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/72115/files
2562924 fix(common): update KeyValuePipe when input key order changes nagahara-naoki Nov 19, 2026 https://github.com/angular/angular/pull/72115/commits/25629241780f9ae41d3f14ef68ca635aaf7d1bf2
c72b84a perf(common): avoid allocating keys when checking natural order nagahara-naoki Nov 21, 2026 https://github.com/angular/angular/pull/72115/commits/c72b84a76a3b84fff1fbbc6ba87cfe68d05d898e
e96c965 perf(common): use Object.keys to check natural object order nagahara-naoki Nov 21, 2026 https://github.com/angular/angular/pull/72115/commits/e96c9655e0cd304f2bb5788def0b206d9195fe93
Clear filters https://github.com/angular/angular/pull/72115/files
Please reload this pagehttps://github.com/angular/angular/pull/72115/files
Please reload this pagehttps://github.com/angular/angular/pull/72115/files
keyvalue_pipe.ts https://github.com/angular/angular/pull/72115/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
keyvalue_pipe_spec.ts https://github.com/angular/angular/pull/72115/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
packages/common/src/pipes/keyvalue_pipe.tshttps://github.com/angular/angular/pull/72115/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
View file https://github.com/angular/angular/blob/e96c9655e0cd304f2bb5788def0b206d9195fe93/packages/common/src/pipes/keyvalue_pipe.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72115/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72115/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
https://github.com/angular/angular/pull/72115/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
https://github.com/angular/angular/pull/72115/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
packages/common/test/pipes/keyvalue_pipe_spec.tshttps://github.com/angular/angular/pull/72115/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
View file https://github.com/angular/angular/blob/e96c9655e0cd304f2bb5788def0b206d9195fe93/packages/common/test/pipes/keyvalue_pipe_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72115/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72115/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com/angular/angular/pull/72115/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com/angular/angular/pull/72115/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com/angular/angular/pull/72115/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.