René's URL Explorer Experiment


Title: fix(compiler-cli): preserve template key order in ɵsetClassMetadata with templateUrl by mattrbeck · Pull Request #72104 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): preserve template key order in ɵsetClassMetadata with templateUrl by mattrbeck · Pull Request #72104 · angular/angular

X Title: fix(compiler-cli): preserve template key order in ɵsetClassMetadata with templateUrl by mattrbeck · Pull Request #72104 · angular/angular

Description: When a @Component decorator specifies both an inline template and a templateUrl (where templateUrl takes precedence), ngtsc's transformDecoratorResources builds a Map from the object literal properties and calls metadata.set('template', ...) without deleting 'template' first, updating the existing 'template' key at its original property position. In ngp, directive.rs previously dropped "template" from preserved_decorator_properties and inlineDecoratorResources unconditionally appended the resolved template: "..." at the end of the object literal in ɵsetClassMetadata. In addition, directive.rs and component.rs matched extract_property_key(&p.key) without checking !p.computed, causing computed keys like [template] or [templateUrl] to be treated as Angular resource metadata. extract_directive_metadata and parse_component_metadata now ignore computed/method/accessor keys when matching Angular decorator metadata properties (still preserving them verbatim in preserved_decorator_properties), record the first superseded template slot in inline_template_index when templateUrl is also present, and splice the resolved template property at inlineTemplateIndex in inlineDecoratorResources. Minimal failure example import {Component} from '@angular/core'; @Component({ template: 'ignored inline', selector: 'my-cmp', templateUrl: './my-cmp.html', // contains `

From file

` }) export class MyCmp {} Before (main): i0.ɵsetClassMetadata( MyCmp, [{ type: Component, args: [{ selector: 'my-cmp', template: "

From file

" }] }], null, null, ); After: i0.ɵsetClassMetadata( MyCmp, [{ type: Component, args: [{ template: "

From file

", selector: 'my-cmp' }] }], null, null, ); Reservations Cosmetic / syntactic parity with ngtsc for inline_template_index: Writing both template and templateUrl on the same @Component is redundant authoring (template is ignored in favor of templateUrl), and Angular's TestBed reads args[0].template by property lookup rather than Object.keys() iteration order. Plumbing inline_template_index across the Rust/TS metadata boundary exists strictly for syntactic output equivalence with ngtsc; TODO comments mark both the Rust and TypeScript sites for removal once ngp is the default compiler (whereas the !p.computed && !p.method && p.kind == PropertyKind::Init check is a genuine semantic fix worth keeping permanently).

Open Graph Description: When a @Component decorator specifies both an inline template and a templateUrl (where templateUrl takes precedence), ngtsc's transformDecoratorResources builds a Map from the object literal pr...

X Description: When a @Component decorator specifies both an inline template and a templateUrl (where templateUrl takes precedence), ngtsc's transformDecoratorResources builds a Map from the object litera...

Opengraph URL: https://github.com/angular/angular/pull/72104

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:639faa11-cdcd-3895-d8c2-a07c4696aada
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF14:2A7C1C:E40904:12DA80F:6B01D191
html-safe-nonce64ea8d8a5ffa2110532e30bcac346f743877b727743a495aede6b338542c7550
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjE0OjJBN0MxQzpFNDA5MDQ6MTJEQTgwRjo2QjAxRDE5MSIsInZpc2l0b3JfaWQiOiI3MDUwOTg4MjQ0NzM3MDUzMDczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7fa1ee3e97fe79a00540f197adb75eca2a72bedc6cb982842e3871e5bf2f7bf6
hovercard-subject-tagpull_request:5389072204
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/72104/files
twitter:imagehttps://avatars.githubusercontent.com/u/22065329?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/22065329?s=400&v=4
og:image:altWhen a @Component decorator specifies both an inline template and a templateUrl (where templateUrl takes precedence), ngtsc's transformDecoratorResources builds a Map from the object literal pr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/72104/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72104%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72104%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/72104/files
Reloadhttps://github.com/angular/angular/pull/72104/files
Reloadhttps://github.com/angular/angular/pull/72104/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
mattrbeckhttps://github.com/mattrbeck
angular:mainhttps://github.com/angular/angular/tree/main
mattrbeck:fix/ngp-inline-template-metadata-orderhttps://github.com/mattrbeck/angular/tree/fix/ngp-inline-template-metadata-order
Conversation 0 https://github.com/angular/angular/pull/72104
Commits 2 https://github.com/angular/angular/pull/72104/commits
Checks 19 https://github.com/angular/angular/pull/72104/checks
Files changed 7 https://github.com/angular/angular/pull/72104/files
fix(compiler-cli): preserve template key order in ɵsetClassMetadata with templateUrl https://github.com/angular/angular/pull/72104/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/72104/files
e7ba1dc test(compiler-cli): add failing spec for template key order with temp… mattrbeck Nov 19, 2026 https://github.com/angular/angular/pull/72104/commits/e7ba1dc21a6c7a754cb75f8e009ec81142601b14
c8526cb fix(compiler-cli): preserve template key order in ɵsetClassMetadata w… mattrbeck Nov 19, 2026 https://github.com/angular/angular/pull/72104/commits/c8526cb2508c3460a97c0152fe463495b99b9614
Clear filters https://github.com/angular/angular/pull/72104/files
Please reload this pagehttps://github.com/angular/angular/pull/72104/files
Please reload this pagehttps://github.com/angular/angular/pull/72104/files
class_data.rs https://github.com/angular/angular/pull/72104/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
component.rs https://github.com/angular/angular/pull/72104/files#diff-e78084ae6cb61e6f5797db1d2dbf579fc97e90cccf92f4084b73f35f647a33a4
directive.rs https://github.com/angular/angular/pull/72104/files#diff-73f1dc8dcc7ebf89b7369147270ac5ba9d18eaff0a8074350b8fb8cc681f728e
metadata.rs https://github.com/angular/angular/pull/72104/files#diff-7dd1a6a781a2fec077b0267fe9c5d7c219759d7c214f0841e3472b31061cc735
processor.ts https://github.com/angular/angular/pull/72104/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
types.ts https://github.com/angular/angular/pull/72104/files#diff-5cda70b78e16ec0f651d4b12291a191ac5d8e4d2f684fb7aeac0d92c9572cdac
resource_resolution_spec.ts https://github.com/angular/angular/pull/72104/files#diff-947df506f37b7f7bcf951b205532278c2aa4d30e4f3762ef1450b2c4ec651a2a
packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/class_data.rshttps://github.com/angular/angular/pull/72104/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
View file https://github.com/angular/angular/blob/c8526cb2508c3460a97c0152fe463495b99b9614/packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/class_data.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72104/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72104/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
https://github.com/angular/angular/pull/72104/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
https://github.com/angular/angular/pull/72104/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
https://github.com/angular/angular/pull/72104/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
https://github.com/angular/angular/pull/72104/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
https://github.com/angular/angular/pull/72104/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/component.rshttps://github.com/angular/angular/pull/72104/files#diff-e78084ae6cb61e6f5797db1d2dbf579fc97e90cccf92f4084b73f35f647a33a4
View file https://github.com/angular/angular/blob/c8526cb2508c3460a97c0152fe463495b99b9614/packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/component.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72104/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72104/files#diff-e78084ae6cb61e6f5797db1d2dbf579fc97e90cccf92f4084b73f35f647a33a4
https://github.com/angular/angular/pull/72104/files#diff-e78084ae6cb61e6f5797db1d2dbf579fc97e90cccf92f4084b73f35f647a33a4
packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/directive.rshttps://github.com/angular/angular/pull/72104/files#diff-73f1dc8dcc7ebf89b7369147270ac5ba9d18eaff0a8074350b8fb8cc681f728e
View file https://github.com/angular/angular/blob/c8526cb2508c3460a97c0152fe463495b99b9614/packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/directive.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72104/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72104/files#diff-73f1dc8dcc7ebf89b7369147270ac5ba9d18eaff0a8074350b8fb8cc681f728e
https://github.com/angular/angular/pull/72104/files#diff-73f1dc8dcc7ebf89b7369147270ac5ba9d18eaff0a8074350b8fb8cc681f728e
https://github.com/angular/angular/pull/72104/files#diff-73f1dc8dcc7ebf89b7369147270ac5ba9d18eaff0a8074350b8fb8cc681f728e
https://github.com/angular/angular/pull/72104/files#diff-73f1dc8dcc7ebf89b7369147270ac5ba9d18eaff0a8074350b8fb8cc681f728e
packages/compiler-cli/preprocessor/ng-analyze/src/types/metadata.rshttps://github.com/angular/angular/pull/72104/files#diff-7dd1a6a781a2fec077b0267fe9c5d7c219759d7c214f0841e3472b31061cc735
View file https://github.com/angular/angular/blob/c8526cb2508c3460a97c0152fe463495b99b9614/packages/compiler-cli/preprocessor/ng-analyze/src/types/metadata.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72104/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72104/files#diff-7dd1a6a781a2fec077b0267fe9c5d7c219759d7c214f0841e3472b31061cc735
https://github.com/angular/angular/pull/72104/files#diff-7dd1a6a781a2fec077b0267fe9c5d7c219759d7c214f0841e3472b31061cc735
packages/compiler-cli/preprocessor/src/processor.tshttps://github.com/angular/angular/pull/72104/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
View file https://github.com/angular/angular/blob/c8526cb2508c3460a97c0152fe463495b99b9614/packages/compiler-cli/preprocessor/src/processor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72104/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72104/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
https://github.com/angular/angular/pull/72104/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
https://github.com/angular/angular/pull/72104/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
https://github.com/angular/angular/pull/72104/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
https://github.com/angular/angular/pull/72104/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
https://github.com/angular/angular/pull/72104/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
packages/compiler-cli/preprocessor/src/types.tshttps://github.com/angular/angular/pull/72104/files#diff-5cda70b78e16ec0f651d4b12291a191ac5d8e4d2f684fb7aeac0d92c9572cdac
View file https://github.com/angular/angular/blob/c8526cb2508c3460a97c0152fe463495b99b9614/packages/compiler-cli/preprocessor/src/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72104/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72104/files#diff-5cda70b78e16ec0f651d4b12291a191ac5d8e4d2f684fb7aeac0d92c9572cdac
https://github.com/angular/angular/pull/72104/files#diff-5cda70b78e16ec0f651d4b12291a191ac5d8e4d2f684fb7aeac0d92c9572cdac
packages/compiler-cli/preprocessor/test/resource_resolution_spec.tshttps://github.com/angular/angular/pull/72104/files#diff-947df506f37b7f7bcf951b205532278c2aa4d30e4f3762ef1450b2c4ec651a2a
View file https://github.com/angular/angular/blob/c8526cb2508c3460a97c0152fe463495b99b9614/packages/compiler-cli/preprocessor/test/resource_resolution_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72104/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72104/files#diff-947df506f37b7f7bcf951b205532278c2aa4d30e4f3762ef1450b2c4ec651a2a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.