René's URL Explorer Experiment
Title: fix(compiler-cli): treat same-file enums and value companions as verified DI values by mattrbeck · Pull Request #72103 · angular/angular · GitHub
Open Graph Title: fix(compiler-cli): treat same-file enums and value companions as verified DI values by mattrbeck · Pull Request #72103 · angular/angular
X Title: fix(compiler-cli): treat same-file enums and value companions as verified DI values by mattrbeck · Pull Request #72103 · angular/angular
Description: In get_type_reference_info (ng-analyze/src/analyzer/mod.rs), ngp previously only marked same-file SymbolFlags::Class symbols as TypeRefInfo::VERIFIED_VALUE, leaving all other same-file runtime value declarations (non-const enums, interface Token {} + const Token = new InjectionToken(...) companions, and instantiated namespace members) as UNVERIFIED_VALUE. As a result:
When @Inject(TOKEN) overrode a constructor parameter typed with a same-file enum or value companion (@Inject(TOK) mode: StyleEnum), get_constructor_params forced is_type_only = true (!is_value_verified), emitting { type: undefined, decorators: [...] } in ɵsetClassMetadata instead of { type: StyleEnum, decorators: [...] }.
Without @Inject, optimize: false wrapped same-file enum / companion tokens in an unnecessary // @ts-ignore, and optimize: true ran a redundant resolve_symbol_value_kind chase (which also misclassified a local enum Foo as TypeOnly / NG2003 when the file contained export { Foo } from './iface').
Same-file qualified references (Ns.Mode, Ns.PureInterface, StyleEnum.ONE, MyWidget.Options) were neither verified nor checked for NG2003 when Ns was a local value namespace.
get_type_reference_info now verifies same-file non-ambient runtime values (RegularEnum, variable/function value companions, and instantiated TSNamespaceDeclarations, as well as qualified Enum.Member, Class.StaticMember, and exported Ns.Member lookups) as TypeRefInfo::VERIFIED_VALUE, while diagnosing type-only members inside instantiated same-file namespaces as NoValueDeclaration.
Minimal failure example
import {Component, Inject, InjectionToken} from '@angular/core';
export const TOK = new InjectionToken('TOK');
export enum StyleEnum { ONE = 0, TWO = 1 }
@Component({selector: 'my-cmp', template: ''})
export class MyCmp {
constructor(@Inject(TOK) mode: StyleEnum) {}
}
Before (main, with optimize: false):
i0.ɵsetClassMetadata(
MyCmp,
[{ type: Component, args: [{ selector: 'my-cmp', template: '' }] }],
() => [{ type: undefined, decorators: [{ type: Inject, args: [TOK] }] }],
null,
);
After (both optimize: false and optimize: true):
i0.ɵsetClassMetadata(
MyCmp,
[{ type: Component, args: [{ selector: 'my-cmp', template: '' }] }],
() => [{ type: StyleEnum, decorators: [{ type: Inject, args: [TOK] }] }],
null,
);
Reservations
Scope of same-file qualified namespace walking (~200 LOC): Supporting qualified same-file Ns.Member, Enum.Member, and Class.StaticMember references (classify_same_file_qualified_type) accounts for most of the added code to handle relatively uncommon in-file TypeScript namespace patterns (benchmarked at ~25 ns/call in -c opt, vs. ~3.5–12 ns/call for unqualified classes/enums/companions). If we prefer a smaller maintenance footprint, keeping only unqualified has_non_ambient_runtime_value (~60 LOC total) still covers all unqualified enums and interface + const InjectionToken companions.
Intentional divergence from ngtsc on ambient declare in .ts files: ngtsc treats declare enum AmbientEnum { A = 0 } in a .ts file as a verified runtime value and emits { type: AmbientEnum } even when @Inject(TOK) overrides the DI token, which throws a ReferenceError in TestBed if no global AmbientEnum exists at runtime. ng-analyze intentionally requires at least one non-ambient value declaration (!is_in_ambient_context) before marking a non-class symbol as VERIFIED_VALUE.
Open Graph Description: In get_type_reference_info (ng-analyze/src/analyzer/mod.rs), ngp previously only marked same-file SymbolFlags::Class symbols as TypeRefInfo::VERIFIED_VALUE, leaving all other same-file runtime valu...
X Description: In get_type_reference_info (ng-analyze/src/analyzer/mod.rs), ngp previously only marked same-file SymbolFlags::Class symbols as TypeRefInfo::VERIFIED_VALUE, leaving all other same-file runtime valu...
Opengraph URL: https://github.com/angular/angular/pull/72103
X: @github
direct link
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ac6c307d-3f2a-7dad-c680-9e5abc9d6b6c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CF2C:34DB8F:2B308C1:39C7258:6B01D193 |
| html-safe-nonce | 0ffe3d5d84bd1be597480080a6b96f624a09e90f6c677441d250c7e81bf96d54 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjJDOjM0REI4RjoyQjMwOEMxOjM5QzcyNTg6NkIwMUQxOTMiLCJ2aXNpdG9yX2lkIjoiOTA3MDg4ODY2MDg0ODcyNjQxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2e4e1cc7b578a5e374deed64c50bbb1dc1030761bc089426f227d08dc4cc9b24 |
| hovercard-subject-tag | pull_request:5389057728 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/72103/files |
| twitter:image | https://avatars.githubusercontent.com/u/22065329?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/22065329?s=400&v=4 |
| og:image:alt | In get_type_reference_info (ng-analyze/src/analyzer/mod.rs), ngp previously only marked same-file SymbolFlags::Class symbols as TypeRefInfo::VERIFIED_VALUE, leaving all other same-file runtime valu... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
| Skip to content | https://github.com/angular/angular/pull/72103/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72103%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72103%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/72103/files |
| Reload | https://github.com/angular/angular/pull/72103/files |
| Reload | https://github.com/angular/angular/pull/72103/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests142 (142) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| mattrbeck | https://github.com/mattrbeck |
| angular:main | https://github.com/angular/angular/tree/main |
| mattrbeck:fix/ngp-same-file-runtime-value-di | https://github.com/mattrbeck/angular/tree/fix/ngp-same-file-runtime-value-di |
|
Conversation
0
| https://github.com/angular/angular/pull/72103 |
|
Commits
2
| https://github.com/angular/angular/pull/72103/commits |
|
Checks
19
| https://github.com/angular/angular/pull/72103/checks |
|
Files changed
| https://github.com/angular/angular/pull/72103/files |
| Please reload this page | https://github.com/angular/angular/pull/72103/files |
|
fix(compiler-cli): treat same-file enums and value companions as verified DI values
| https://github.com/angular/angular/pull/72103/files#top |
|
Show all changes
2 commits
| https://github.com/angular/angular/pull/72103/files |
|
a3042cc
test(compiler-cli): add failing specs for same-file enum and companio…
mattrbeck Nov 19, 2026
| https://github.com/angular/angular/pull/72103/commits/a3042cca9f878264da0c4b0acabd3206a0ff9642 |
|
e46faea
fix(compiler-cli): treat same-file enums and value companions as veri…
mattrbeck Nov 19, 2026
| https://github.com/angular/angular/pull/72103/commits/e46faeab1df66416eb3c8935c90a7454e21ff8ba |
|
Clear filters
| https://github.com/angular/angular/pull/72103/files |
| Please reload this page | https://github.com/angular/angular/pull/72103/files |
| Please reload this page | https://github.com/angular/angular/pull/72103/files |
|
mod.rs
| https://github.com/angular/angular/pull/72103/files#diff-e8abc723215a6b9373dd1793a40b52f86a2699e28edbc205a3f7d8d77407e6fa |
|
constructor_di_named_imports_spec.ts
| https://github.com/angular/angular/pull/72103/files#diff-a266da50b816943998133b6db1e47c11a00103d6e5a116b64364edefbe55961d |
| Please reload this page | https://github.com/angular/angular/pull/72103/files |
| Please reload this page | https://github.com/angular/angular/pull/72103/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |
Viewport: width=device-width
URLs of crawlers that visited me.