René's URL Explorer Experiment


Title: refactor(compiler-cli): extract empty .d.ts ngContentSelectors and skip redundant dependency prefetches by atscott · Pull Request #72099 · angular/angular · GitHub

Open Graph Title: refactor(compiler-cli): extract empty .d.ts ngContentSelectors and skip redundant dependency prefetches by atscott · Pull Request #72099 · angular/angular

X Title: refactor(compiler-cli): extract empty .d.ts ngContentSelectors and skip redundant dependency prefetches by atscott · Pull Request #72099 · angular/angular

Description: External .d.ts components without emit never as the 7th type argument of ɵɵComponentDeclaration. extract_ng_content_selectors_from_type in dts.rs previously returned None for non-tuple types, empty tuples, and tuples without string-literal elements. Because DeclarationMetadata.ngContentSelectors arrived unset, DependencyTemplates treated those .d.ts components as unparsed source components, ran getMetadataForFile (AnalyzeFileWire and AnalyzeFileSemantic) on their declaration files, read the .d.ts files from disk, and parsed empty templates for each class. utils::is_dts in ng-analyze and the .d.ts checks in the TypeScript pipeline also matched only .d.ts rather than .d.mts and .d.cts. In addition, DependencyTemplates.prefetch read .ts dependency files from disk when every needed component used templateUrl or an indirect template expression, and processFile ran prefetch again even when prepareChunk had already bound preparedTcbData for the file's current content. This change aligns extract_ng_content_selectors_from_type with ngtsc's DtsMetadataReader (readStringArrayType) so any present 7th type argument without string-literal tuple elements resolves to Some(vec![]), returning None only when ɵɵComponentDeclaration has fewer than 7 type arguments. utils::is_dts, is_ts_file, and is_compilation_root now delegate to ModuleFormat::from_path so .d.mts and .d.cts files are analyzed as declaration files. On the TypeScript side, isDeclarationFilePath and needsNgContentSelectors handle .d.ts, .d.mts, and .d.cts consistently across ngp, DependencyTemplates, HybridCompiler, IncrementalEmitTracker, OutOfBandDiagnosticRecorderImpl, and processFile, preventing legacy declaration files without the 7th type argument from triggering emit, template prefetches, or consumer tracking. DependencyTemplates.prefetch now reads .ts dependency source text only when at least one requested component uses a direct inline template (reusing and caching FileAnalysis.sourceContent), and processFile skips prefetch when preparedTcbData is already bound for the current content or when generating an HMR update module. On a cold optimized build of a component target importing ~30 external UI and CDK .d.ts libraries, this reduces filesystem reads from 532 to 425 (-107 reads, -530 KB), cuts AnalyzeFileWire and AnalyzeFileSemantic queries from 37 to 10 with zero .d.ts re-queries, drops TemplatesParsed from 80 to 14, and reduces PrepareChunk time by ~200 to 320 ms across standalone CLI and persistent sidecar worker runs.

Open Graph Description: External .d.ts components without <ng-content> emit never as the 7th type argument of ɵɵComponentDeclaration. extract_ng_content_selectors_from_type in dts.rs previously returned None for non...

X Description: External .d.ts components without &lt;ng-content&gt; emit never as the 7th type argument of ɵɵComponentDeclaration. extract_ng_content_selectors_from_type in dts.rs previously returned None...

Opengraph URL: https://github.com/angular/angular/pull/72099

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:501692a9-02e8-b60d-e216-25c65390f871
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9812:269AD9:2D1B8DA:3C40B1C:6B01D246
html-safe-nonce8d848c13149f8c623a411d4f8f2c29038298a2ec0d8dcc115025dc91a16d9d90
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODEyOjI2OUFEOToyRDFCOERBOjNDNDBCMUM6NkIwMUQyNDYiLCJ2aXNpdG9yX2lkIjoiODMyMTM0NDIwOTczNDk4MDE2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6f7256da0903426ae62b2ce0ea73921f997d3b186442fe2f9ece0a56a1ed6a4e
hovercard-subject-tagpull_request:5386806476
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/72099/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altExternal .d.ts components without <ng-content> emit never as the 7th type argument of ɵɵComponentDeclaration. extract_ng_content_selectors_from_type in dts.rs previously returned None for non...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/72099/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72099%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72099%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/72099/files
Reloadhttps://github.com/angular/angular/pull/72099/files
Reloadhttps://github.com/angular/angular/pull/72099/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:ngp-dts-ngcontent-prefetchhttps://github.com/atscott/angular/tree/ngp-dts-ngcontent-prefetch
Conversation 0 https://github.com/angular/angular/pull/72099
Commits 2 https://github.com/angular/angular/pull/72099/commits
Checks 19 https://github.com/angular/angular/pull/72099/checks
Files changed 13 https://github.com/angular/angular/pull/72099/files
refactor(compiler-cli): extract empty .d.ts ngContentSelectors and skip redundant dependency prefetches https://github.com/angular/angular/pull/72099/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/72099/files
f39ad77 refactor(compiler-cli): align .d.ts ngContentSelectors extraction wit… atscott Nov 19, 2026 https://github.com/angular/angular/pull/72099/commits/f39ad77d68d02d36200f6afa09b2d9da565f074b
16b800f refactor(compiler-cli): skip redundant dependency template prefetches atscott Nov 19, 2026 https://github.com/angular/angular/pull/72099/commits/16b800f1297a93645c06a69fee2fe993bd5461ee
Clear filters https://github.com/angular/angular/pull/72099/files
Please reload this pagehttps://github.com/angular/angular/pull/72099/files
Please reload this pagehttps://github.com/angular/angular/pull/72099/files
dts.rs https://github.com/angular/angular/pull/72099/files#diff-a65efa15fadb99d27dcfd146e15a029f4c9ab9c444d6d8336f455b4294df9866
tests.rs https://github.com/angular/angular/pull/72099/files#diff-4a5760cb70939aeccfaa453b057b119cae8e60ffa6d0ef380c41583615683a27
mod.rs https://github.com/angular/angular/pull/72099/files#diff-9fdbe282ea943bf00abfa8089073356e8317e1ec0204425238b7e264b7689078
tests.rs https://github.com/angular/angular/pull/72099/files#diff-9ff55848d2202d4d7a8209aa3ac33bec000cdca10a52d66ba88e1038d6df5609
ngp.ts https://github.com/angular/angular/pull/72099/files#diff-fc0672bc2b0b446af7dca61c5c8c7f97f6ead8b6cb825a07c11ac870da3a3693
compiler-utils.ts https://github.com/angular/angular/pull/72099/files#diff-7429da6290fa09a175ba4f6fb1099de0cd3ac89c6b0566fac6ee74185343e835
dependency_templates.ts https://github.com/angular/angular/pull/72099/files#diff-a1c512d36f7bc7e77d569c55e82d1c182804392b6edafde5b61cd63776098086
hybrid_compiler.ts https://github.com/angular/angular/pull/72099/files#diff-60223c41d836c73215d29429fd266fd4aa0f5dc0303245d235aab7c2c6e4dbed
incremental.ts https://github.com/angular/angular/pull/72099/files#diff-96ff2d230bac437b0279fe251c4166838bb357d8c4369c67a9e32332cfe0ae5a
oob.ts https://github.com/angular/angular/pull/72099/files#diff-9180cedc6cc5ef0909186afebc066623107d374b5c27a4c684c7c10449e39099
processor.ts https://github.com/angular/angular/pull/72099/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
dependency_templates_spec.ts https://github.com/angular/angular/pull/72099/files#diff-f2865723c60ff5cb68de7863dc94b838bb9f0d5eae170056827d9ec5421145bc
incremental_emit_tracker_spec.ts https://github.com/angular/angular/pull/72099/files#diff-3d14424d6866fbe56c2aab7ecb1bd810b6460134cfa782d1d2b11d85b4ca8e33
packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/dts.rshttps://github.com/angular/angular/pull/72099/files#diff-a65efa15fadb99d27dcfd146e15a029f4c9ab9c444d6d8336f455b4294df9866
View file https://github.com/angular/angular/blob/16b800f1297a93645c06a69fee2fe993bd5461ee/packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/dts.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72099/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72099/files#diff-a65efa15fadb99d27dcfd146e15a029f4c9ab9c444d6d8336f455b4294df9866
https://github.com/angular/angular/pull/72099/files#diff-a65efa15fadb99d27dcfd146e15a029f4c9ab9c444d6d8336f455b4294df9866
https://github.com/angular/angular/pull/72099/files#diff-a65efa15fadb99d27dcfd146e15a029f4c9ab9c444d6d8336f455b4294df9866
https://github.com/angular/angular/pull/72099/files#diff-a65efa15fadb99d27dcfd146e15a029f4c9ab9c444d6d8336f455b4294df9866
https://github.com/angular/angular/pull/72099/files#diff-a65efa15fadb99d27dcfd146e15a029f4c9ab9c444d6d8336f455b4294df9866
https://github.com/angular/angular/pull/72099/files#diff-a65efa15fadb99d27dcfd146e15a029f4c9ab9c444d6d8336f455b4294df9866
packages/compiler-cli/preprocessor/ng-analyze/src/compiler/tests.rshttps://github.com/angular/angular/pull/72099/files#diff-4a5760cb70939aeccfaa453b057b119cae8e60ffa6d0ef380c41583615683a27
View file https://github.com/angular/angular/blob/16b800f1297a93645c06a69fee2fe993bd5461ee/packages/compiler-cli/preprocessor/ng-analyze/src/compiler/tests.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72099/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72099/files#diff-4a5760cb70939aeccfaa453b057b119cae8e60ffa6d0ef380c41583615683a27
packages/compiler-cli/preprocessor/ng-analyze/src/utils/mod.rshttps://github.com/angular/angular/pull/72099/files#diff-9fdbe282ea943bf00abfa8089073356e8317e1ec0204425238b7e264b7689078
View file https://github.com/angular/angular/blob/16b800f1297a93645c06a69fee2fe993bd5461ee/packages/compiler-cli/preprocessor/ng-analyze/src/utils/mod.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72099/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72099/files#diff-9fdbe282ea943bf00abfa8089073356e8317e1ec0204425238b7e264b7689078
https://github.com/angular/angular/pull/72099/files#diff-9fdbe282ea943bf00abfa8089073356e8317e1ec0204425238b7e264b7689078
https://github.com/angular/angular/pull/72099/files#diff-9fdbe282ea943bf00abfa8089073356e8317e1ec0204425238b7e264b7689078
packages/compiler-cli/preprocessor/ng-analyze/src/utils/tests.rshttps://github.com/angular/angular/pull/72099/files#diff-9ff55848d2202d4d7a8209aa3ac33bec000cdca10a52d66ba88e1038d6df5609
View file https://github.com/angular/angular/blob/16b800f1297a93645c06a69fee2fe993bd5461ee/packages/compiler-cli/preprocessor/ng-analyze/src/utils/tests.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72099/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72099/files#diff-9ff55848d2202d4d7a8209aa3ac33bec000cdca10a52d66ba88e1038d6df5609
https://github.com/angular/angular/pull/72099/files#diff-9ff55848d2202d4d7a8209aa3ac33bec000cdca10a52d66ba88e1038d6df5609
https://github.com/angular/angular/pull/72099/files#diff-9ff55848d2202d4d7a8209aa3ac33bec000cdca10a52d66ba88e1038d6df5609
packages/compiler-cli/preprocessor/ngp.tshttps://github.com/angular/angular/pull/72099/files#diff-fc0672bc2b0b446af7dca61c5c8c7f97f6ead8b6cb825a07c11ac870da3a3693
View file https://github.com/angular/angular/blob/16b800f1297a93645c06a69fee2fe993bd5461ee/packages/compiler-cli/preprocessor/ngp.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72099/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72099/files#diff-fc0672bc2b0b446af7dca61c5c8c7f97f6ead8b6cb825a07c11ac870da3a3693
https://github.com/angular/angular/pull/72099/files#diff-fc0672bc2b0b446af7dca61c5c8c7f97f6ead8b6cb825a07c11ac870da3a3693
https://github.com/angular/angular/pull/72099/files#diff-fc0672bc2b0b446af7dca61c5c8c7f97f6ead8b6cb825a07c11ac870da3a3693
https://github.com/angular/angular/pull/72099/files#diff-fc0672bc2b0b446af7dca61c5c8c7f97f6ead8b6cb825a07c11ac870da3a3693
packages/compiler-cli/preprocessor/src/compiler-utils.tshttps://github.com/angular/angular/pull/72099/files#diff-7429da6290fa09a175ba4f6fb1099de0cd3ac89c6b0566fac6ee74185343e835
View file https://github.com/angular/angular/blob/16b800f1297a93645c06a69fee2fe993bd5461ee/packages/compiler-cli/preprocessor/src/compiler-utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72099/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72099/files#diff-7429da6290fa09a175ba4f6fb1099de0cd3ac89c6b0566fac6ee74185343e835
https://github.com/angular/angular/pull/72099/files#diff-7429da6290fa09a175ba4f6fb1099de0cd3ac89c6b0566fac6ee74185343e835
https://github.com/angular/angular/pull/72099/files#diff-7429da6290fa09a175ba4f6fb1099de0cd3ac89c6b0566fac6ee74185343e835
https://github.com/angular/angular/pull/72099/files#diff-7429da6290fa09a175ba4f6fb1099de0cd3ac89c6b0566fac6ee74185343e835
Please reload this pagehttps://github.com/angular/angular/pull/72099/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.