René's URL Explorer Experiment


Title: fix(forms): restore custom control values when a field change is reverted by nagahara-naoki · Pull Request #72097 · angular/angular · GitHub

Open Graph Title: fix(forms): restore custom control values when a field change is reverted by nagahara-naoki · Pull Request #72097 · angular/angular

X Title: fix(forms): restore custom control values when a field change is reverted by nagahara-naoki · Pull Request #72097 · angular/angular

Description: Hi Angular team!! I reproduced #72065 with a custom input that clears itself on Escape. When a parent handler restores the field’s previous value during the same keypress, the field and the input end up showing different values. This change keeps them in sync. PR Checklist The commit message follows the Angular commit message guidelines. Tests for the change have been added. Docs have been added or updated. PR Type Bugfix What is the current behavior? Suppose the field starts at "Ada". Pressing Escape clears the input’s model(), then the parent restores the field to "Ada". Angular remembers "Ada" as the last value it wrote to the control, so it skips the write that would restore the input. After rendering, the field contains "Ada" and the input is empty. Fixes #72065. What is the new behavior? When the control emits a value that differs from the last value Angular wrote to it, Angular invalidates the cached value for that control. On the next render, it writes the field’s final value back to the input. This also preserves support for controls with separate value and valueChange properties. Those controls can emit a change and rely on Angular to write the new value back to their input. Caching the emitted value directly would skip that write. Does this PR introduce a breaking change? Yes No Other information I added a regression test that edits the control’s model and restores the field’s previous value before the next render. I also extended the existing test for separate input and output properties to check the value the control actually receives. The Signal Forms web test suite passed in Chromium and Firefox.

Open Graph Description: Hi Angular team!! I reproduced #72065 with a custom input that clears itself on Escape. When a parent handler restores the field’s previous value during the same keypress, the field and the input e...

X Description: Hi Angular team!! I reproduced #72065 with a custom input that clears itself on Escape. When a parent handler restores the field’s previous value during the same keypress, the field and the input e...

Opengraph URL: https://github.com/angular/angular/pull/72097

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c47c94c6-c1f5-5ef9-1512-5ee2a7cc62da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC7C:36A3E:2DAD92F:3CF34D5:6B01DAD7
html-safe-nonced32a93e440c4e17a4f513b321310b93aeccecb6f77bc24fae66b540c6a1b3801
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzdDOjM2QTNFOjJEQUQ5MkY6M0NGMzRENTo2QjAxREFENyIsInZpc2l0b3JfaWQiOiIyMjU5NTUzMzk1Mzg1OTQ4ODg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb596250b5d633a31a97c0fbfac51ff683d7c27b0c77ea1799ae33477020226c2
hovercard-subject-tagpull_request:5385932204
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/72097/files
twitter:imagehttps://avatars.githubusercontent.com/u/118710021?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/118710021?s=400&v=4
og:image:altHi Angular team!! I reproduced #72065 with a custom input that clears itself on Escape. When a parent handler restores the field’s previous value during the same keypress, the field and the input e...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/72097/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72097%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72097%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/72097/files
Reloadhttps://github.com/angular/angular/pull/72097/files
Reloadhttps://github.com/angular/angular/pull/72097/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
nagahara-naokihttps://github.com/nagahara-naoki
angular:mainhttps://github.com/angular/angular/tree/main
nagahara-naoki:codex/forms-restore-custom-control-valuehttps://github.com/nagahara-naoki/angular/tree/codex/forms-restore-custom-control-value
Conversation 1 https://github.com/angular/angular/pull/72097
Commits 4 https://github.com/angular/angular/pull/72097/commits
Checks 11 https://github.com/angular/angular/pull/72097/checks
Files changed 3 https://github.com/angular/angular/pull/72097/files
fix(forms): restore custom control values when a field change is reverted https://github.com/angular/angular/pull/72097/files#top
Show all changes 4 commits https://github.com/angular/angular/pull/72097/files
1618c05 fix(forms): restore custom control values when a field change is reve… nagahara-naoki Nov 18, 2026 https://github.com/angular/angular/pull/72097/commits/1618c05fd69b2a91195845172497b31b64774c60
0bed12c test(forms): cover custom control writeback and parent form reset nagahara-naoki Nov 21, 2026 https://github.com/angular/angular/pull/72097/commits/0bed12c3c69e07b1c295aea6cd77de67ad2b20fd
2d08fc9 Merge main into the forms writeback fix nagahara-naoki Nov 21, 2026 https://github.com/angular/angular/pull/72097/commits/2d08fc9b7cce7939d90d4fd38dbb7cc22ad11635
b1d8851 test(forms): update the Signal Forms bundle symbol golden nagahara-naoki Nov 21, 2026 https://github.com/angular/angular/pull/72097/commits/b1d8851d0a0e3df35b3926471d549b97cbd7fab6
Clear filters https://github.com/angular/angular/pull/72097/files
Please reload this pagehttps://github.com/angular/angular/pull/72097/files
Please reload this pagehttps://github.com/angular/angular/pull/72097/files
bundle.golden_symbols.json https://github.com/angular/angular/pull/72097/files#diff-d8cb5b3a9e24e07ac13394c3d9e93be18467c339cbaaa5f31f3bf40241a62f2f
control_custom.ts https://github.com/angular/angular/pull/72097/files#diff-16db95145806ed1157c12394698590cfa75b869f556aa3736c4be9d16e1bbf55
form_field.spec.ts https://github.com/angular/angular/pull/72097/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
packages/core/test/bundling/forms_signals/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/72097/files#diff-d8cb5b3a9e24e07ac13394c3d9e93be18467c339cbaaa5f31f3bf40241a62f2f
View file https://github.com/angular/angular/blob/b1d8851d0a0e3df35b3926471d549b97cbd7fab6/packages/core/test/bundling/forms_signals/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72097/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72097/files#diff-d8cb5b3a9e24e07ac13394c3d9e93be18467c339cbaaa5f31f3bf40241a62f2f
https://github.com/angular/angular/pull/72097/files#diff-d8cb5b3a9e24e07ac13394c3d9e93be18467c339cbaaa5f31f3bf40241a62f2f
packages/forms/signals/src/directive/control_custom.tshttps://github.com/angular/angular/pull/72097/files#diff-16db95145806ed1157c12394698590cfa75b869f556aa3736c4be9d16e1bbf55
View file https://github.com/angular/angular/blob/b1d8851d0a0e3df35b3926471d549b97cbd7fab6/packages/forms/signals/src/directive/control_custom.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72097/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72097/files#diff-16db95145806ed1157c12394698590cfa75b869f556aa3736c4be9d16e1bbf55
https://github.com/angular/angular/pull/72097/files#diff-16db95145806ed1157c12394698590cfa75b869f556aa3736c4be9d16e1bbf55
packages/forms/signals/test/web/form_field.spec.tshttps://github.com/angular/angular/pull/72097/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
View file https://github.com/angular/angular/blob/b1d8851d0a0e3df35b3926471d549b97cbd7fab6/packages/forms/signals/test/web/form_field.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72097/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72097/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
https://github.com/angular/angular/pull/72097/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
https://github.com/angular/angular/pull/72097/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
https://github.com/angular/angular/pull/72097/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
https://github.com/angular/angular/pull/72097/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
https://github.com/angular/angular/pull/72097/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
https://github.com/angular/angular/pull/72097/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
https://github.com/angular/angular/pull/72097/files#diff-468e82c89a74befc0e19a4094224fb552314f058ee986f2a8a20924ef6e9478d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.