René's URL Explorer Experiment


Title: fix(common): include binary request bodies in the HTTP transfer cache key by mojerf · Pull Request #72025 · angular/angular · GitHub

Open Graph Title: fix(common): include binary request bodies in the HTTP transfer cache key by mojerf · Pull Request #72025 · angular/angular

X Title: fix(common): include binary request bodies in the HTTP transfer cache key by mojerf · Pull Request #72025 · angular/angular

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) — not needed, no public API change PR Type Bugfix What is the current behavior? makeCacheKey in the HTTP transfer cache only adds string and URLSearchParams bodies to the cache key. For every other body type (ArrayBuffer, Blob, FormData) it uses an empty string. Since HttpClient.query() made QUERY requests cacheable by default, two QUERY requests to the same URL with different ArrayBuffer bodies share a cache key. On the server the second request is answered from the cache of the first one without hitting the network, and the wrong response ends up in TransferState. The same happens for POST requests that opt in with transferCache: true. Reproduction (server mode, HttpTestingController): http.query('/api/search', bodyA) followed by http.query('/api/search', bodyB) returns the response of bodyA for both, with a single TransferState entry. Fixes #72026 What is the new behavior? ArrayBuffer bodies are included in the cache key (base64 of the bytes). FormData bodies with only string entries are included in the cache key (ordered entries). Bodies whose contents can only be read asynchronously (Blob, FormData containing files) cannot be keyed, so those requests are no longer cached, instead of colliding on one key. String, JSON and URLSearchParams bodies behave as before. The prefixes used for the binary kinds contain \0 so that a string body cannot produce the same key as a binary body with equivalent content. Does this PR introduce a breaking change? Yes No Requests with a Blob body or a FormData body containing files, which were previously cached under a shared key, are no longer cached. Their cached responses were not reliable, since different bodies received the same response. Other information Testing note: I could not run Bazel on my machine (Windows). I ran the updated transfer_cache_spec.ts through a local vitest/jsdom harness against the changed sources: the 7 added tests pass (5 of them fail without the change), and the remaining failures are the same 12 that fail before the change because they rely on Jasmine-only APIs in that harness. Please let CI be the source of truth. Open question for reviewers: for very large ArrayBuffer bodies the whole content is base64-encoded and hashed. If that is a concern, a size cap (skip caching above it) or hashing the bytes directly would be easy follow-ups. 🤖 Generated with Claude Code

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...

Opengraph URL: https://github.com/angular/angular/pull/72025

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ad9313b9-6155-a2dd-977c-5f23d22477bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F48:2BE220:2F4F2C5:3F2437F:6B01E30F
html-safe-nonce167b79d7f36e9440129fcc0be664c0ee0bb922b26134a2228f6a2d7b28657597
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjQ4OjJCRTIyMDoyRjRGMkM1OjNGMjQzN0Y6NkIwMUUzMEYiLCJ2aXNpdG9yX2lkIjoiNzA3NDEzODg2MDQ2OTU0MjU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9360a0de0fe4ec5eca817cf18672976fcf140428426529fe7d4acff88d2338f3
hovercard-subject-tagpull_request:5294608285
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/72025/files
twitter:imagehttps://avatars.githubusercontent.com/u/17108312?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17108312?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/72025/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72025%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F72025%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/72025/files
Reloadhttps://github.com/angular/angular/pull/72025/files
Reloadhttps://github.com/angular/angular/pull/72025/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
mojerfhttps://github.com/mojerf
angular:mainhttps://github.com/angular/angular/tree/main
mojerf:fix/http-transfer-cache-binary-bodyhttps://github.com/mojerf/angular/tree/fix/http-transfer-cache-binary-body
Conversation 2 https://github.com/angular/angular/pull/72025
Commits 1 https://github.com/angular/angular/pull/72025/commits
Checks 19 https://github.com/angular/angular/pull/72025/checks
Files changed https://github.com/angular/angular/pull/72025/files
Please reload this pagehttps://github.com/angular/angular/pull/72025/files
fix(common): include binary request bodies in the HTTP transfer cache key https://github.com/angular/angular/pull/72025/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/72025/files
a71462a fix(common): include binary request bodies in the HTTP transfer cache… mojerf Nov 13, 2026 https://github.com/angular/angular/pull/72025/commits/a71462a72ae87eadd93048ebe8ba4f77c24e4451
Clear filters https://github.com/angular/angular/pull/72025/files
Please reload this pagehttps://github.com/angular/angular/pull/72025/files
Please reload this pagehttps://github.com/angular/angular/pull/72025/files
transfer_cache.ts https://github.com/angular/angular/pull/72025/files#diff-03aa4a8a91d930dafe004606ae8a0af6b03d21ad07ceea745acdd23c0bab5cb7
transfer_cache_spec.ts https://github.com/angular/angular/pull/72025/files#diff-6c46b92d3a9e56c461357c72b4a46874d187f264c9d61882d5235c35ec3a0705
packages/common/http/src/transfer_cache.tshttps://github.com/angular/angular/pull/72025/files#diff-03aa4a8a91d930dafe004606ae8a0af6b03d21ad07ceea745acdd23c0bab5cb7
View file https://github.com/mojerf/angular/blob/a71462a72ae87eadd93048ebe8ba4f77c24e4451/packages/common/http/src/transfer_cache.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72025/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72025/files#diff-03aa4a8a91d930dafe004606ae8a0af6b03d21ad07ceea745acdd23c0bab5cb7
https://github.com/angular/angular/pull/72025/files#diff-03aa4a8a91d930dafe004606ae8a0af6b03d21ad07ceea745acdd23c0bab5cb7
https://github.com/angular/angular/pull/72025/files#diff-03aa4a8a91d930dafe004606ae8a0af6b03d21ad07ceea745acdd23c0bab5cb7
https://github.com/angular/angular/pull/72025/files#diff-03aa4a8a91d930dafe004606ae8a0af6b03d21ad07ceea745acdd23c0bab5cb7
https://github.com/angular/angular/pull/72025/files#diff-03aa4a8a91d930dafe004606ae8a0af6b03d21ad07ceea745acdd23c0bab5cb7
https://github.com/angular/angular/pull/72025/files#diff-03aa4a8a91d930dafe004606ae8a0af6b03d21ad07ceea745acdd23c0bab5cb7
packages/common/http/test/transfer_cache_spec.tshttps://github.com/angular/angular/pull/72025/files#diff-6c46b92d3a9e56c461357c72b4a46874d187f264c9d61882d5235c35ec3a0705
View file https://github.com/mojerf/angular/blob/a71462a72ae87eadd93048ebe8ba4f77c24e4451/packages/common/http/test/transfer_cache_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/72025/{{ revealButtonHref }}
https://github.com/angular/angular/pull/72025/files#diff-6c46b92d3a9e56c461357c72b4a46874d187f264c9d61882d5235c35ec3a0705
https://github.com/angular/angular/pull/72025/files#diff-6c46b92d3a9e56c461357c72b4a46874d187f264c9d61882d5235c35ec3a0705
Please reload this pagehttps://github.com/angular/angular/pull/72025/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.