Title: fix(common): include binary request bodies in the HTTP transfer cache key by mojerf · Pull Request #72025 · angular/angular · GitHub
Open Graph Title: fix(common): include binary request bodies in the HTTP transfer cache key by mojerf · Pull Request #72025 · angular/angular
X Title: fix(common): include binary request bodies in the HTTP transfer cache key by mojerf · Pull Request #72025 · angular/angular
Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) — not needed, no public API change PR Type Bugfix What is the current behavior? makeCacheKey in the HTTP transfer cache only adds string and URLSearchParams bodies to the cache key. For every other body type (ArrayBuffer, Blob, FormData) it uses an empty string. Since HttpClient.query() made QUERY requests cacheable by default, two QUERY requests to the same URL with different ArrayBuffer bodies share a cache key. On the server the second request is answered from the cache of the first one without hitting the network, and the wrong response ends up in TransferState. The same happens for POST requests that opt in with transferCache: true. Reproduction (server mode, HttpTestingController): http.query('/api/search', bodyA) followed by http.query('/api/search', bodyB) returns the response of bodyA for both, with a single TransferState entry. Fixes #72026 What is the new behavior? ArrayBuffer bodies are included in the cache key (base64 of the bytes). FormData bodies with only string entries are included in the cache key (ordered entries). Bodies whose contents can only be read asynchronously (Blob, FormData containing files) cannot be keyed, so those requests are no longer cached, instead of colliding on one key. String, JSON and URLSearchParams bodies behave as before. The prefixes used for the binary kinds contain \0 so that a string body cannot produce the same key as a binary body with equivalent content. Does this PR introduce a breaking change? Yes No Requests with a Blob body or a FormData body containing files, which were previously cached under a shared key, are no longer cached. Their cached responses were not reliable, since different bodies received the same response. Other information Testing note: I could not run Bazel on my machine (Windows). I ran the updated transfer_cache_spec.ts through a local vitest/jsdom harness against the changed sources: the 7 added tests pass (5 of them fail without the change), and the remaining failures are the same 12 that fail before the change because they rely on Jasmine-only APIs in that harness. Please let CI be the source of truth. Open question for reviewers: for very large ArrayBuffer bodies the whole content is base64-encoded and hashed. If that is a concern, a size cap (skip caching above it) or hashing the bytes directly would be easy follow-ups. 🤖 Generated with Claude Code
Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...
X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...
Opengraph URL: https://github.com/angular/angular/pull/72025
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ad9313b9-6155-a2dd-977c-5f23d22477bc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F48:2BE220:2F4F2C5:3F2437F:6B01E30F |
| html-safe-nonce | 167b79d7f36e9440129fcc0be664c0ee0bb922b26134a2228f6a2d7b28657597 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjQ4OjJCRTIyMDoyRjRGMkM1OjNGMjQzN0Y6NkIwMUUzMEYiLCJ2aXNpdG9yX2lkIjoiNzA3NDEzODg2MDQ2OTU0MjU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9360a0de0fe4ec5eca817cf18672976fcf140428426529fe7d4acff88d2338f3 |
| hovercard-subject-tag | pull_request:5294608285 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/72025/files |
| twitter:image | https://avatars.githubusercontent.com/u/17108312?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/17108312?s=400&v=4 |
| og:image:alt | PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width