René's URL Explorer Experiment


Title: fix(common): restore natural order when KeyValuePipe compareFn changes to null by MeAkib · Pull Request #71894 · angular/angular · GitHub

Open Graph Title: fix(common): restore natural order when KeyValuePipe compareFn changes to null by MeAkib · Pull Request #71894 · angular/angular

X Title: fix(common): restore natural order when KeyValuePipe compareFn changes to null by MeAkib · Pull Request #71894 · angular/angular

Description: KeyValuePipe sorted its output in place, so when compareFn switched from a function to null without the input changing, the original order was lost and the previously sorted array was returned. When only compareFn changes, rebuild the entries from the input in natural order before applying the new comparator. Tested with new specs for objects and Maps that fail without the fix. Fixes #71893

Open Graph Description: KeyValuePipe sorted its output in place, so when compareFn switched from a function to null without the input changing, the original order was lost and the previously sorted array was returned. Whe...

X Description: KeyValuePipe sorted its output in place, so when compareFn switched from a function to null without the input changing, the original order was lost and the previously sorted array was returned. Whe...

Opengraph URL: https://github.com/angular/angular/pull/71894

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:baef51c4-d748-7e0b-dab8-ef7ad0e93fd0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD04C:154D88:2A326C7:35FAE17:6B01E9EC
html-safe-noncea7b061805d676dff7bcb725ee206b9924411f622b678e5916b84d9f4808eaaa5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDRDOjE1NEQ4ODoyQTMyNkM3OjM1RkFFMTc6NkIwMUU5RUMiLCJ2aXNpdG9yX2lkIjoiNTQ4MjE4NTU3NjU0OTU3NTE0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac076562d3dbd6f84e6169c112c4b11d62b864cc0fd4174b6fdf20e543b9c413cb
hovercard-subject-tagpull_request:5229447879
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/71894/files
twitter:imagehttps://avatars.githubusercontent.com/u/48770016?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/48770016?s=400&v=4
og:image:altKeyValuePipe sorted its output in place, so when compareFn switched from a function to null without the input changing, the original order was lost and the previously sorted array was returned. Whe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/71894/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71894%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71894%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/71894/files
Reloadhttps://github.com/angular/angular/pull/71894/files
Reloadhttps://github.com/angular/angular/pull/71894/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
thePunderWomanhttps://github.com/thePunderWoman
angular:mainhttps://github.com/angular/angular/tree/main
MeAkib:common/keyvalue-null-compare-fnhttps://github.com/MeAkib/angular/tree/common/keyvalue-null-compare-fn
Conversation 5 https://github.com/angular/angular/pull/71894
Commits 1 https://github.com/angular/angular/pull/71894/commits
Checks 23 https://github.com/angular/angular/pull/71894/checks
Files changed https://github.com/angular/angular/pull/71894/files
Please reload this pagehttps://github.com/angular/angular/pull/71894/files
fix(common): restore natural order when KeyValuePipe compareFn changes to null https://github.com/angular/angular/pull/71894/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/71894/files
b041c68 fix(common): restore natural order when KeyValuePipe compareFn change… MeAkib Nov 9, 2026 https://github.com/angular/angular/pull/71894/commits/b041c687c0a3e1436751f3b0f964da41b5402b2f
Clear filters https://github.com/angular/angular/pull/71894/files
Please reload this pagehttps://github.com/angular/angular/pull/71894/files
Please reload this pagehttps://github.com/angular/angular/pull/71894/files
keyvalue_pipe.ts https://github.com/angular/angular/pull/71894/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
keyvalue_pipe_spec.ts https://github.com/angular/angular/pull/71894/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
packages/common/src/pipes/keyvalue_pipe.tshttps://github.com/angular/angular/pull/71894/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
View file https://github.com/MeAkib/angular/blob/b041c687c0a3e1436751f3b0f964da41b5402b2f/packages/common/src/pipes/keyvalue_pipe.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71894/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71894/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
https://github.com/angular/angular/pull/71894/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
packages/common/test/pipes/keyvalue_pipe_spec.tshttps://github.com/angular/angular/pull/71894/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
View file https://github.com/MeAkib/angular/blob/b041c687c0a3e1436751f3b0f964da41b5402b2f/packages/common/test/pipes/keyvalue_pipe_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71894/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71894/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com/angular/angular/pull/71894/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com/angular/angular/pull/71894/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com/angular/angular/pull/71894/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
Please reload this pagehttps://github.com/angular/angular/pull/71894/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.