René's URL Explorer Experiment


Title: perf(common): avoid re-setting unchanged attributes in NgOptimizedImage by jsaguet · Pull Request #71875 · angular/angular · GitHub

Open Graph Title: perf(common): avoid re-setting unchanged attributes in NgOptimizedImage by jsaguet · Pull Request #71875 · angular/angular

X Title: perf(common): avoid re-setting unchanged attributes in NgOptimizedImage by jsaguet · Pull Request #71875 · angular/angular

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: performance What is the current behavior? Part of #71873 During hydration, NgOptimizedImage writes all of its host attributes again, with the values that the server rendered. The browser selects the image source again after a write to src, srcset, or sizes, even when the value doesn't change. What is the new behavior? private setHostAttribute(name: string, value: string): void { - this.renderer.setAttribute(this.imgElement, name, value); + if (this.placeholder || this.imgElement.getAttribute(name) !== value) { + this.renderer.setAttribute(this.imgElement, name, value); + } } An image that still has a placeholder keeps today's writes. An image that failed before hydration then fires error again, which removes the placeholder. An image that already loaded clears its placeholder before the writes, so it skips them. Does this PR introduce a breaking change? Yes No The public API doesn't change. The visible differences are repeated events that were a side effect of the rewrite, described under Risks. Other information Evidence On a page with 200 images, hydration takes 28.1 ms instead of 34.8 ms. With 4× CPU throttling, it takes 198.6 ms instead of 247.9 ms. With bound [width], [height], and [sizes], it takes 9.6 ms instead of 23.4 ms. results/timings.txt in the reproduction has the measurements. The benchmark pages have no placeholders, so the this.placeholder condition doesn't affect them. The extra reads also run during client-side rendering. They add 96–164 ns per image in Chrome 157, which is 19–33 µs for 200 images, compared with about 175 µs per image for hydration on the page above. So they aren't limited to hydration. Microbenchmark Each sample runs the 8 writes of setHostAttribute() on 50,000 new images, in an inert document so that the images aren't fetched. The median of 31 samples, in 3 runs: Case Without the check With the check Difference Static width and height, already written by core 696–732 ns 828–840 ns 96–144 ns Bound [width] and [height] 652–664 ns 798–828 ns 146–164 ns

running
Specs in full_app_hydration_spec.ts: Attributes rendered on the server aren't written again. This spec fails without the check. An image with a placeholder is written again. This spec fails without the this.placeholder condition. A value that differs from the server is still written. A spec in event_replay_spec.ts checks that a load event that fired before hydration is replayed, under domino, which doesn't load images. It passes with and without this change. No spec covers the placeholder image that already loaded, because setting complete and naturalWidth under domino also runs the dev-mode distortion check, which needs layout. Test targets for common and platform-server pass, including the Chromium and Firefox suites for common. I couldn't run image-directive:webdriver_tests in my environment. That target fails the same way without this change. Risks It affects apps that use NgOptimizedImage. When nothing else writes the attributes of an image that loaded before hydration, load no longer fires a second time. That's the case for an image with no static sizes attribute (measured in Chrome). A (load) handler on that image then runs once, through event replay, which is on by default. Without event replay, it doesn't run. Listeners added imperatively, such as fromEvent or renderer.listen, aren't covered by event replay and no longer receive that second event. An image without a placeholder that failed before hydration no longer fires error a second time, and the browser doesn't try to load it again during hydration. (error) handlers use the same event replay path as (load), but no spec covers it. This change doesn't address the sizes value that changes twice on lazy images. #71873 describes that case.

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...

Opengraph URL: https://github.com/angular/angular/pull/71875

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6f67f2d5-2792-933f-7473-c9d38b7d8ddb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF84:EAD6D:143B67B:195918C:6B026231
html-safe-nonce4dae89a536ba8725b03577b62f23db42e4e636db7c30b107ee9b6095adf21533
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjg0OkVBRDZEOjE0M0I2N0I6MTk1OTE4Qzo2QjAyNjIzMSIsInZpc2l0b3JfaWQiOiI2NTY5NTcxNTM2NjkxNDIxNzQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2c538121f78200119e7e82f7fc5e2edb377ab57b9426e58e601a6ae82342a4c9
hovercard-subject-tagpull_request:5211309400
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/71875/files
twitter:imagehttps://avatars.githubusercontent.com/u/49377434?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/49377434?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/71875/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71875%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71875%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/71875/files
Reloadhttps://github.com/angular/angular/pull/71875/files
Reloadhttps://github.com/angular/angular/pull/71875/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
jsaguethttps://github.com/jsaguet
angular:mainhttps://github.com/angular/angular/tree/main
jsaguet:perf/ng-optimized-image-skip-unchanged-attrshttps://github.com/jsaguet/angular/tree/perf/ng-optimized-image-skip-unchanged-attrs
Conversation 5 https://github.com/angular/angular/pull/71875
Commits 1 https://github.com/angular/angular/pull/71875/commits
Checks 1 https://github.com/angular/angular/pull/71875/checks
Files changed https://github.com/angular/angular/pull/71875/files
Please reload this pagehttps://github.com/angular/angular/pull/71875/files
perf(common): avoid re-setting unchanged attributes in NgOptimizedImage https://github.com/angular/angular/pull/71875/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/71875/files
5cce7a2 perf(common): avoid re-setting unchanged attributes in NgOptimizedImage jsaguet Nov 8, 2026 https://github.com/angular/angular/pull/71875/commits/5cce7a2eede73c24e8056288b235a46ae3d2398c
Clear filters https://github.com/angular/angular/pull/71875/files
Please reload this pagehttps://github.com/angular/angular/pull/71875/files
Please reload this pagehttps://github.com/angular/angular/pull/71875/files
ng_optimized_image.ts https://github.com/angular/angular/pull/71875/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
event_replay_spec.ts https://github.com/angular/angular/pull/71875/files#diff-d34f99dab1fc59eb6ff86da8110105f494bffdee4ca5cc6299b2936d406ec71c
full_app_hydration_spec.ts https://github.com/angular/angular/pull/71875/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
packages/common/src/directives/ng_optimized_image/ng_optimized_image.tshttps://github.com/angular/angular/pull/71875/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
View file https://github.com/angular/angular/blob/5cce7a2eede73c24e8056288b235a46ae3d2398c/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71875/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71875/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/71875/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
packages/platform-server/test/event_replay_spec.tshttps://github.com/angular/angular/pull/71875/files#diff-d34f99dab1fc59eb6ff86da8110105f494bffdee4ca5cc6299b2936d406ec71c
View file https://github.com/angular/angular/blob/5cce7a2eede73c24e8056288b235a46ae3d2398c/packages/platform-server/test/event_replay_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71875/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71875/files#diff-d34f99dab1fc59eb6ff86da8110105f494bffdee4ca5cc6299b2936d406ec71c
https://github.com/angular/angular/pull/71875/files#diff-d34f99dab1fc59eb6ff86da8110105f494bffdee4ca5cc6299b2936d406ec71c
https://github.com/angular/angular/pull/71875/files#diff-d34f99dab1fc59eb6ff86da8110105f494bffdee4ca5cc6299b2936d406ec71c
https://github.com/angular/angular/pull/71875/files#diff-d34f99dab1fc59eb6ff86da8110105f494bffdee4ca5cc6299b2936d406ec71c
packages/platform-server/test/full_app_hydration_spec.tshttps://github.com/angular/angular/pull/71875/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
View file https://github.com/angular/angular/blob/5cce7a2eede73c24e8056288b235a46ae3d2398c/packages/platform-server/test/full_app_hydration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71875/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71875/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
https://github.com/angular/angular/pull/71875/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
https://github.com/angular/angular/pull/71875/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
https://github.com/angular/angular/pull/71875/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
https://github.com/angular/angular/pull/71875/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
https://github.com/angular/angular/pull/71875/files#diff-212384b7cadd1f6fd5c408cc3ae1a4fedd901b8210cfc7172e77d7fa0104c250
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.