René's URL Explorer Experiment


Title: fix(core): don't reload iframes and media during hydration by jsaguet · Pull Request #71874 · angular/angular · GitHub

Open Graph Title: fix(core): don't reload iframes and media during hydration by jsaguet · Pull Request #71874 · angular/angular

X Title: fix(core): don't reload iframes and media during hydration by jsaguet · Pull Request #71874 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...

Opengraph URL: https://github.com/angular/angular/pull/71874

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:46ffb6a0-2dde-9a37-f646-f4d6fcdeb173
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCFE:2454CC:3306660:40C4B55:6B01D8CF
html-safe-nonce5950c23a4ef2bc88b4afac5faf1972e55ece37f62052aa436dfdfbd9d3b1b62f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0ZFOjI0NTRDQzozMzA2NjYwOjQwQzRCNTU6NkIwMUQ4Q0YiLCJ2aXNpdG9yX2lkIjoiNDcxMjkwODk5MzQxMTAxMjgxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac86cd611d94ed11396cf8edec95464fab69f2a9cffa16c214844c15da5bd3f171
hovercard-subject-tagpull_request:5211309126
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/71874
twitter:imagehttps://opengraph.githubassets.com/7ec080e67bc79504914d2f62be27fdc87c2b4c7f3ef85a7f41d57791d1847039/angular/angular/pull/71874
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7ec080e67bc79504914d2f62be27fdc87c2b4c7f3ef85a7f41d57791d1847039/angular/angular/pull/71874
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejsaguet
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/71874#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71874
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71874
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/71874
Reloadhttps://github.com/angular/angular/pull/71874
Reloadhttps://github.com/angular/angular/pull/71874
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
jsaguethttps://github.com/jsaguet
angular:mainhttps://github.com/angular/angular/tree/main
jsaguet:fix/hydration-skip-unchanged-dom-writeshttps://github.com/jsaguet/angular/tree/fix/hydration-skip-unchanged-dom-writes
Conversationhttps://github.com/angular/angular/pull/71874
Commits1 (1)https://github.com/angular/angular/pull/71874/commits
Checkshttps://github.com/angular/angular/pull/71874/checks
Files changedhttps://github.com/angular/angular/pull/71874/files
fix(core): don't reload iframes and media during hydrationhttps://github.com/angular/angular/pull/71874#top
jsaguethttps://github.com/jsaguet
angular:mainhttps://github.com/angular/angular/tree/main
jsaguet:fix/hydration-skip-unchanged-dom-writeshttps://github.com/jsaguet/angular/tree/fix/hydration-skip-unchanged-dom-writes
https://github.com/jsaguet
jsaguethttps://github.com/jsaguet
Nov 8, 2026https://github.com/angular/angular/pull/71874#issue-6270918236
Please reload this pagehttps://github.com/angular/angular/pull/71874
https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.mdhttps://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md
#52477https://github.com/angular/angular/issues/52477
#71971https://github.com/angular/angular/issues/71971
reproductionhttps://github.com/jsaguet/ngimg-hydration-repro
Please reload this pagehttps://github.com/angular/angular/pull/71874
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
Nov 8, 2026https://github.com/angular/angular/pull/71874#event-35491692155
https://github.com/apps/google-cla
google-clahttps://github.com/apps/google-cla
Nov 8, 2026https://github.com/angular/angular/pull/71874#issuecomment-6721504696
failed invocationhttps://github.com/angular/angular/pull/71874/checks?check_run_id=128731223160
Please reload this pagehttps://github.com/angular/angular/pull/71874
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Nov 8, 2026https://github.com/angular/angular/pull/71874#event-35491694553
https://github.com/jsaguet
jsaguethttps://github.com/jsaguet
force-pushedhttps://github.com/angular/angular/compare/22b9b304364692921dcb727e91553e930c303e54..53ce2a0cbb25ef6e2506ad37c694fa1a86de8664
22b9b30https://github.com/angular/angular/commit/22b9b304364692921dcb727e91553e930c303e54
53ce2a0https://github.com/angular/angular/commit/53ce2a0cbb25ef6e2506ad37c694fa1a86de8664
Compare https://github.com/angular/angular/compare/22b9b304364692921dcb727e91553e930c303e54..53ce2a0cbb25ef6e2506ad37c694fa1a86de8664
November 8, 2026 12:39https://github.com/angular/angular/pull/71874#event-35492036300
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Nov 8, 2026 https://github.com/angular/angular/pull/71874#pullrequestreview-5818340428
View reviewed changes https://github.com/angular/angular/pull/71874/files
JeanMechehttps://github.com/JeanMeche
https://github.com/angular/angular/pull/71874#pullrequestreview-5818340428
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#71872https://github.com/angular/angular/issues/71872
#71873https://github.com/angular/angular/issues/71873
Please reload this pagehttps://github.com/angular/angular/pull/71874
packages/core/src/render3/dom_node_manipulation.tshttps://github.com/angular/angular/pull/71874/files#diff-60445e5f9bd12006463352692bcda35928be34bb3ecee4a20c7320ac8b6cb7ee
JeanMechehttps://github.com/JeanMeche
Nov 8, 2026https://github.com/angular/angular/pull/71874#discussion_r4506631636
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
NgOptimizedImage makes the browser select each image source again during hydration #71873https://github.com/angular/angular/issues/71873
Please reload this pagehttps://github.com/angular/angular/pull/71874
jsaguethttps://github.com/jsaguet
Nov 8, 2026https://github.com/angular/angular/pull/71874#discussion_r4507103382
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#71200https://github.com/angular/angular/pull/71200
#71873https://github.com/angular/angular/issues/71873
Please reload this pagehttps://github.com/angular/angular/pull/71874
JeanMechehttps://github.com/JeanMeche
Nov 8, 2026https://github.com/angular/angular/pull/71874#discussion_r4507463421
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#71200https://github.com/angular/angular/pull/71200
#71873https://github.com/angular/angular/issues/71873
#71872https://github.com/angular/angular/issues/71872
fix(core): don't reload iframes and media during hydration #71874https://github.com/angular/angular/pull/71874
perf(common): avoid re-setting unchanged attributes in NgOptimizedImage #71875https://github.com/angular/angular/pull/71875
Please reload this pagehttps://github.com/angular/angular/pull/71874
jsaguethttps://github.com/jsaguet
Nov 11, 2026https://github.com/angular/angular/pull/71874#discussion_r4542644253
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#71971https://github.com/angular/angular/issues/71971
Please reload this pagehttps://github.com/angular/angular/pull/71874
packages/core/src/render3/instructions/shared.tshttps://github.com/angular/angular/pull/71874/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
JeanMechehttps://github.com/JeanMeche
Nov 8, 2026https://github.com/angular/angular/pull/71874#discussion_r4506631640
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/71874
jsaguethttps://github.com/jsaguet
Nov 8, 2026https://github.com/angular/angular/pull/71874#discussion_r4507103496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/71874
packages/platform-server/test/hydration_dom_writes_spec.tshttps://github.com/angular/angular/pull/71874/files#diff-e354b9eb7654e00b3c98d167134161d0ad518a67ad5a526740a44be34b27e556
JeanMechehttps://github.com/JeanMeche
Nov 8, 2026https://github.com/angular/angular/pull/71874#discussion_r4506631643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/71874
jsaguethttps://github.com/jsaguet
Nov 8, 2026https://github.com/angular/angular/pull/71874#discussion_r4507103599
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/71874
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Nov 8, 2026 https://github.com/angular/angular/pull/71874#ref-pullrequest-6270918568
perf(common): avoid re-setting unchanged attributes in NgOptimizedImage #71875 https://github.com/angular/angular/pull/71875
https://github.com/jsaguet
jsaguethttps://github.com/jsaguet
force-pushedhttps://github.com/angular/angular/compare/53ce2a0cbb25ef6e2506ad37c694fa1a86de8664..9a480b2c897536357c9f81cb2348bbdff73b0a68
53ce2a0https://github.com/angular/angular/commit/53ce2a0cbb25ef6e2506ad37c694fa1a86de8664
9a480b2https://github.com/angular/angular/commit/9a480b2c897536357c9f81cb2348bbdff73b0a68
Compare https://github.com/angular/angular/compare/53ce2a0cbb25ef6e2506ad37c694fa1a86de8664..9a480b2c897536357c9f81cb2348bbdff73b0a68
November 8, 2026 17:28https://github.com/angular/angular/pull/71874#event-35504109405
https://github.com/jsaguet
jsaguethttps://github.com/jsaguet
Nov 8, 2026 https://github.com/angular/angular/pull/71874#ref-issue-1971419291
Static attributes are not hydrated, causing refetching of external resources #52477 https://github.com/angular/angular/issues/52477
https://github.com/jsaguet
fix(core): don't reload iframes and media during hydrationhttps://github.com/angular/angular/pull/71874/commits/a5a00a33d2efed97701bc317911d591b5f0a30f7
a5a00a3https://github.com/angular/angular/pull/71874/commits/a5a00a33d2efed97701bc317911d591b5f0a30f7
angular#52477https://github.com/angular/angular/issues/52477
https://github.com/jsaguet
jsaguethttps://github.com/jsaguet
Nov 11, 2026 https://github.com/angular/angular/pull/71874#ref-issue-6336173530
Hydration writes every static attribute and binding again, even when the server rendered the same value #71971 https://github.com/angular/angular/issues/71971
https://github.com/jsaguet
jsaguethttps://github.com/jsaguet
force-pushedhttps://github.com/angular/angular/compare/9a480b2c897536357c9f81cb2348bbdff73b0a68..a5a00a33d2efed97701bc317911d591b5f0a30f7
9a480b2https://github.com/angular/angular/commit/9a480b2c897536357c9f81cb2348bbdff73b0a68
a5a00a3https://github.com/angular/angular/commit/a5a00a33d2efed97701bc317911d591b5f0a30f7
Compare https://github.com/angular/angular/compare/9a480b2c897536357c9f81cb2348bbdff73b0a68..a5a00a33d2efed97701bc317911d591b5f0a30f7
November 11, 2026 19:57https://github.com/angular/angular/pull/71874#event-35838513494
https://github.com/jsaguet
jsaguethttps://github.com/jsaguet
Nov 11, 2026https://github.com/angular/angular/pull/71874#event-35838514408
https://github.com/jsaguet
jsaguethttps://github.com/jsaguet
November 11, 2026 19:57https://github.com/angular/angular/pull/71874#event-35838519566
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71874
https://github.com/JeanMeche
JeanMeche https://github.com/JeanMeche
https://github.com/angular/angular/pull/71874/files/9a480b2c897536357c9f81cb2348bbdff73b0a68
Please reload this pagehttps://github.com/angular/angular/pull/71874
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
Backlog https://github.com/angular/angular/milestone/82
Static attributes are not hydrated, causing refetching of external resources https://github.com/angular/angular/issues/52477
Please reload this pagehttps://github.com/angular/angular/pull/71874
https://github.com/jsaguet
https://github.com/JeanMeche
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.