René's URL Explorer Experiment


Title: fix(compiler-cli): preserve pure annotations on ngp static fields through tsc by JeanMeche · Pull Request #71417 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): preserve pure annotations on ngp static fields through tsc by JeanMeche · Pull Request #71417 · angular/angular

X Title: fix(compiler-cli): preserve pure annotations on ngp static fields through tsc by JeanMeche · Pull Request #71417 · angular/angular

Description: Summary Place /*@__PURE__*/ on a new line after = in createStaticField (matching the existing placement used for /** @pureOrBreakMyCode */), preceded by its own // @ts-ignore line. When /*@__PURE__*/ sits on the same line after =, TypeScript attaches it as a trailing comment of the = token rather than a leading comment of the initializer. Downstream tsc drops trailing comments of = both when erasing static field type annotations (ES2022) and when downleveling static fields to Class.ɵcmp = ... (ES2015/ES5), which previously broke bundler tree-shaking of unused Angular classes. Remove the /*@__PURE__*/-reinserting regexes in ngp_emit_normalizer.ts and STATIC_MEMBER_TYPE_ANNOTATION_REGEX in compliance_spec.ts that masked the stripped annotation. This was detected when working on #71343. Test Plan Added unit tests in emit_suppressions_spec.ts verifying /*@__PURE__*/ survives ts.transpileModule at both ES2022 and ES2015. Updated preprocessor goldens (//packages/compiler-cli/preprocessor/test:test). Ran //packages/compiler-cli/preprocessor/test:test, //packages/compiler-cli/preprocessor/test:typecheck_goldens_test, //packages/compiler-cli/test/compliance/full:full_ngp, //packages/compiler-cli/test/compliance/local:local_ngp, //packages/compiler-cli/test/compliance/declaration-only:declaration-only_ngp, and //packages/compiler-cli/test/ngtsc:ngtsc_ngp.

Open Graph Description: Summary Place /*@__PURE__*/ on a new line after = in createStaticField (matching the existing placement used for /** @pureOrBreakMyCode */), preceded by its own // @ts-ignore line. When /*@__PURE_...

X Description: Summary Place /*@__PURE__*/ on a new line after = in createStaticField (matching the existing placement used for /** @pureOrBreakMyCode */), preceded by its own // @ts-ignore line. When /*@__PURE_...

Opengraph URL: https://github.com/angular/angular/pull/71417

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8fee622c-e5f4-345c-430a-f86772c2b8e7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC114:16AB79:1A7BCB0:21A9EC7:6B014E01
html-safe-nonce061f640a00a6fe57423a32b99d2bc4e00898a2accf7ff5778e81b2c7c54e15aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTE0OjE2QUI3OToxQTdCQ0IwOjIxQTlFQzc6NkIwMTRFMDEiLCJ2aXNpdG9yX2lkIjoiODU0OTcxNDIzMDgxNzkzNDg0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4c30248af5660e12ec3767d98b5cfd31cc5951973c201c44c4dbb72f0362de6c
hovercard-subject-tagpull_request:4910625796
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/71417/files
twitter:imagehttps://avatars.githubusercontent.com/u/1300985?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1300985?s=400&v=4
og:image:altSummary Place /*@__PURE__*/ on a new line after = in createStaticField (matching the existing placement used for /** @pureOrBreakMyCode */), preceded by its own // @ts-ignore line. When /*@__PURE_...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/71417/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71417%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71417%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/71417/files
Reloadhttps://github.com/angular/angular/pull/71417/files
Reloadhttps://github.com/angular/angular/pull/71417/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
JeanMeche:fix/ngp-preserve-pure-annotationshttps://github.com/JeanMeche/angular/tree/fix/ngp-preserve-pure-annotations
Conversation 2 https://github.com/angular/angular/pull/71417
Commits 1 https://github.com/angular/angular/pull/71417/commits
Checks 24 https://github.com/angular/angular/pull/71417/checks
Files changed 470 https://github.com/angular/angular/pull/71417/files
fix(compiler-cli): preserve pure annotations on ngp static fields through tsc https://github.com/angular/angular/pull/71417/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/71417/files
2f71f19 fix(compiler-cli): preserve pure annotations on ngp static fields thr… JeanMeche Oct 18, 2026 https://github.com/angular/angular/pull/71417/commits/2f71f194f64ed80811897891ec24722e836366f4
Clear filters https://github.com/angular/angular/pull/71417/files
Please reload this pagehttps://github.com/angular/angular/pull/71417/files
Please reload this pagehttps://github.com/angular/angular/pull/71417/files
packages/compiler-cli/preprocessor/src/processor.tshttps://github.com/angular/angular/pull/71417/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
View file https://github.com/JeanMeche/angular/blob/2f71f194f64ed80811897891ec24722e836366f4/packages/compiler-cli/preprocessor/src/processor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71417/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71417/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
https://github.com/angular/angular/pull/71417/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
packages/compiler-cli/preprocessor/test/compliance_spec.tshttps://github.com/angular/angular/pull/71417/files#diff-caeae66d1840d92473f72c494e78722feaca32b8c8b4c4ae5ce608b7609aaec8
View file https://github.com/JeanMeche/angular/blob/2f71f194f64ed80811897891ec24722e836366f4/packages/compiler-cli/preprocessor/test/compliance_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71417/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71417/files#diff-caeae66d1840d92473f72c494e78722feaca32b8c8b4c4ae5ce608b7609aaec8
https://github.com/angular/angular/pull/71417/files#diff-caeae66d1840d92473f72c494e78722feaca32b8c8b4c4ae5ce608b7609aaec8
packages/compiler-cli/preprocessor/test/emit_suppressions_spec.tshttps://github.com/angular/angular/pull/71417/files#diff-d00e5e0606487785ebebf8d86a009e26afae62c8f89d73ad0692013daa565edf
View file https://github.com/JeanMeche/angular/blob/2f71f194f64ed80811897891ec24722e836366f4/packages/compiler-cli/preprocessor/test/emit_suppressions_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71417/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71417/files#diff-d00e5e0606487785ebebf8d86a009e26afae62c8f89d73ad0692013daa565edf
https://github.com/angular/angular/pull/71417/files#diff-d00e5e0606487785ebebf8d86a009e26afae62c8f89d73ad0692013daa565edf
https://github.com/angular/angular/pull/71417/files#diff-d00e5e0606487785ebebf8d86a009e26afae62c8f89d73ad0692013daa565edf
packages/compiler-cli/preprocessor/test/golden/advanced_signals/golden.mdhttps://github.com/angular/angular/pull/71417/files#diff-3bb30031cb97920f78df1d1e9bd2066efd24fab788ab46bf6417a9e99ce8551a
View file https://github.com/JeanMeche/angular/blob/2f71f194f64ed80811897891ec24722e836366f4/packages/compiler-cli/preprocessor/test/golden/advanced_signals/golden.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71417/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71417/files#diff-3bb30031cb97920f78df1d1e9bd2066efd24fab788ab46bf6417a9e99ce8551a
https://github.com/angular/angular/pull/71417/files#diff-3bb30031cb97920f78df1d1e9bd2066efd24fab788ab46bf6417a9e99ce8551a
Please reload this pagehttps://github.com/angular/angular/pull/71417/files
Please reload this pagehttps://github.com/angular/angular/pull/71417/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.