René's URL Explorer Experiment


Title: fix(compiler-cli): escape non-ascii characters in ngp string literals by JeanMeche · Pull Request #71415 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): escape non-ascii characters in ngp string literals by JeanMeche · Pull Request #71415 · angular/angular

X Title: fix(compiler-cli): escape non-ascii characters in ngp string literals by JeanMeche · Pull Request #71415 · angular/angular

Description: Summary Extends escapeIdentifier in AbstractEmitterVisitor with an escapeNonAscii option and exposes a protected escapeIdentifier hook so ngp's ExpressionPrinter escapes control and non-ASCII characters as \uXXXX in string literals, matching TypeScript's escapeNonAsciiString behavior on synthesized string literals. Adds an i18n named placeholder test case (// i18n(ph=...)) to the preprocessor goldens and removes the \uXXXX normalization from ngp_emit_normalizer. This was detected when working on #71343. Changes String literal escaping: Added an escapeNonAscii parameter to escapeIdentifier and a protected escapeIdentifier method on AbstractEmitterVisitor in packages/compiler/src/output/abstract_emitter.ts. Overrode escapeIdentifier in EmitterVisitor (packages/compiler-cli/preprocessor/src/output_ast_printer.ts) to escape control (\u0000-\u001f) and non-ASCII (\u0080-\uffff) code units as \uXXXX. Preprocessor goldens: Added LocalizeNamedPlaceholderCmp with {{ valueA // i18n(ph="PH_A") }} and {{ valueB // i18n(ph="PH B") }} to component_localize/source.md and updated component_localize/golden.md, component_localize/golden.opt.md, and utf16_semantics/golden.md. Normalizer cleanup: Removed \uXXXX decoding from normalizeNgpSourceMapSegment and normalizeNgpEmitForComparison in packages/compiler-cli/src/ngtsc/testing/src/ngp_emit_normalizer.ts.

Open Graph Description: Summary Extends escapeIdentifier in AbstractEmitterVisitor with an escapeNonAscii option and exposes a protected escapeIdentifier hook so ngp's ExpressionPrinter escapes control and non-ASCII c...

X Description: Summary Extends escapeIdentifier in AbstractEmitterVisitor with an escapeNonAscii option and exposes a protected escapeIdentifier hook so ngp's ExpressionPrinter escapes control and non-ASC...

Opengraph URL: https://github.com/angular/angular/pull/71415

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:33e53488-eb5c-77de-e485-09e496fc6104
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB36:14F601:1DEC82A:260C4E0:6B014923
html-safe-nonce0f100aa8ddefbab0fd38a5d96078089cef466873f8673f23818f0600e75d5aa4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjM2OjE0RjYwMToxREVDODJBOjI2MEM0RTA6NkIwMTQ5MjMiLCJ2aXNpdG9yX2lkIjoiMTAzMjEzMzM1OTQ1MjYzNzQ3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac51293df15ae587cf518c604a6760c857397f3a18d2588ff0ac0909e44abcdded
hovercard-subject-tagpull_request:4907035639
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/71415/files
twitter:imagehttps://avatars.githubusercontent.com/u/1300985?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1300985?s=400&v=4
og:image:altSummary Extends escapeIdentifier in AbstractEmitterVisitor with an escapeNonAscii option and exposes a protected escapeIdentifier hook so ngp's ExpressionPrinter escapes control and non-ASCII c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/71415/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71415%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71415%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/71415/files
Reloadhttps://github.com/angular/angular/pull/71415/files
Reloadhttps://github.com/angular/angular/pull/71415/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
JeanMeche:fix/ngp-escape-non-ascii-stringshttps://github.com/JeanMeche/angular/tree/fix/ngp-escape-non-ascii-strings
Conversation 6 https://github.com/angular/angular/pull/71415
Commits 1 https://github.com/angular/angular/pull/71415/commits
Checks 25 https://github.com/angular/angular/pull/71415/checks
Files changed https://github.com/angular/angular/pull/71415/files
Please reload this pagehttps://github.com/angular/angular/pull/71415/files
fix(compiler-cli): escape non-ascii characters in ngp string literals https://github.com/angular/angular/pull/71415/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/71415/files
942dcca fix(compiler-cli): escape non-ascii characters in ngp string literals JeanMeche Oct 18, 2026 https://github.com/angular/angular/pull/71415/commits/942dccad1a7b7562159a2533e4ee68aeecf72a4c
Clear filters https://github.com/angular/angular/pull/71415/files
Please reload this pagehttps://github.com/angular/angular/pull/71415/files
Please reload this pagehttps://github.com/angular/angular/pull/71415/files
output_ast_printer.ts https://github.com/angular/angular/pull/71415/files#diff-9f89130c9871d1a558361bba89f723bca431d8cf80f792d228fbff9b1c626c95
golden.md https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
golden.opt.md https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
source.md https://github.com/angular/angular/pull/71415/files#diff-38070e02b48fc5bf8b64221248b85b3b36d817a67a2ef0576e2536be6f8dcff7
golden.md https://github.com/angular/angular/pull/71415/files#diff-66340aeaaaf66db8ed00b131dc2c4132e18fb127ee12e4d9fcf85ab1239f2b94
ngp_emit_normalizer.ts https://github.com/angular/angular/pull/71415/files#diff-9ed10c53a7ab67b083ad5da14a3069149c237bd2117232fe4f6b9e330961be97
abstract_emitter.ts https://github.com/angular/angular/pull/71415/files#diff-872c0445352c91f203969bb6af20b1366df2a0f1e89c123a97f49d0f82811a6b
abstract_emitter_spec.ts https://github.com/angular/angular/pull/71415/files#diff-64a1d1fa4f9da96a237ffff8a42c468c105e4bb9ee9850e9e9b68e2ba9ef7578
packages/compiler-cli/preprocessor/src/output_ast_printer.tshttps://github.com/angular/angular/pull/71415/files#diff-9f89130c9871d1a558361bba89f723bca431d8cf80f792d228fbff9b1c626c95
View file https://github.com/JeanMeche/angular/blob/942dccad1a7b7562159a2533e4ee68aeecf72a4c/packages/compiler-cli/preprocessor/src/output_ast_printer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71415/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71415/files#diff-9f89130c9871d1a558361bba89f723bca431d8cf80f792d228fbff9b1c626c95
https://github.com/angular/angular/pull/71415/files#diff-9f89130c9871d1a558361bba89f723bca431d8cf80f792d228fbff9b1c626c95
packages/compiler-cli/preprocessor/test/golden/component_localize/golden.mdhttps://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
View file https://github.com/JeanMeche/angular/blob/942dccad1a7b7562159a2533e4ee68aeecf72a4c/packages/compiler-cli/preprocessor/test/golden/component_localize/golden.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71415/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71415/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
packages/compiler-cli/preprocessor/test/golden/component_localize/golden.opt.mdhttps://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
View file https://github.com/JeanMeche/angular/blob/942dccad1a7b7562159a2533e4ee68aeecf72a4c/packages/compiler-cli/preprocessor/test/golden/component_localize/golden.opt.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71415/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71415/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
Please reload this pagehttps://github.com/angular/angular/pull/71415/files
Please reload this pagehttps://github.com/angular/angular/pull/71415/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.