René's URL Explorer Experiment


Title: fix(compiler-cli): align ngp pipe decorator args and closure message names with ngtsc by JeanMeche · Pull Request #71413 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): align ngp pipe decorator args and closure message names with ngtsc by JeanMeche · Pull Request #71413 · angular/angular

X Title: fix(compiler-cli): align ngp pipe decorator args and closure message names with ngtsc by JeanMeche · Pull Request #71413 · angular/angular

Description: Description This PR addresses two emission differences between ngp and ngtsc: Pipe Decorator Metadata Args: In ng-analyze, parse_pipe_args now captures args_span whenever call_expr.arguments is non-empty, so non-object arguments (e.g. @Pipe(null!)) retain an args: [null!] array in ɵsetClassMetadata, matching ngtsc. validate_pipe now gates missing-name checking on metadata_span (presence of an object literal argument), matching ngtsc's meta !== null check. Updated compliance_pipes golden expectations. Closure Message Path (MSG_...$$APP_COMPONENT_TS): relativeContextFilePath in processor.ts now delegates to (getProjectRelativePath(filePath, ctx) ?? filePath).replace(/^\/+/, '') to resolve paths across configured rootDirs and omit leading slashes, matching ngtsc's Closure goog.getMsg variable name generation. Updated component_localize golden expectations. Those were caught when working on #71343 Tests //packages/compiler-cli/preprocessor/... //packages/compiler-cli/test/compliance/full:full_ngp //packages/compiler-cli/test/compliance/full:full //packages/compiler-cli/test/ngtsc:ngtsc_ngp

Open Graph Description: Description This PR addresses two emission differences between ngp and ngtsc: Pipe Decorator Metadata Args: In ng-analyze, parse_pipe_args now captures args_span whenever call_expr.arguments is ...

X Description: Description This PR addresses two emission differences between ngp and ngtsc: Pipe Decorator Metadata Args: In ng-analyze, parse_pipe_args now captures args_span whenever call_expr.arguments is ...

Opengraph URL: https://github.com/angular/angular/pull/71413

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b5065c75-62c4-83da-66af-35ab052ccf2a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBB76:2679E9:18BACC1:20F1476:6B014F41
html-safe-noncecbceec7396551b756c66658a6e2d148f6e7b05e511b7f9002ba09fe330ce28fa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjc2OjI2NzlFOToxOEJBQ0MxOjIwRjE0NzY6NkIwMTRGNDEiLCJ2aXNpdG9yX2lkIjoiNDkwOTg0NTExOTUxNzE1MTA0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8c5dc1ce7bf1befb7f7bf3f51f3c81ec4eecafd8779341ba2e4a5d99cf7fdc2e
hovercard-subject-tagpull_request:4902294875
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/71413/files
twitter:imagehttps://avatars.githubusercontent.com/u/1300985?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1300985?s=400&v=4
og:image:altDescription This PR addresses two emission differences between ngp and ngtsc: Pipe Decorator Metadata Args: In ng-analyze, parse_pipe_args now captures args_span whenever call_expr.arguments is ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/71413/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71413%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F71413%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/71413/files
Reloadhttps://github.com/angular/angular/pull/71413/files
Reloadhttps://github.com/angular/angular/pull/71413/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
JeanMeche:fix/ngp-pipe-and-i18n-parityhttps://github.com/JeanMeche/angular/tree/fix/ngp-pipe-and-i18n-parity
Conversation 2 https://github.com/angular/angular/pull/71413
Commits 2 https://github.com/angular/angular/pull/71413/commits
Checks 25 https://github.com/angular/angular/pull/71413/checks
Files changed https://github.com/angular/angular/pull/71413/files
Please reload this pagehttps://github.com/angular/angular/pull/71413/files
fix(compiler-cli): align ngp pipe decorator args and closure message names with ngtsc https://github.com/angular/angular/pull/71413/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/71413/files
b3706c2 fix(compiler-cli): record argsSpan on non-object pipe decorators in n… JeanMeche Oct 17, 2026 https://github.com/angular/angular/pull/71413/commits/b3706c21d5d2b04c2f68ce0e6dcb6d4cdfd73979
6f91079 fix(compiler-cli): resolve project-relative context file path for clo… JeanMeche Oct 17, 2026 https://github.com/angular/angular/pull/71413/commits/6f91079ae1d8d9c5717a3027e597d6cb48e47c12
Clear filters https://github.com/angular/angular/pull/71413/files
Please reload this pagehttps://github.com/angular/angular/pull/71413/files
Please reload this pagehttps://github.com/angular/angular/pull/71413/files
class_data.rs https://github.com/angular/angular/pull/71413/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
pipe.rs https://github.com/angular/angular/pull/71413/files#diff-87ce412ea74260a8177b3c83201fc6e5034be4e60906db2798baaa3e6101e30b
processor.ts https://github.com/angular/angular/pull/71413/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
golden.md https://github.com/angular/angular/pull/71413/files#diff-36bf055c0e75f3a86b6b9ab573e4685b4010e1ce46743a4acc74513d623e6fd5
golden.opt.md https://github.com/angular/angular/pull/71413/files#diff-5d42425a7a0fb8ef053ba1548a594f7c612c9c8ab94162609ee40df4153010c4
golden.md https://github.com/angular/angular/pull/71413/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
golden.opt.md https://github.com/angular/angular/pull/71413/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/class_data.rshttps://github.com/angular/angular/pull/71413/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
View file https://github.com/JeanMeche/angular/blob/6f91079ae1d8d9c5717a3027e597d6cb48e47c12/packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/class_data.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71413/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71413/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
https://github.com/angular/angular/pull/71413/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
https://github.com/angular/angular/pull/71413/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
https://github.com/angular/angular/pull/71413/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
https://github.com/angular/angular/pull/71413/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
https://github.com/angular/angular/pull/71413/files#diff-8dd3dd224101594607fd5c77e49e0103291fc1cae791cdd00632e848c5b97855
packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/pipe.rshttps://github.com/angular/angular/pull/71413/files#diff-87ce412ea74260a8177b3c83201fc6e5034be4e60906db2798baaa3e6101e30b
View file https://github.com/JeanMeche/angular/blob/6f91079ae1d8d9c5717a3027e597d6cb48e47c12/packages/compiler-cli/preprocessor/ng-analyze/src/analyzer/pipe.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71413/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71413/files#diff-87ce412ea74260a8177b3c83201fc6e5034be4e60906db2798baaa3e6101e30b
https://github.com/angular/angular/pull/71413/files#diff-87ce412ea74260a8177b3c83201fc6e5034be4e60906db2798baaa3e6101e30b
packages/compiler-cli/preprocessor/src/processor.tshttps://github.com/angular/angular/pull/71413/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
View file https://github.com/JeanMeche/angular/blob/6f91079ae1d8d9c5717a3027e597d6cb48e47c12/packages/compiler-cli/preprocessor/src/processor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71413/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71413/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
https://github.com/angular/angular/pull/71413/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
https://github.com/angular/angular/pull/71413/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
https://github.com/angular/angular/pull/71413/files#diff-11a554aadc1f61a057b3627c52168004340ba132daabd01546c3729336fd4d4d
packages/compiler-cli/preprocessor/test/golden/compliance_pipes/golden.mdhttps://github.com/angular/angular/pull/71413/files#diff-36bf055c0e75f3a86b6b9ab573e4685b4010e1ce46743a4acc74513d623e6fd5
View file https://github.com/JeanMeche/angular/blob/6f91079ae1d8d9c5717a3027e597d6cb48e47c12/packages/compiler-cli/preprocessor/test/golden/compliance_pipes/golden.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71413/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71413/files#diff-36bf055c0e75f3a86b6b9ab573e4685b4010e1ce46743a4acc74513d623e6fd5
https://github.com/angular/angular/pull/71413/files#diff-36bf055c0e75f3a86b6b9ab573e4685b4010e1ce46743a4acc74513d623e6fd5
packages/compiler-cli/preprocessor/test/golden/compliance_pipes/golden.opt.mdhttps://github.com/angular/angular/pull/71413/files#diff-5d42425a7a0fb8ef053ba1548a594f7c612c9c8ab94162609ee40df4153010c4
View file https://github.com/JeanMeche/angular/blob/6f91079ae1d8d9c5717a3027e597d6cb48e47c12/packages/compiler-cli/preprocessor/test/golden/compliance_pipes/golden.opt.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71413/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71413/files#diff-5d42425a7a0fb8ef053ba1548a594f7c612c9c8ab94162609ee40df4153010c4
https://github.com/angular/angular/pull/71413/files#diff-5d42425a7a0fb8ef053ba1548a594f7c612c9c8ab94162609ee40df4153010c4
packages/compiler-cli/preprocessor/test/golden/component_localize/golden.mdhttps://github.com/angular/angular/pull/71413/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
View file https://github.com/JeanMeche/angular/blob/6f91079ae1d8d9c5717a3027e597d6cb48e47c12/packages/compiler-cli/preprocessor/test/golden/component_localize/golden.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71413/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71413/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71413/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71413/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71413/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71413/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71413/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71413/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
https://github.com/angular/angular/pull/71413/files#diff-fdc9684019ae925884fe58d9589e193f693d6d5870fbe538e7039333be4b3ec7
packages/compiler-cli/preprocessor/test/golden/component_localize/golden.opt.mdhttps://github.com/angular/angular/pull/71413/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
View file https://github.com/JeanMeche/angular/blob/6f91079ae1d8d9c5717a3027e597d6cb48e47c12/packages/compiler-cli/preprocessor/test/golden/component_localize/golden.opt.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/71413/{{ revealButtonHref }}
https://github.com/angular/angular/pull/71413/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71413/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71413/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71413/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71413/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71413/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71413/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
https://github.com/angular/angular/pull/71413/files#diff-d927e28a11982de03162b127c5580bedf11334d1b89b9c9618177ab035cd2e7e
Please reload this pagehttps://github.com/angular/angular/pull/71413/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.