Title: fix(compiler): clarify the error for an update operator followed by an operand by aminesbdev · Pull Request #71410 · angular/angular · GitHub
Open Graph Title: fix(compiler): clarify the error for an update operator followed by an operand by aminesbdev · Pull Request #71410 · angular/angular
X Title: fix(compiler): clarify the error for an update operator followed by an operand by aminesbdev · Pull Request #71410 · angular/angular
Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? a--b and a++b compiled up to 22.2 (as a - -b and a + +b) and now fail, since -- and ++ are update operators. In a binding the error is Bindings cannot contain assignments, in an event binding Unexpected token 'b'. Neither one tells you the -- is the issue or how to write the old expression. Issue Number: Fixes #71409 What is the new behavior? When a postfix ++ or -- is directly followed by an identifier, a number or a keyword that starts an operand (this, true, typeof...), the error now says what to write: Unexpected token 'b' after the '--' decrement operator. To subtract '-b', write '- -b' Unexpected token 'b' after the '++' increment operator. To add '+b', write '+ +b' The check sits in parseCallChain, where the postfix operator is read, so bindings, event bindings and host bindings all get it. Nothing valid changes: a--, a-- - b, a--; b() and a - -b parse as before. I left foo++[0] and foo++() out on purpose, the "should not allow member access or calls after a postfix update" spec already covers them. The new spec in parser_spec.ts fails without the change. The existing foo-- bar expectation still passes, since the message still starts with Unexpected token 'bar'. Does this PR introduce a breaking change? Yes No Other information I kept a--b as an error instead of going back to the old parsing: it's not valid JavaScript, and the parser specs already expect it to fail. If you'd rather keep it compiling as a - -b for a while, that's a small change in the same place and I'm happy to switch.
Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
Opengraph URL: https://github.com/angular/angular/pull/71410
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b5e98393-e08b-0816-9f46-23a03ca4e505 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EBE8:34CAB:19F9C12:21257C4:6B015151 |
| html-safe-nonce | 58660cbdfbe90949291ba7dfccc543f99cb98ca24f59cb5f1509a12ccafda74c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkU4OjM0Q0FCOjE5RjlDMTI6MjEyNTdDNDo2QjAxNTE1MSIsInZpc2l0b3JfaWQiOiIxODk0ODU1NjIzMzU5NjgwODQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c707d7ddc1f4b6d3e61b67b9d2d865919e08a2ad70901e70d17f4555deb68cfe |
| hovercard-subject-tag | pull_request:4899533225 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/71410/files |
| twitter:image | https://avatars.githubusercontent.com/u/131322074?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/131322074?s=400&v=4 |
| og:image:alt | PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width