Title: docs: fix afterRenderEffect phase example in the effect guide by GabeSilvaDev · Pull Request #71091 · angular/angular · GitHub
Open Graph Title: docs: fix afterRenderEffect phase example in the effect guide by GabeSilvaDev · Pull Request #71091 · angular/angular
X Title: docs: fix afterRenderEffect phase example in the effect guide by GabeSilvaDev · Pull Request #71091 · angular/angular
Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A The "Render phases" section says that a phase is specified by passing an object with a phase property to afterRender or afterNextRender, but the example below uses afterRenderEffect with one callback for each phase. Neither the afterRender name nor the phase option matches the current API. afterRender was renamed to afterEveryRender in #60999, and the phase option was replaced by the per-phase callback object in #55648. The chart example above also calls this.canvas().nativeElement() even though nativeElement is a property of ElementRef, not a method. What is the new behavior? The description now matches the current afterRenderEffect API by explaining that phases are specified with an object containing a callback for each phase. The chart example also uses this.canvas().nativeElement. Does this PR introduce a breaking change? Yes No Other information Docs-only change in adev/src/content/guide/signals/effect.md.
Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
Opengraph URL: https://github.com/angular/angular/pull/71091
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5db886dd-bb15-f70a-1200-d0f518e3d722 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B3B6:1D8AA1:1DAD99B:26F4E61:6B015353 |
| html-safe-nonce | 01c4960b8ae22232988eea127fc2b2f511b613717816f78ba216c0de0231b54f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0I2OjFEOEFBMToxREFEOTlCOjI2RjRFNjE6NkIwMTUzNTMiLCJ2aXNpdG9yX2lkIjoiMjk1NTA5ODg0NjE4NDY5MDUxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5caaa3b2bb09896792abf84f3a892e90c20082a4a2537f741ad8387172a7ce7a |
| hovercard-subject-tag | pull_request:4692229120 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/71091/files |
| twitter:image | https://avatars.githubusercontent.com/u/96894950?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/96894950?s=400&v=4 |
| og:image:alt | PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width