Title: docs(router): update parameter inheritance guide for the new default by GabeSilvaDev · Pull Request #71049 · angular/angular · GitHub
Open Graph Title: docs(router): update parameter inheritance guide for the new default by GabeSilvaDev · Pull Request #71049 · angular/angular
X Title: docs(router): update parameter inheritance guide for the new default by GabeSilvaDev · Pull Request #71049 · angular/angular
Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A The "Control parameter inheritance" section was updated when #68256 changed the default paramsInheritanceStrategy to 'always', but the example still leads with the 'emptyOnly' configuration and the parent route traversal. This makes the default behavior less clear, since the first example a reader sees is for the legacy option rather than the default. The RouteReuseStrategy table also still marks shouldDestroyInjector as "(Experimental)", even though the feature was stabilized in #70443. What is the new behavior? The parameter inheritance section now starts with the default 'always' behavior, showing a Customer component reading the inherited parameters directly. The 'emptyOnly' configuration is then documented as the legacy option, along with the parent traversal example. The "(Experimental)" label is also removed from the shouldDestroyInjector row. Does this PR introduce a breaking change? Yes No Other information The 'emptyOnly' description matches the paramsInheritanceStrategy JSDoc in packages/router/src/router_config.ts.
Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
Opengraph URL: https://github.com/angular/angular/pull/71049
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:77e09ee9-5375-9d2a-4c86-91fbe4a0cf49 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F58:D5AA4:2060836:2B1621E:6B017467 |
| html-safe-nonce | b16b38912de549dee01754a64cc8b7acb3df91c7dfd7c5714448446d09412052 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjU4OkQ1QUE0OjIwNjA4MzY6MkIxNjIxRTo2QjAxNzQ2NyIsInZpc2l0b3JfaWQiOiI3OTc3Mjg4OTIxMzg5MTA4MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2e179f4a926dc696da6e90542181bd0d2e065db674d5d44c329a8ff100664dd2 |
| hovercard-subject-tag | pull_request:4680162603 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/71049/files |
| twitter:image | https://avatars.githubusercontent.com/u/96894950?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/96894950?s=400&v=4 |
| og:image:alt | PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width