René's URL Explorer Experiment


Title: perf(router): do not retain UrlTree instances in RouterLink by atscott · Pull Request #70955 · angular/angular · GitHub

Open Graph Title: perf(router): do not retain UrlTree instances in RouterLink by atscott · Pull Request #70955 · angular/angular

X Title: perf(router): do not retain UrlTree instances in RouterLink by atscott · Pull Request #70955 · angular/angular

Description: In 89d47d8, RouterLink internals were refactored to use signals, introducing a computed signal _urlTree. Because every maintains an active RouterLink directive instance for the lifetime of the view/request, the computed signal permanently cached the returned UrlTree (and its cloned queryParams map and segment tree) in ReactiveNode.value for every link. During server-side rendering (SSR), especially when query parameters are large or when defaultQueryParamsHandling: 'merge' is enabled, each rendered link held a full copy of the query parameter map pinned in the heap. In an application with 100 links and thousands of query parameters, this pinned over 50 MB of heap per in-flight request, causing server workers to crash with Out of Memory (OOM) under concurrent load (#70908). This change moves the reactive dependencies (path, fragment, and queryParams) directly into reactiveHref so it computes and retains only the serialized href string. The intermediate UrlTree and its queryParams dictionary are discarded immediately after serialization and collected during young-generation GC scavenges rather than remaining pinned in the heap. The public urlTree getter and onClick handler now compute the tree on demand, restoring the memory profile prior to 89d47d8. Fixes #70908 Cherry pick of #70953

Open Graph Description: In 89d47d8, RouterLink internals were refactored to use signals, introducing a computed signal _urlTree. Because every <a routerLink> maintains an active RouterLink directive instance for the...

X Description: In 89d47d8, RouterLink internals were refactored to use signals, introducing a computed signal _urlTree. Because every &lt;a routerLink&gt; maintains an active RouterLink directive instance...

Opengraph URL: https://github.com/angular/angular/pull/70955

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b3c4ef69-f052-90fc-c3c2-1fcf142eb0b9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE5EE:629C2:18C57D:200910:6AFE47BF
html-safe-nonceece3a080d82e5b34009787502dc45a9cdea06c40bef1247ee366d0ed04baecbb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUVFOjYyOUMyOjE4QzU3RDoyMDA5MTA6NkFGRTQ3QkYiLCJ2aXNpdG9yX2lkIjoiMzU1MDE3ODcwMjYyMjg2OTQzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac52361ac93ffe9873167a735d88be307c310c99258391b917315152186b16aea0
hovercard-subject-tagpull_request:4643733331
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/70955/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altIn 89d47d8, RouterLink internals were refactored to use signals, introducing a computed signal _urlTree. Because every <a routerLink> maintains an active RouterLink directive instance for the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef1a5901e2377b0af2a0b303f9528678f1475d04b9219dca1e993344196eaa07c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasece393ea11ad276623b946bc9663d3e7d6f564275
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/70955/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70955%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70955%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/70955/files
Reloadhttps://github.com/angular/angular/pull/70955/files
Reloadhttps://github.com/angular/angular/pull/70955/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests124 (124)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:21.2.xhttps://github.com/angular/angular/tree/21.2.x
atscott:cpurltreelinkhttps://github.com/atscott/angular/tree/cpurltreelink
Conversation 3 https://github.com/angular/angular/pull/70955
Commits 1 https://github.com/angular/angular/pull/70955/commits
Checks 14 https://github.com/angular/angular/pull/70955/checks
Files changed https://github.com/angular/angular/pull/70955/files
Please reload this pagehttps://github.com/angular/angular/pull/70955/files
perf(router): do not retain UrlTree instances in RouterLink https://github.com/angular/angular/pull/70955/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/70955/files
1739fb5 perf(router): do not retain UrlTree instances in RouterLink atscott Sep 25, 2026 https://github.com/angular/angular/pull/70955/commits/1739fb56d7fc93881a6ec3da9964a4433cd4883b
Clear filters https://github.com/angular/angular/pull/70955/files
Please reload this pagehttps://github.com/angular/angular/pull/70955/files
Please reload this pagehttps://github.com/angular/angular/pull/70955/files
packages/router/src/directives/router_link.tshttps://github.com/angular/angular/pull/70955/files#diff-27e12be267a9b28a76357eaae5688524dfff5aed7034fcde784c77803be7035f
View file https://github.com/atscott/angular/blob/1739fb56d7fc93881a6ec3da9964a4433cd4883b/packages/router/src/directives/router_link.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/70955/{{ revealButtonHref }}
https://github.com/angular/angular/pull/70955/files#diff-27e12be267a9b28a76357eaae5688524dfff5aed7034fcde784c77803be7035f
https://github.com/angular/angular/pull/70955/files#diff-27e12be267a9b28a76357eaae5688524dfff5aed7034fcde784c77803be7035f
https://github.com/angular/angular/pull/70955/files#diff-27e12be267a9b28a76357eaae5688524dfff5aed7034fcde784c77803be7035f
https://github.com/angular/angular/pull/70955/files#diff-27e12be267a9b28a76357eaae5688524dfff5aed7034fcde784c77803be7035f
https://github.com/angular/angular/pull/70955/files#diff-27e12be267a9b28a76357eaae5688524dfff5aed7034fcde784c77803be7035f
https://github.com/angular/angular/pull/70955/files#diff-27e12be267a9b28a76357eaae5688524dfff5aed7034fcde784c77803be7035f
Please reload this pagehttps://github.com/angular/angular/pull/70955/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.