René's URL Explorer Experiment


Title: fix(router): don't flash inactive on the first render of RouterLinkActive by aminesbdev · Pull Request #70828 · angular/angular · GitHub

Open Graph Title: fix(router): don't flash inactive on the first render of RouterLinkActive by aminesbdev · Pull Request #70828 · angular/angular

X Title: fix(router): don't flash inactive on the first render of RouterLinkActive by aminesbdev · Pull Request #70828 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: RouterLinkActive holds back the active class until router.navigated is true, which only happens after the first NavigationEnd. If the app boots on a route that a link already points to, that link r...

X Description: RouterLinkActive holds back the active class until router.navigated is true, which only happens after the first NavigationEnd. If the app boots on a route that a link already points to, that link r...

Opengraph URL: https://github.com/angular/angular/pull/70828

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a0d2776c-56fb-14c9-3f8e-8dc7f74508ac
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD7A:B1B84:29B75E1:3517807:6B01DEBB
html-safe-nonce38afc25925f0cd9b9364873efcf54d3b7c050712332d974ca99a2ef891c964aa
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDdBOkIxQjg0OjI5Qjc1RTE6MzUxNzgwNzo2QjAxREVCQiIsInZpc2l0b3JfaWQiOiI4NTA0MzE2MDM1NjU3MjI3OTYzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca7282fa6a24dbbfe1331ca430976a470818281519a32576711133d9e488d4fb4
hovercard-subject-tagpull_request:4583379869
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/70828/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/450946aa73733e7b83f5c90740ebe71d2a26e6dc6a6cc63338e8000ec1972c02/angular/angular/pull/70828
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/450946aa73733e7b83f5c90740ebe71d2a26e6dc6a6cc63338e8000ec1972c02/angular/angular/pull/70828
og:image:altRouterLinkActive holds back the active class until router.navigated is true, which only happens after the first NavigationEnd. If the app boots on a route that a link already points to, that link r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaminesbdev
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/70828#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70828
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70828
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/70828
Reloadhttps://github.com/angular/angular/pull/70828
Reloadhttps://github.com/angular/angular/pull/70828
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
aminesbdevhttps://github.com/aminesbdev
angular:mainhttps://github.com/angular/angular/tree/main
aminesbdev:fix/router-link-active-initial-flashhttps://github.com/aminesbdev/angular/tree/fix/router-link-active-initial-flash
Conversationhttps://github.com/angular/angular/pull/70828
Commits1 (1)https://github.com/angular/angular/pull/70828/commits
Checkshttps://github.com/angular/angular/pull/70828/checks
Files changedhttps://github.com/angular/angular/pull/70828/files
fix(router): don't flash inactive on the first render of RouterLinkActivehttps://github.com/angular/angular/pull/70828#top
aminesbdevhttps://github.com/aminesbdev
angular:mainhttps://github.com/angular/angular/tree/main
aminesbdev:fix/router-link-active-initial-flashhttps://github.com/aminesbdev/angular/tree/fix/router-link-active-initial-flash
https://github.com/aminesbdev
aminesbdevhttps://github.com/aminesbdev
Sep 20, 2026https://github.com/angular/angular/pull/70828#issue-5517062993
Please reload this pagehttps://github.com/angular/angular/pull/70828
Please reload this pagehttps://github.com/angular/angular/pull/70828
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
crisbetohttps://github.com/crisbeto
September 20, 2026 09:43https://github.com/angular/angular/pull/70828#event-31477316791
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
Sep 20, 2026https://github.com/angular/angular/pull/70828#event-31477320658
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Sep 20, 2026https://github.com/angular/angular/pull/70828#event-31477321690
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
atscotthttps://github.com/atscott
crisbetohttps://github.com/crisbeto
September 20, 2026 14:18https://github.com/angular/angular/pull/70828#event-31483124477
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 22, 2026 https://github.com/angular/angular/pull/70828#pullrequestreview-5284129616
View reviewed changes https://github.com/angular/angular/pull/70828/files
packages/router/src/directives/router_link_active.tshttps://github.com/angular/angular/pull/70828/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f
atscotthttps://github.com/atscott
Sep 22, 2026https://github.com/angular/angular/pull/70828#discussion_r4076809119
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70828
packages/router/src/directives/router_link_active.tshttps://github.com/angular/angular/pull/70828/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f
atscotthttps://github.com/atscott
Sep 22, 2026https://github.com/angular/angular/pull/70828#discussion_r4076811769
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70828
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 22, 2026 https://github.com/angular/angular/pull/70828#pullrequestreview-5284251817
View reviewed changes https://github.com/angular/angular/pull/70828/files
packages/router/src/directives/router_link_active.tshttps://github.com/angular/angular/pull/70828/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f
atscotthttps://github.com/atscott
Sep 22, 2026https://github.com/angular/angular/pull/70828#discussion_r4076914641
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70828
aminesbdevhttps://github.com/aminesbdev
Sep 23, 2026https://github.com/angular/angular/pull/70828#discussion_r4079294104
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70828
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 22, 2026 https://github.com/angular/angular/pull/70828#pullrequestreview-5285041782
View reviewed changes https://github.com/angular/angular/pull/70828/files
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/70828#pullrequestreview-5285041782
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70828
packages/router/src/directives/router_link_active.tshttps://github.com/angular/angular/pull/70828/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f
atscotthttps://github.com/atscott
Sep 22, 2026https://github.com/angular/angular/pull/70828#discussion_r4077515504
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70828
packages/router/src/directives/router_link_active.tshttps://github.com/angular/angular/pull/70828/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f
atscotthttps://github.com/atscott
Sep 22, 2026https://github.com/angular/angular/pull/70828#discussion_r4077515517
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70828
packages/router/src/directives/router_link_active.tshttps://github.com/angular/angular/pull/70828/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f
atscotthttps://github.com/atscott
Sep 22, 2026https://github.com/angular/angular/pull/70828#discussion_r4077515521
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70828
packages/router/src/directives/router_link_active.tshttps://github.com/angular/angular/pull/70828/files#diff-ce77da6bfcb325f1e982247bf0cf5a3a19da1fc2d4fc4fb04c4d0fe8e9b7cf8f
atscotthttps://github.com/atscott
Sep 22, 2026https://github.com/angular/angular/pull/70828#discussion_r4077515530
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70828
packages/router/test/integration/router_link_active.spec.tshttps://github.com/angular/angular/pull/70828/files#diff-4f26bfa5bf1e18b1bec888ea92c6cca27d3d04a7e79308fa5a34658c1d341700
atscotthttps://github.com/atscott
Sep 22, 2026https://github.com/angular/angular/pull/70828#discussion_r4077515534
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70828
https://github.com/aminesbdev
aminesbdevhttps://github.com/aminesbdev
force-pushedhttps://github.com/angular/angular/compare/202e22ecd028138160ef602b6dd4bb1d1059e05c..74ffa8c638990fe0d09ffeaf62b8c8011b577c0e
202e22ehttps://github.com/angular/angular/commit/202e22ecd028138160ef602b6dd4bb1d1059e05c
74ffa8chttps://github.com/angular/angular/commit/74ffa8c638990fe0d09ffeaf62b8c8011b577c0e
Compare https://github.com/angular/angular/compare/202e22ecd028138160ef602b6dd4bb1d1059e05c..74ffa8c638990fe0d09ffeaf62b8c8011b577c0e
September 23, 2026 05:14https://github.com/angular/angular/pull/70828#event-31651980022
https://github.com/aminesbdev
aminesbdevhttps://github.com/aminesbdev
atscotthttps://github.com/atscott
September 23, 2026 05:20https://github.com/angular/angular/pull/70828#event-31652210200
https://github.com/aminesbdev
fix(router): don't flash inactive on the first render of RouterLinkAc…https://github.com/angular/angular/pull/70828/commits/66ae3385e95d45ac7730fa75e9fba726565ac50e
66ae338https://github.com/angular/angular/pull/70828/commits/66ae3385e95d45ac7730fa75e9fba726565ac50e
https://github.com/aminesbdev
aminesbdevhttps://github.com/aminesbdev
force-pushedhttps://github.com/angular/angular/compare/74ffa8c638990fe0d09ffeaf62b8c8011b577c0e..66ae3385e95d45ac7730fa75e9fba726565ac50e
74ffa8chttps://github.com/angular/angular/commit/74ffa8c638990fe0d09ffeaf62b8c8011b577c0e
66ae338https://github.com/angular/angular/commit/66ae3385e95d45ac7730fa75e9fba726565ac50e
Compare https://github.com/angular/angular/compare/74ffa8c638990fe0d09ffeaf62b8c8011b577c0e..66ae3385e95d45ac7730fa75e9fba726565ac50e
September 29, 2026 05:07https://github.com/angular/angular/pull/70828#event-32051191325
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Sep 29, 2026https://github.com/angular/angular/pull/70828#event-32081239118
RouterLinkActive initial render state prior to first router navigation #62973 https://github.com/angular/angular/issues/62973
https://github.com/atscott
atscotthttps://github.com/atscott
Oct 5, 2026https://github.com/angular/angular/pull/70828#issuecomment-6001456549
packages/core/src/render3/instructions/shared.ts (elementLikeStartShared)https://github.com/angular/angular/blob/main/packages/core/src/render3/instructions/shared.ts#L599-L616
setupStaticAttributeshttps://github.com/angular/angular/blob/main/packages/core/src/render3/dom_node_manipulation.ts#L130-L155
Please reload this pagehttps://github.com/angular/angular/pull/70828
https://github.com/aminesbdev
aminesbdevhttps://github.com/aminesbdev
Oct 6, 2026 https://github.com/angular/angular/pull/70828#ref-pullrequest-5722841388
fix(core): don't overwrite static attributes of hydrated elements #71200 https://github.com/angular/angular/pull/71200
https://github.com/aminesbdev
aminesbdevhttps://github.com/aminesbdev
October 6, 2026 04:18https://github.com/angular/angular/pull/70828#event-32567022469
https://github.com/aminesbdev
aminesbdevhttps://github.com/aminesbdev
Oct 6, 2026https://github.com/angular/angular/pull/70828#issuecomment-6009247125
packages/core/src/render3/instructions/shared.ts (elementLikeStartShared)https://github.com/angular/angular/blob/main/packages/core/src/render3/instructions/shared.ts#L599-L616
setupStaticAttributeshttps://github.com/angular/angular/blob/main/packages/core/src/render3/dom_node_manipulation.ts#L130-L155
#71200https://github.com/angular/angular/pull/71200
Please reload this pagehttps://github.com/angular/angular/pull/70828
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
Nov 4, 2026https://github.com/angular/angular/pull/70828#issuecomment-6618837912
Please reload this pagehttps://github.com/angular/angular/pull/70828
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
Nov 4, 2026https://github.com/angular/angular/pull/70828#event-35078401059
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70828
https://github.com/atscott
atscott https://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/70828
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
Backlog https://github.com/angular/angular/milestone/82
RouterLinkActive initial render state prior to first router navigation https://github.com/angular/angular/issues/62973
Please reload this pagehttps://github.com/angular/angular/pull/70828
https://github.com/aminesbdev
https://github.com/atscott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.