René's URL Explorer Experiment


Title: feat(compiler): check that ng-container don't have class bindings by JeanMeche · Pull Request #70808 · angular/angular · GitHub

Open Graph Title: feat(compiler): check that ng-container don't have class bindings by JeanMeche · Pull Request #70808 · angular/angular

X Title: feat(compiler): check that ng-container don't have class bindings by JeanMeche · Pull Request #70808 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Those are never applied and we should throw at compiler time. class attributes are still supported because we allow them for content projection purposes.

X Description: Those are never applied and we should throw at compiler time. class attributes are still supported because we allow them for content projection purposes.

Opengraph URL: https://github.com/angular/angular/pull/70808

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:643890b3-ab8a-5379-0c23-9f72c426afd6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96EE:A71F9:3776EC:4596AB:6B01050A
html-safe-noncee4fcac08938e1b1fccb625adb427879a8145ca9c9d5cd64bae9047a96604fab1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkVFOkE3MUY5OjM3NzZFQzo0NTk2QUI6NkIwMTA1MEEiLCJ2aXNpdG9yX2lkIjoiNTY4NTcyOTExMDQwODYyNzQ2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac01784b102988bbd0628638f478246517d81ec7c2e1446e82901db6244fd86928
hovercard-subject-tagpull_request:4568619481
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/70808/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/819e813aab95a2c7760790e3db25acb1f455ba1fe0842d1bed11f77d97b4ac37/angular/angular/pull/70808
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/819e813aab95a2c7760790e3db25acb1f455ba1fe0842d1bed11f77d97b4ac37/angular/angular/pull/70808
og:image:altThose are never applied and we should throw at compiler time. class attributes are still supported because we allow them for content projection purposes.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJeanMeche
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/70808#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70808
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70808
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/70808
Reloadhttps://github.com/angular/angular/pull/70808
Reloadhttps://github.com/angular/angular/pull/70808
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
JeanMechehttps://github.com/JeanMeche
angular:mainhttps://github.com/angular/angular/tree/main
JeanMeche:container-classhttps://github.com/JeanMeche/angular/tree/container-class
Conversationhttps://github.com/angular/angular/pull/70808
Commits1 (1)https://github.com/angular/angular/pull/70808/commits
Checkshttps://github.com/angular/angular/pull/70808/checks
Files changedhttps://github.com/angular/angular/pull/70808/files
feat(compiler): check that ng-container don't have class bindings https://github.com/angular/angular/pull/70808#top
JeanMechehttps://github.com/JeanMeche
angular:mainhttps://github.com/angular/angular/tree/main
JeanMeche:container-classhttps://github.com/JeanMeche/angular/tree/container-class
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Sep 18, 2026https://github.com/angular/angular/pull/70808#issue-5499434815
Please reload this pagehttps://github.com/angular/angular/pull/70808
Please reload this pagehttps://github.com/angular/angular/pull/70808
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
detected: feature https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22detected%3A%20feature%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
Sep 18, 2026https://github.com/angular/angular/pull/70808#event-31388548878
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Sep 18, 2026https://github.com/angular/angular/pull/70808#event-31388551573
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
force-pushedhttps://github.com/angular/angular/compare/e44228df66679570dac5859c54fe517346794372..28ac0eefee3169fc6e34597f9cda23ed84b3a00f
e44228dhttps://github.com/angular/angular/commit/e44228df66679570dac5859c54fe517346794372
28ac0eehttps://github.com/angular/angular/commit/28ac0eefee3169fc6e34597f9cda23ed84b3a00f
Compare https://github.com/angular/angular/compare/e44228df66679570dac5859c54fe517346794372..28ac0eefee3169fc6e34597f9cda23ed84b3a00f
September 18, 2026 21:00https://github.com/angular/angular/pull/70808#event-31418285861
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
state: blocked on G3 cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%20on%20G3%20cleanup%22
detected: feature https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22detected%3A%20feature%22
Sep 22, 2026https://github.com/angular/angular/pull/70808#event-31635167601
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
force-pushedhttps://github.com/angular/angular/compare/ab41f11b5b6da5e73738f7a0c069b76809c82d5e..5936f8312970f1a2209e0faf766644018fd6001e
ab41f11https://github.com/angular/angular/commit/ab41f11b5b6da5e73738f7a0c069b76809c82d5e
5936f83https://github.com/angular/angular/commit/5936f8312970f1a2209e0faf766644018fd6001e
Compare https://github.com/angular/angular/compare/ab41f11b5b6da5e73738f7a0c069b76809c82d5e..5936f8312970f1a2209e0faf766644018fd6001e
September 22, 2026 22:12https://github.com/angular/angular/pull/70808#event-31635298958
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
detected: feature https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22detected%3A%20feature%22
Sep 22, 2026https://github.com/angular/angular/pull/70808#event-31635375449
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
mattrbeckhttps://github.com/mattrbeck
September 22, 2026 22:25https://github.com/angular/angular/pull/70808#event-31635970234
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
September 22, 2026 22:25https://github.com/angular/angular/pull/70808#event-31635971812
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
force-pushedhttps://github.com/angular/angular/compare/40b04169ad01e304671403678ca57b7ef25931d8..a45b5fdaa93ae76c5990c3a59466f0db5b10ae4a
40b0416https://github.com/angular/angular/commit/40b04169ad01e304671403678ca57b7ef25931d8
a45b5fdhttps://github.com/angular/angular/commit/a45b5fdaa93ae76c5990c3a59466f0db5b10ae4a
Compare https://github.com/angular/angular/compare/40b04169ad01e304671403678ca57b7ef25931d8..a45b5fdaa93ae76c5990c3a59466f0db5b10ae4a
September 22, 2026 22:52https://github.com/angular/angular/pull/70808#event-31637196833
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Sep 22, 2026https://github.com/angular/angular/pull/70808#event-31637269121
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
force-pushedhttps://github.com/angular/angular/compare/a45b5fdaa93ae76c5990c3a59466f0db5b10ae4a..cb2b479dd2cc3e25ac0624a9f479eefaec1181e1
a45b5fdhttps://github.com/angular/angular/commit/a45b5fdaa93ae76c5990c3a59466f0db5b10ae4a
cb2b479https://github.com/angular/angular/commit/cb2b479dd2cc3e25ac0624a9f479eefaec1181e1
Compare https://github.com/angular/angular/compare/a45b5fdaa93ae76c5990c3a59466f0db5b10ae4a..cb2b479dd2cc3e25ac0624a9f479eefaec1181e1
September 23, 2026 00:18https://github.com/angular/angular/pull/70808#event-31640725374
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Sep 23, 2026https://github.com/angular/angular/pull/70808#event-31714229242
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
force-pushedhttps://github.com/angular/angular/compare/cb2b479dd2cc3e25ac0624a9f479eefaec1181e1..5fe7be167f2f0a022131a048340c218473a000be
cb2b479https://github.com/angular/angular/commit/cb2b479dd2cc3e25ac0624a9f479eefaec1181e1
5fe7be1https://github.com/angular/angular/commit/5fe7be167f2f0a022131a048340c218473a000be
Compare https://github.com/angular/angular/compare/cb2b479dd2cc3e25ac0624a9f479eefaec1181e1..5fe7be167f2f0a022131a048340c218473a000be
September 23, 2026 22:30https://github.com/angular/angular/pull/70808#event-31714284554
https://github.com/mattrbeck
mattrbeckhttps://github.com/mattrbeck
Sep 28, 2026 https://github.com/angular/angular/pull/70808#pullrequestreview-5342839536
View reviewed changes https://github.com/angular/angular/pull/70808/files
mattrbeckhttps://github.com/mattrbeck
https://github.com/angular/angular/pull/70808#pullrequestreview-5342839536
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70808
packages/compiler/src/render3/r3_template_transform.tshttps://github.com/angular/angular/pull/70808/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
mattrbeckhttps://github.com/mattrbeck
Sep 28, 2026https://github.com/angular/angular/pull/70808#discussion_r4125544816
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70808
packages/compiler/src/render3/r3_template_transform.tshttps://github.com/angular/angular/pull/70808/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
Please reload this pagehttps://github.com/angular/angular/pull/70808
packages/compiler/src/render3/r3_template_transform.tshttps://github.com/angular/angular/pull/70808/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
Please reload this pagehttps://github.com/angular/angular/pull/70808
packages/compiler/src/render3/r3_template_transform.tshttps://github.com/angular/angular/pull/70808/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
Please reload this pagehttps://github.com/angular/angular/pull/70808
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Nov 5, 2026 https://github.com/angular/angular/pull/70808#ref-pullrequest-6227003262
refactor(compiler): check that ng-container don't have class bindings #71844 https://github.com/angular/angular/pull/71844
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
state: blocked on G3 cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%20on%20G3%20cleanup%22
Nov 5, 2026https://github.com/angular/angular/pull/70808#event-35262868457
JeanMechehttps://github.com/JeanMeche
Nov 7, 2026 https://github.com/angular/angular/pull/70808#ref-commit-1344b06
https://github.com/JeanMeche
refactor(compiler): check that ng-container don't have class bindingshttps://github.com/JeanMeche/angular/commit/1344b06eb75ec8a36e21c03ed0906d3009ade8a4
1344b06https://github.com/JeanMeche/angular/commit/1344b06eb75ec8a36e21c03ed0906d3009ade8a4
angular#70808https://github.com/angular/angular/pull/70808
https://github.com/SkyZeroZx
SkyZeroZxhttps://github.com/SkyZeroZx
Nov 8, 2026 https://github.com/angular/angular/pull/70808#ref-issue-6273351105
Report bindings that have no effect on ng-container, ng-template, and ng-content #71881 https://github.com/angular/angular/issues/71881
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Nov 8, 2026 https://github.com/angular/angular/pull/70808#ref-pullrequest-6273352402
feat(compiler-cli): add ignoredBinding check #71882 https://github.com/angular/angular/pull/71882
https://github.com/Flarette
Flarettehttps://github.com/Flarette
Nov 8, 2026https://github.com/angular/angular/pull/70808#issuecomment-6726708528
#71881https://github.com/angular/angular/issues/71881
#71882https://github.com/angular/angular/pull/71882
#71884https://github.com/angular/angular/pull/71884
#71844https://github.com/angular/angular/pull/71844
#71882https://github.com/angular/angular/pull/71882
#71884https://github.com/angular/angular/pull/71884
Please reload this pagehttps://github.com/angular/angular/pull/70808
thePunderWomanhttps://github.com/thePunderWoman
Nov 10, 2026 https://github.com/angular/angular/pull/70808#ref-commit-5cd01d6
https://github.com/JeanMeche
https://github.com/thePunderWoman
refactor(compiler): check that ng-container don't have class bindingshttps://github.com/angular/angular/commit/5cd01d6d8e4545ef513dbf743084ddecb4d20083
5cd01d6https://github.com/angular/angular/commit/5cd01d6d8e4545ef513dbf743084ddecb4d20083
#70808https://github.com/angular/angular/pull/70808
thePunderWomanhttps://github.com/thePunderWoman
Nov 10, 2026 https://github.com/angular/angular/pull/70808#ref-commit-85e1962
https://github.com/JeanMeche
https://github.com/thePunderWoman
refactor(compiler): check that ng-container don't have class bindingshttps://github.com/angular/angular/commit/85e1962814a8aa3abe01046cb7734e00d40b33fc
85e1962https://github.com/angular/angular/commit/85e1962814a8aa3abe01046cb7734e00d40b33fc
#70808https://github.com/angular/angular/pull/70808
5cd01d6https://github.com/angular/angular/commit/5cd01d6d8e4545ef513dbf743084ddecb4d20083
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
breaking changes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
Nov 11, 2026https://github.com/angular/angular/pull/70808#event-35748638338
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Backloghttps://github.com/angular/angular/milestone/82
v23 candidateshttps://github.com/angular/angular/milestone/141
Nov 11, 2026https://github.com/angular/angular/pull/70808#event-35748647509
https://github.com/JeanMeche
feat(compiler): check that ng-container don't have class bindingshttps://github.com/angular/angular/pull/70808/commits/a77c758ad7d26029f0529565e1943c423562e630
a77c758https://github.com/angular/angular/pull/70808/commits/a77c758ad7d26029f0529565e1943c423562e630
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
force-pushedhttps://github.com/angular/angular/compare/5fe7be167f2f0a022131a048340c218473a000be..a77c758ad7d26029f0529565e1943c423562e630
5fe7be1https://github.com/angular/angular/commit/5fe7be167f2f0a022131a048340c218473a000be
a77c758https://github.com/angular/angular/commit/a77c758ad7d26029f0529565e1943c423562e630
Compare https://github.com/angular/angular/compare/5fe7be167f2f0a022131a048340c218473a000be..a77c758ad7d26029f0529565e1943c423562e630
November 20, 2026 09:59https://github.com/angular/angular/pull/70808#event-36755570335
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70808
https://github.com/mattrbeck
mattrbeck https://github.com/mattrbeck
https://github.com/angular/angular/pull/70808/files/5fe7be167f2f0a022131a048340c218473a000be
Please reload this pagehttps://github.com/angular/angular/pull/70808
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
breaking changes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
detected: feature https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22detected%3A%20feature%22
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
v23 candidates https://github.com/angular/angular/milestone/141
Please reload this pagehttps://github.com/angular/angular/pull/70808
https://github.com/JeanMeche
https://github.com/Flarette
https://github.com/mattrbeck
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.