René's URL Explorer Experiment


Title: fix(common): let NgOptimizedImage pass a [srcset] binding through when srcset optimization is disabled by arturovt · Pull Request #70532 · angular/angular · GitHub

Open Graph Title: fix(common): let NgOptimizedImage pass a [srcset] binding through when srcset optimization is disabled by arturovt · Pull Request #70532 · angular/angular

X Title: fix(common): let NgOptimizedImage pass a [srcset] binding through when srcset optimization is disabled by arturovt · Pull Request #70532 · angular/angular

Description: NgOptimizedImage declares a srcset input, so a [srcset]="..." binding is captured by the directive and never reaches the element. The directive only reads that input for a conflict check, so with disableOptimizedSrcset the image ended up with no srcset at all. The only way to set one was [attr.srcset]. Now, when disableOptimizedSrcset is set and the directive isn't generating its own srcset, the value from the [srcset] binding is written back to the element. Fixes #49335

Open Graph Description: NgOptimizedImage declares a srcset input, so a [srcset]="..." binding is captured by the directive and never reaches the <img> element. The directive only reads that input for a con...

X Description: NgOptimizedImage declares a srcset input, so a [srcset]=&quot;...&quot; binding is captured by the directive and never reaches the &lt;img&gt; element. The directive only reads that...

Opengraph URL: https://github.com/angular/angular/pull/70532

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dd16e53a-d2cc-9ca2-e2dd-ce471c817556
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4D2:1F8B56:8E22E7:C929B8:6AFDCA40
html-safe-noncea5fc5565fdbca471e0c137f4eff7664e11693b63b396102d7cfe3328ab9ffa4a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEQyOjFGOEI1Njo4RTIyRTc6QzkyOUI4OjZBRkRDQTQwIiwidmlzaXRvcl9pZCI6Ijg5ODE1MjcxMjQ2MTEyODc2MTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8cb3f7fa636f02c63aa8d6c19ae332f34d01d38b5fb1226721e55c55a677b631
hovercard-subject-tagpull_request:4426216816
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/70532/files
twitter:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
og:image:altNgOptimizedImage declares a srcset input, so a [srcset]="..." binding is captured by the directive and never reaches the <img> element. The directive only reads that input for a con...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9ab00cc3b4fa90bbd3da70765dd38efc23cfa9d9b0930e41feea2bf67f60ecaf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1b795ba060b92691fc16c5a12cf2bf95e83432b4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/70532/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70532%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70532%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/70532/files
Reloadhttps://github.com/angular/angular/pull/70532/files
Reloadhttps://github.com/angular/angular/pull/70532/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues833 (833)https://github.com/angular/angular/issues
Pull requests126 (126)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
arturovt:fix/ngoptimizedimage-disabled-srcset-bindinghttps://github.com/arturovt/angular/tree/fix/ngoptimizedimage-disabled-srcset-binding
Conversation 4 https://github.com/angular/angular/pull/70532
Commits 1 https://github.com/angular/angular/pull/70532/commits
Checks 24 https://github.com/angular/angular/pull/70532/checks
Files changed https://github.com/angular/angular/pull/70532/files
Please reload this pagehttps://github.com/angular/angular/pull/70532/files
fix(common): let NgOptimizedImage pass a [srcset] binding through when srcset optimization is disabled https://github.com/angular/angular/pull/70532/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/70532/files
c840055 fix(common): let NgOptimizedImage pass a [srcset] binding through whe… arturovt Sep 1, 2026 https://github.com/angular/angular/pull/70532/commits/c84005521d473a290c4c7430407774cc11630d1f
Clear filters https://github.com/angular/angular/pull/70532/files
Please reload this pagehttps://github.com/angular/angular/pull/70532/files
Please reload this pagehttps://github.com/angular/angular/pull/70532/files
ng_optimized_image.ts https://github.com/angular/angular/pull/70532/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
ng_optimized_image_spec.ts https://github.com/angular/angular/pull/70532/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
packages/common/src/directives/ng_optimized_image/ng_optimized_image.tshttps://github.com/angular/angular/pull/70532/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
View file https://github.com/arturovt/angular/blob/c84005521d473a290c4c7430407774cc11630d1f/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/70532/{{ revealButtonHref }}
https://github.com/angular/angular/pull/70532/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/70532/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/70532/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
JeanMechehttps://github.com/JeanMeche
Sep 18, 2026https://github.com/angular/angular/pull/70532/files#r4046471459
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70532/files
arturovthttps://github.com/arturovt
Sep 18, 2026https://github.com/angular/angular/pull/70532/files#r4046690171
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/70532/files
https://github.com/angular/angular/pull/70532/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
packages/common/test/directives/ng_optimized_image_spec.tshttps://github.com/angular/angular/pull/70532/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
View file https://github.com/arturovt/angular/blob/c84005521d473a290c4c7430407774cc11630d1f/packages/common/test/directives/ng_optimized_image_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/70532/{{ revealButtonHref }}
https://github.com/angular/angular/pull/70532/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
https://github.com/angular/angular/pull/70532/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
Please reload this pagehttps://github.com/angular/angular/pull/70532/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.