René's URL Explorer Experiment


Title: fix(core): default the Component decorator to OnPush change detection in JIT by ValeraGin · Pull Request #70261 · angular/angular · GitHub

Open Graph Title: fix(core): default the Component decorator to OnPush change detection in JIT by ValeraGin · Pull Request #70261 · angular/angular

X Title: fix(core): default the Component decorator to OnPush change detection in JIT by ValeraGin · Pull Request #70261 · angular/angular

Description: What's the problem @Component() compiled in JIT (TestBed, Jest, etc.) still defaults changeDetection to Eager. The AOT compiler already defaults to OnPush — that changed in #67687. So a component with no changeDetection set behaves as OnPush in a real build but as Eager under TestBed. Tests don't exercise the same strategy the app ships with. Found this while removing "redundant" explicit OnPush from a bunch of components after upgrading to v22 — one test broke, and only in JIT. Why it's still there packages/core/src/metadata/directives.ts line 682 was never touched by #67687. It still hardcodes: (c: Component = {}) => ({changeDetection: ChangeDetectionStrategy.Eager, ...c}), There's actually a paper trail for this. The very TODO that anticipated the fix: - // TODO(jeanmeche): remove the ts-ignore when OnPush is the default - // @ts-ignore was removed in cf3b7fe489, the same day #67687 merged — but only the comment/ts-ignore was removed, not the value it was pointing at. It's been Eager ever since (checked main and the latest published 22.1.2). The fix One line: Eager → OnPush in the decorator default, plus a regression test asserting getComponentDef(...).onPush for a component with no explicit changeDetection. I couldn't run the full internal test suite here (no Bazel setup on my end), so this may well surface spec files elsewhere in the repo that quietly relied on the old JIT default — happy to help track those down if CI turns anything up.

Open Graph Description: What's the problem @Component() compiled in JIT (TestBed, Jest, etc.) still defaults changeDetection to Eager. The AOT compiler already defaults to OnPush — that changed in #67687. So a compone...

X Description: What's the problem @Component() compiled in JIT (TestBed, Jest, etc.) still defaults changeDetection to Eager. The AOT compiler already defaults to OnPush — that changed in #67687. So a com...

Opengraph URL: https://github.com/angular/angular/pull/70261

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:19b24f27-6e0d-bedf-8553-4ac1c3185635
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BA8:14700E:163506E:1C2CD54:6B0132E4
html-safe-nonce50846a12effbb1c971f755095633de3fe630c7798069443da88e778c22dc4a57
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkE4OjE0NzAwRToxNjM1MDZFOjFDMkNENTQ6NkIwMTMyRTQiLCJ2aXNpdG9yX2lkIjoiNDc4NzgyNDY4NjMyMDkyMzM2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac87643e2d02161c24e2275198514d2391bc8c6f84cc3098c43baf3aacc4900a4e
hovercard-subject-tagpull_request:4309228888
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/70261/files
twitter:imagehttps://avatars.githubusercontent.com/u/5599493?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5599493?s=400&v=4
og:image:altWhat's the problem @Component() compiled in JIT (TestBed, Jest, etc.) still defaults changeDetection to Eager. The AOT compiler already defaults to OnPush — that changed in #67687. So a compone...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/70261/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70261%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F70261%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/70261/files
Reloadhttps://github.com/angular/angular/pull/70261/files
Reloadhttps://github.com/angular/angular/pull/70261/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ValeraGinhttps://github.com/ValeraGin
angular:mainhttps://github.com/angular/angular/tree/main
ValeraGin:fix-jit-component-default-changedetectionhttps://github.com/ValeraGin/angular/tree/fix-jit-component-default-changedetection
Conversation 4 https://github.com/angular/angular/pull/70261
Commits 1 https://github.com/angular/angular/pull/70261/commits
Checks 12 https://github.com/angular/angular/pull/70261/checks
Files changed https://github.com/angular/angular/pull/70261/files
Please reload this pagehttps://github.com/angular/angular/pull/70261/files
fix(core): default the Component decorator to OnPush change detection in JIT https://github.com/angular/angular/pull/70261/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/70261/files
70c934d fix(core): default the Component decorator to OnPush change detection… ValeraGin Aug 18, 2026 https://github.com/angular/angular/pull/70261/commits/70c934dc4c41ec7bf1e6b55d0827a5dad3bdedfc
Clear filters https://github.com/angular/angular/pull/70261/files
Please reload this pagehttps://github.com/angular/angular/pull/70261/files
Please reload this pagehttps://github.com/angular/angular/pull/70261/files
directives.ts https://github.com/angular/angular/pull/70261/files#diff-7ea33bdd5c9d7178a09c9f6798a2bb22b1890d92a03202679709bc7790813259
change_detection_spec.ts https://github.com/angular/angular/pull/70261/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e
packages/core/src/metadata/directives.tshttps://github.com/angular/angular/pull/70261/files#diff-7ea33bdd5c9d7178a09c9f6798a2bb22b1890d92a03202679709bc7790813259
View file https://github.com/ValeraGin/angular/blob/70c934dc4c41ec7bf1e6b55d0827a5dad3bdedfc/packages/core/src/metadata/directives.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/70261/{{ revealButtonHref }}
https://github.com/angular/angular/pull/70261/files#diff-7ea33bdd5c9d7178a09c9f6798a2bb22b1890d92a03202679709bc7790813259
https://github.com/angular/angular/pull/70261/files#diff-7ea33bdd5c9d7178a09c9f6798a2bb22b1890d92a03202679709bc7790813259
packages/core/test/acceptance/change_detection_spec.tshttps://github.com/angular/angular/pull/70261/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e
View file https://github.com/ValeraGin/angular/blob/70c934dc4c41ec7bf1e6b55d0827a5dad3bdedfc/packages/core/test/acceptance/change_detection_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/70261/{{ revealButtonHref }}
https://github.com/angular/angular/pull/70261/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e
https://github.com/angular/angular/pull/70261/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e
https://github.com/angular/angular/pull/70261/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.