René's URL Explorer Experiment


Title: fix(core): preserve change detection strategy when overriding component by bethge · Pull Request #69731 · angular/angular · GitHub

Open Graph Title: fix(core): preserve change detection strategy when overriding component by bethge · Pull Request #69731 · angular/angular

X Title: fix(core): preserve change detection strategy when overriding component by bethge · Pull Request #69731 · angular/angular

Description: TestBed.overrideComponent previously caused JIT recompilation to overwrite a component's original ChangeDetectionStrategy. This ensures the component's existing ChangeDetectionStrategy is preserved when metadata overrides are applied. Disclaimer: Note that the root cause analysis of the bug and the solution were identified with the help of AI. I implemented the change, tests, and ran it against our codebase. The problem is in my opinion very much genuine but a different solution may be more appropriate. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? When a component without explicit changeDetection strategy is overridden with TestBed.overrideComponent, the change detection strategy changes from OnPush (default) to Eager. This causes a mismatch between prod and test component behavior. AI's explanation: When TestBed.overrideComponent is called on a component, the component is added to TestBed's pendingComponents queue, forcing runtime JIT recompilation (compileTypesSync()). During this JIT recompilation, TestBed reconstructs the component metadata. Previously, the metadata decorator resolution defaulted changeDetection to ChangeDetectionStrategy.Eager, overwriting the component's existing (ɵcmp) Change Detection Strategy. As a result, an overridden component whose pre-compiled definition used ChangeDetectionStrategy.OnPush would unexpectedly run with ChangeDetectionStrategy.Default (Eager) in tests. Issue Number: N/A What is the new behavior? When compiling component overrides in TestBed, the implicit ChangeDetectionStrategy (onPush property on the pre-compiled ɵcmp definition) is preserved. Does this PR introduce a breaking change? Yes No Note on potential behavioral impact: While this is a bugfix restoring expected component behavior during testing, it could affect existing tests if consumers unknowingly relied on TestBed.overrideComponent silently reverting an OnPush component to Eager (Default) change detection. No such issue was found across our codebase. Other information Revealed during migration: This issue was discovered when removing redundant changeDetection: ChangeDetectionStrategy.OnPush declarations across our codebase. Removing the explicit declaration caused existing tests using TestBed.overrideComponent to fail, revealing that the JIT override path was silently altering the component's runtime change detection behavior. Why eager by default: I don't know if the Component decorator definition was left as Eager after the OnPush-as-default migration on purpose or accidentally.

Open Graph Description: TestBed.overrideComponent previously caused JIT recompilation to overwrite a component's original ChangeDetectionStrategy. This ensures the component's existing ChangeDetectionStrategy is p...

X Description: TestBed.overrideComponent previously caused JIT recompilation to overwrite a component's original ChangeDetectionStrategy. This ensures the component's existing ChangeDetectionStrat...

Opengraph URL: https://github.com/angular/angular/pull/69731

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:19d3f343-d683-e95f-e278-661fc593da8b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA89E:17FB7:CF4DE0:105F5A9:6B0138A6
html-safe-nonce46ef12ca04b5fd61f127c00fc41d135e2d1b0357b4ac965b12fdbef42050fbc4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODlFOjE3RkI3OkNGNERFMDoxMDVGNUE5OjZCMDEzOEE2IiwidmlzaXRvcl9pZCI6Ijg0MTk1MTA3Mjk1NzY2MjYzNDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac93cd5d3cda3e7d1d18c0c8d08ef6990c95555858a6b18a64db269d970dedf368
hovercard-subject-tagpull_request:4029510040
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/69731/files
twitter:imagehttps://avatars.githubusercontent.com/u/522575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/522575?s=400&v=4
og:image:altTestBed.overrideComponent previously caused JIT recompilation to overwrite a component's original ChangeDetectionStrategy. This ensures the component's existing ChangeDetectionStrategy is p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/69731/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F69731%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F69731%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/69731/files
Reloadhttps://github.com/angular/angular/pull/69731/files
Reloadhttps://github.com/angular/angular/pull/69731/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
bethgehttps://github.com/bethge
angular:mainhttps://github.com/angular/angular/tree/main
bethge:fix-component-overridehttps://github.com/bethge/angular/tree/fix-component-override
Conversation 2 https://github.com/angular/angular/pull/69731
Commits 1 https://github.com/angular/angular/pull/69731/commits
Checks 21 https://github.com/angular/angular/pull/69731/checks
Files changed https://github.com/angular/angular/pull/69731/files
Please reload this pagehttps://github.com/angular/angular/pull/69731/files
fix(core): preserve change detection strategy when overriding component https://github.com/angular/angular/pull/69731/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/69731/files
5f4a8b1 fix(core): preserve change detection strategy when overriding component bethge Jul 10, 2026 https://github.com/angular/angular/pull/69731/commits/5f4a8b182ba22708675f1caf1dedd4522f6485f6
Clear filters https://github.com/angular/angular/pull/69731/files
Please reload this pagehttps://github.com/angular/angular/pull/69731/files
Please reload this pagehttps://github.com/angular/angular/pull/69731/files
directives.ts https://github.com/angular/angular/pull/69731/files#diff-7ea33bdd5c9d7178a09c9f6798a2bb22b1890d92a03202679709bc7790813259
test_bed_spec.ts https://github.com/angular/angular/pull/69731/files#diff-2b74cb323472e02f47739cfe2b19c2125c635071fa1bfde933af8eee56cee78b
packages/core/src/metadata/directives.tshttps://github.com/angular/angular/pull/69731/files#diff-7ea33bdd5c9d7178a09c9f6798a2bb22b1890d92a03202679709bc7790813259
View file https://github.com/bethge/angular/blob/5f4a8b182ba22708675f1caf1dedd4522f6485f6/packages/core/src/metadata/directives.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/69731/{{ revealButtonHref }}
https://github.com/angular/angular/pull/69731/files#diff-7ea33bdd5c9d7178a09c9f6798a2bb22b1890d92a03202679709bc7790813259
https://github.com/angular/angular/pull/69731/files#diff-7ea33bdd5c9d7178a09c9f6798a2bb22b1890d92a03202679709bc7790813259
packages/core/test/test_bed_spec.tshttps://github.com/angular/angular/pull/69731/files#diff-2b74cb323472e02f47739cfe2b19c2125c635071fa1bfde933af8eee56cee78b
View file https://github.com/bethge/angular/blob/5f4a8b182ba22708675f1caf1dedd4522f6485f6/packages/core/test/test_bed_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/69731/{{ revealButtonHref }}
https://github.com/angular/angular/pull/69731/files#diff-2b74cb323472e02f47739cfe2b19c2125c635071fa1bfde933af8eee56cee78b
https://github.com/angular/angular/pull/69731/files#diff-2b74cb323472e02f47739cfe2b19c2125c635071fa1bfde933af8eee56cee78b
Please reload this pagehttps://github.com/angular/angular/pull/69731/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.