René's URL Explorer Experiment


Title: fix(router): pass correct component to canDeactivate for named outlets in componentless parent routes by arturovt · Pull Request #69591 · angular/angular · GitHub

Open Graph Title: fix(router): pass correct component to canDeactivate for named outlets in componentless parent routes by arturovt · Pull Request #69591 · angular/angular

X Title: fix(router): pass correct component to canDeactivate for named outlets in componentless parent routes by arturovt · Pull Request #69591 · angular/angular

Description: When a componentless parent route has children rendered into a named outlet (e.g. outlet: 'inner'), the canDeactivate guard received null as the component argument instead of the actual component instance. The bug was in deactivateRouteAndItsChildren: for componentless routes, each child was passed the same context inherited from the parent lookup, which was null when the parent component only registered a named outlet. The children's actual outlet contexts were never consulted. The fix adds a parentContexts: ChildrenOutletContexts | null parameter so that for componentless routes, each child is looked up by its own outlet name in parentContexts (e.g. parentContexts.getContext('inner')). For component routes, context.children is passed as the new parentContexts on recursion, ensuring correct context resolution across component boundaries. This re-addresses #34614. A previous fix (#36302) was reverted because it passed parentContexts unchanged through component boundaries; this fix updates parentContexts to context.children when descending into a component route, preventing the wrong contexts from propagating into deeper componentless levels. Fixes #34614

Open Graph Description: When a componentless parent route has children rendered into a named outlet (e.g. outlet: 'inner'), the canDeactivate guard received null as the component argument instead of the actual com...

X Description: When a componentless parent route has children rendered into a named outlet (e.g. outlet: 'inner'), the canDeactivate guard received null as the component argument instead of the ac...

Opengraph URL: https://github.com/angular/angular/pull/69591

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f21fb939-c401-db5e-8188-4de40c6b9e38
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC9A:1F2D:117AD2F:1616162:6B015156
html-safe-nonceaeea404358b15fc2319eaa227a7950b27d806ac7c1b6ac68f770c2bd860dc4dc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzlBOjFGMkQ6MTE3QUQyRjoxNjE2MTYyOjZCMDE1MTU2IiwidmlzaXRvcl9pZCI6IjcyNDExNDE2ODExNzk5MzkxNTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1cc83dbca1a1bc20920238a12d87b26aa62cfb22307213ccbaa0ada6a4d1dbe7
hovercard-subject-tagpull_request:3965438214
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/69591/files
twitter:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
og:image:altWhen a componentless parent route has children rendered into a named outlet (e.g. outlet: 'inner'), the canDeactivate guard received null as the component argument instead of the actual com...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/69591/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F69591%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F69591%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/69591/files
Reloadhttps://github.com/angular/angular/pull/69591/files
Reloadhttps://github.com/angular/angular/pull/69591/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
thePunderWomanhttps://github.com/thePunderWoman
angular:mainhttps://github.com/angular/angular/tree/main
arturovt:fix/router_34614https://github.com/arturovt/angular/tree/fix/router_34614
Conversation 5 https://github.com/angular/angular/pull/69591
Commits 1 https://github.com/angular/angular/pull/69591/commits
Checks 19 https://github.com/angular/angular/pull/69591/checks
Files changed https://github.com/angular/angular/pull/69591/files
Please reload this pagehttps://github.com/angular/angular/pull/69591/files
fix(router): pass correct component to canDeactivate for named outlets in componentless parent routes https://github.com/angular/angular/pull/69591/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/69591/files
5645428 fix(router): pass correct component to canDeactivate for named outlet… arturovt Jun 30, 2026 https://github.com/angular/angular/pull/69591/commits/5645428baccb770a9a54cc38fd5ba04fc7155f97
Clear filters https://github.com/angular/angular/pull/69591/files
Please reload this pagehttps://github.com/angular/angular/pull/69591/files
Please reload this pagehttps://github.com/angular/angular/pull/69591/files
preactivation.ts https://github.com/angular/angular/pull/69591/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
guards.spec.ts https://github.com/angular/angular/pull/69591/files#diff-bafcdf9ee489059c669e73c1779e0168aef6b122af0a7e06a877f2339a9b3294
packages/router/src/utils/preactivation.tshttps://github.com/angular/angular/pull/69591/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
View file https://github.com/arturovt/angular/blob/5645428baccb770a9a54cc38fd5ba04fc7155f97/packages/router/src/utils/preactivation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/69591/{{ revealButtonHref }}
https://github.com/angular/angular/pull/69591/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/69591/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/69591/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/69591/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/69591/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/69591/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
packages/router/test/integration/guards.spec.tshttps://github.com/angular/angular/pull/69591/files#diff-bafcdf9ee489059c669e73c1779e0168aef6b122af0a7e06a877f2339a9b3294
View file https://github.com/arturovt/angular/blob/5645428baccb770a9a54cc38fd5ba04fc7155f97/packages/router/test/integration/guards.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/69591/{{ revealButtonHref }}
https://github.com/angular/angular/pull/69591/files#diff-bafcdf9ee489059c669e73c1779e0168aef6b122af0a7e06a877f2339a9b3294
https://github.com/angular/angular/pull/69591/files#diff-bafcdf9ee489059c669e73c1779e0168aef6b122af0a7e06a877f2339a9b3294
https://github.com/angular/angular/pull/69591/files#diff-bafcdf9ee489059c669e73c1779e0168aef6b122af0a7e06a877f2339a9b3294
SkyZeroZxhttps://github.com/SkyZeroZx
Aug 14, 2026https://github.com/angular/angular/pull/69591/files#r3786627173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/69591/files
arturovthttps://github.com/arturovt
Aug 14, 2026https://github.com/angular/angular/pull/69591/files#r3786720832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/69591/files
https://github.com/angular/angular/pull/69591/files#diff-bafcdf9ee489059c669e73c1779e0168aef6b122af0a7e06a877f2339a9b3294
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.