René's URL Explorer Experiment


Title: fix(router): pass correct component to canDeactivate for named outlets in componentless parent routes by arturovt · Pull Request #69591 · angular/angular · GitHub

Open Graph Title: fix(router): pass correct component to canDeactivate for named outlets in componentless parent routes by arturovt · Pull Request #69591 · angular/angular

X Title: fix(router): pass correct component to canDeactivate for named outlets in componentless parent routes by arturovt · Pull Request #69591 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: When a componentless parent route has children rendered into a named outlet (e.g. outlet: 'inner'), the canDeactivate guard received null as the component argument instead of the actual com...

X Description: When a componentless parent route has children rendered into a named outlet (e.g. outlet: 'inner'), the canDeactivate guard received null as the component argument instead of the ac...

Opengraph URL: https://github.com/angular/angular/pull/69591

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fd1f4146-586f-0a54-0702-53c1c17edd73
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95C0:DB09F:1348180:189C4E6:6B012906
html-safe-nonce020f121ca536a282781979f9ef75416dc51d2207ebaf4136a44d5369c70a8f72
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUMwOkRCMDlGOjEzNDgxODA6MTg5QzRFNjo2QjAxMjkwNiIsInZpc2l0b3JfaWQiOiI3MDMzMDc3OTQzMzQ5ODgxMDk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac97ef746c7b028e2495ebb81bc48f994d64b366b4035b430a1bdcedc611c215df
hovercard-subject-tagpull_request:3965438214
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/69591/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1ad6a578b0a5d5ea713dbedcf4a1f1f7379dc495aeda5e4db223348e9e62ae6/angular/angular/pull/69591
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1ad6a578b0a5d5ea713dbedcf4a1f1f7379dc495aeda5e4db223348e9e62ae6/angular/angular/pull/69591
og:image:altWhen a componentless parent route has children rendered into a named outlet (e.g. outlet: 'inner'), the canDeactivate guard received null as the component argument instead of the actual com...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearturovt
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/69591#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F69591
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F69591
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/69591
Reloadhttps://github.com/angular/angular/pull/69591
Reloadhttps://github.com/angular/angular/pull/69591
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
thePunderWomanhttps://github.com/thePunderWoman
angular:mainhttps://github.com/angular/angular/tree/main
arturovt:fix/router_34614https://github.com/arturovt/angular/tree/fix/router_34614
Conversationhttps://github.com/angular/angular/pull/69591
Commits1 (1)https://github.com/angular/angular/pull/69591/commits
Checkshttps://github.com/angular/angular/pull/69591/checks
Files changedhttps://github.com/angular/angular/pull/69591/files
fix(router): pass correct component to canDeactivate for named outlets in componentless parent routeshttps://github.com/angular/angular/pull/69591#top
thePunderWomanhttps://github.com/thePunderWoman
angular:mainhttps://github.com/angular/angular/tree/main
arturovt:fix/router_34614https://github.com/arturovt/angular/tree/fix/router_34614
https://github.com/arturovt
arturovthttps://github.com/arturovt
Jun 30, 2026https://github.com/angular/angular/pull/69591#issue-4779415504
#34614https://github.com/angular/angular/issues/34614
#36302https://github.com/angular/angular/pull/36302
#34614https://github.com/angular/angular/issues/34614
Please reload this pagehttps://github.com/angular/angular/pull/69591
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
atscotthttps://github.com/atscott
June 30, 2026 18:25https://github.com/angular/angular/pull/69591#event-27393272588
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
Jun 30, 2026https://github.com/angular/angular/pull/69591#event-27393276678
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Jun 30, 2026https://github.com/angular/angular/pull/69591#event-27393277958
https://github.com/atscott
atscotthttps://github.com/atscott
Aug 14, 2026 https://github.com/angular/angular/pull/69591#pullrequestreview-4940481996
View reviewed changes https://github.com/angular/angular/pull/69591/files/5645428baccb770a9a54cc38fd5ba04fc7155f97
https://github.com/atscott
atscotthttps://github.com/atscott
requires: TGP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22requires%3A%20TGP%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Aug 14, 2026https://github.com/angular/angular/pull/69591#event-29476707073
https://github.com/SkyZeroZx
SkyZeroZxhttps://github.com/SkyZeroZx
Aug 14, 2026 https://github.com/angular/angular/pull/69591#pullrequestreview-4940564915
View reviewed changes https://github.com/angular/angular/pull/69591/files
packages/router/test/integration/guards.spec.tshttps://github.com/angular/angular/pull/69591/files#diff-bafcdf9ee489059c669e73c1779e0168aef6b122af0a7e06a877f2339a9b3294
SkyZeroZxhttps://github.com/SkyZeroZx
Aug 14, 2026https://github.com/angular/angular/pull/69591#discussion_r3786627173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/69591
arturovthttps://github.com/arturovt
Aug 14, 2026https://github.com/angular/angular/pull/69591#discussion_r3786720832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/69591
https://github.com/atscott
atscotthttps://github.com/atscott
Aug 17, 2026https://github.com/angular/angular/pull/69591#issuecomment-5318396724
Please reload this pagehttps://github.com/angular/angular/pull/69591
TGPhttps://fusion2.corp.google.com/presubmit/964828822/OCL:964828822:BASE:965998669:1786982371725:facf1284/targets
Please reload this pagehttps://github.com/angular/angular/pull/69591
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Aug 17, 2026https://github.com/angular/angular/pull/69591#event-29573523243
https://github.com/thePunderWoman
thePunderWomanhttps://github.com/thePunderWoman
Aug 18, 2026https://github.com/angular/angular/pull/69591#event-29639862778
https://github.com/thePunderWoman
thePunderWomanhttps://github.com/thePunderWoman
Aug 18, 2026https://github.com/angular/angular/pull/69591#event-29639865525
https://github.com/arturovt
https://github.com/thePunderWoman
fix(router): pass correct component to canDeactivate for named outlet…https://github.com/angular/angular/pull/69591/commits/5645428baccb770a9a54cc38fd5ba04fc7155f97
5645428https://github.com/angular/angular/pull/69591/commits/5645428baccb770a9a54cc38fd5ba04fc7155f97
angular#34614https://github.com/angular/angular/issues/34614
angular#36302https://github.com/angular/angular/pull/36302
angular#34614https://github.com/angular/angular/issues/34614
https://github.com/thePunderWoman
thePunderWomanhttps://github.com/thePunderWoman
force-pushedhttps://github.com/angular/angular/compare/1f58f68d9cd34bcbfe824d9834cbe1c6924900e1..5645428baccb770a9a54cc38fd5ba04fc7155f97
1f58f68https://github.com/angular/angular/commit/1f58f68d9cd34bcbfe824d9834cbe1c6924900e1
5645428https://github.com/angular/angular/commit/5645428baccb770a9a54cc38fd5ba04fc7155f97
Compare https://github.com/angular/angular/compare/1f58f68d9cd34bcbfe824d9834cbe1c6924900e1..5645428baccb770a9a54cc38fd5ba04fc7155f97
August 18, 2026 20:14https://github.com/angular/angular/pull/69591#event-29643103886
https://github.com/thePunderWoman
thePunderWomanhttps://github.com/thePunderWoman
f1a4c85https://github.com/angular/angular/commit/f1a4c8521296d7414a1eab84352ca7db966f35e2
Aug 18, 2026https://github.com/angular/angular/pull/69591#event-29647948823
Please reload this pagehttps://github.com/angular/angular/pull/69591
https://github.com/thePunderWoman
thePunderWomanhttps://github.com/thePunderWoman
Aug 18, 2026https://github.com/angular/angular/pull/69591#issuecomment-5334624566
f1a4c85https://github.com/angular/angular/commit/f1a4c8521296d7414a1eab84352ca7db966f35e2
abe019dhttps://github.com/angular/angular/commit/abe019d5050532c87179cf46e840965e70a78b1b
Please reload this pagehttps://github.com/angular/angular/pull/69591
https://github.com/arturovt
arturovthttps://github.com/arturovt
August 19, 2026 05:39https://github.com/angular/angular/pull/69591#event-29662464312
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Oct 21, 2026https://github.com/angular/angular/pull/69591#issuecomment-6304792626
automatic conversation locking policyhttps://github.com/angular/angular/blob/f0fbced1c55bc8b8ed9df01cea99df42f3e7eae3/contributing-docs/auto-issue-locking.md
Please reload this pagehttps://github.com/angular/angular/pull/69591
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Oct 21, 2026https://github.com/angular/angular/pull/69591#event-33797826602
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F69591
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/69591/files/5645428baccb770a9a54cc38fd5ba04fc7155f97
https://github.com/SkyZeroZx
SkyZeroZx https://github.com/SkyZeroZx
https://github.com/angular/angular/pull/69591/files/1f58f68d9cd34bcbfe824d9834cbe1c6924900e1
Please reload this pagehttps://github.com/angular/angular/pull/69591
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
requires: TGP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22requires%3A%20TGP%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
incorrect component passed to canDeactivate guard https://github.com/angular/angular/issues/34614
Please reload this pagehttps://github.com/angular/angular/pull/69591
https://github.com/arturovt
https://github.com/atscott
https://github.com/thePunderWoman
https://github.com/SkyZeroZx
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.