René's URL Explorer Experiment


Title: fix(forms): parse numeric model values for signal forms by sonukapoor · Pull Request #68442 · angular/angular

X Title: fix(forms): parse numeric model values for signal forms element is bound via [formField] to a field with a number | null model, the native DOM always returns element.value as a string. This causes the model to silently receive a string (e.g. "42") instead of the expected number - a type mismatch that produces incorrect behaviour without any warning. Writing values back has a matching gap: null was coerced to the string "null" via the default element.value = value as string path, which does not clear the selection as intended, and NaN was coerced to "NaN" rather than clearing the selection. The solution is to extend getNativeControlValue with a select-one case that mirrors the existing numeric-model logic: when the current model type is number | null, parse the selected option's string value as a number, return null for an empty selection (element.value === ''), and produce a parse error if the option value is not a valid number. I also extended setNativeControlValue with a matching select-one case that converts null and NaN to '' (clearing the selection) and writes numeric values as String(value). And finally, I replaced the bare input.value = controlValue() as string assignment in the observeSelectMutations callback inside nativeControlCreate with a call to setNativeControlValue so that option-change re-sync also handles null and numeric values correctly. Fixes #68217.

Open Graph Description: When a <select> element is bound via [formField] to a field with a number | null model, the native DOM always returns element.value as a string. This causes the model to silently receive a st...

X Description: When a &lt;select&gt; element is bound via [formField] to a field with a number | null model, the native DOM always returns element.value as a string. This causes the model to silently rece...

Opengraph URL: https://github.com/angular/angular/pull/68442

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:62236e67-c243-1986-82de-897deed4b94d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6FA:7A60E:33F4121:42AB119:6B01DA85
html-safe-nonce96a2f552c25b04104c4111e4848860af6bb986a466638878731d569e58b410d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkZBOjdBNjBFOjMzRjQxMjE6NDJBQjExOTo2QjAxREE4NSIsInZpc2l0b3JfaWQiOiIxMjc3NTc5MzU3NzMzNDIzNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac55c0cd3a7932c006a21fb95debb95b2be59323a08c8cc0096d8a79601961f35c
hovercard-subject-tagpull_request:3602521530
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/68442/files
twitter:imagehttps://avatars.githubusercontent.com/u/59734?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/59734?s=400&v=4
og:image:altWhen a <select> element is bound via [formField] to a field with a number | null model, the native DOM always returns element.value as a string. This causes the model to silently receive a st...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/68442/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F68442%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F68442%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/68442/files
Reloadhttps://github.com/angular/angular/pull/68442/files
Reloadhttps://github.com/angular/angular/pull/68442/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
sonukapoorhttps://github.com/sonukapoor
angular:mainhttps://github.com/angular/angular/tree/main
sonukapoor:fix/signal-forms-select-numeric-68217https://github.com/sonukapoor/angular/tree/fix/signal-forms-select-numeric-68217
Conversation 6 https://github.com/angular/angular/pull/68442
Commits 2 https://github.com/angular/angular/pull/68442/commits
Checks 16 https://github.com/angular/angular/pull/68442/checks
Files changed https://github.com/angular/angular/pull/68442/files
Please reload this pagehttps://github.com/angular/angular/pull/68442/files
fix(forms): parse numeric model values for signal forms https://github.com/angular/angular/pull/68442/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/68442/files
c075ef1 fix(forms): parse numeric model values for signal forms https://github.com/angular/angular/pull/68442/commits/c075ef11738b6a948d877bcbcc9e4ff0782f5eee
b1b7ae4 fix(forms): widen signal forms https://github.com/angular/angular/pull/68442/commits/b1b7ae429490c22aac160265fd2ba83a0093e24f
Clear filters https://github.com/angular/angular/pull/68442/files
Please reload this pagehttps://github.com/angular/angular/pull/68442/files
Please reload this pagehttps://github.com/angular/angular/pull/68442/files
type_check_block_spec.ts https://github.com/angular/angular/pull/68442/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
signal_forms.ts https://github.com/angular/angular/pull/68442/files#diff-ff517a4f6887cc53bdcfcb74578baf9f17000bd5adff9b73e813152db3f1111d
control_native.ts https://github.com/angular/angular/pull/68442/files#diff-bd0f7ce9814a6de72b57bed5d77812236838037f5ddb3edaf439232f6062107a
native.ts https://github.com/angular/angular/pull/68442/files#diff-0852806438cb078388422e969b11ced46221d7c30c6aa449108f8b042127e5bc
select_numeric.spec.ts https://github.com/angular/angular/pull/68442/files#diff-35fe552fad696f96f4b1f2fe5e5436c99c5b3717e6f91a58dc5e53b504c9734c
packages/compiler-cli/src/ngtsc/typecheck/test/type_check_block_spec.tshttps://github.com/angular/angular/pull/68442/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
View file https://github.com/sonukapoor/angular/blob/b1b7ae429490c22aac160265fd2ba83a0093e24f/packages/compiler-cli/src/ngtsc/typecheck/test/type_check_block_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/68442/{{ revealButtonHref }}
https://github.com/angular/angular/pull/68442/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
https://github.com/angular/angular/pull/68442/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
packages/compiler/src/typecheck/ops/signal_forms.tshttps://github.com/angular/angular/pull/68442/files#diff-ff517a4f6887cc53bdcfcb74578baf9f17000bd5adff9b73e813152db3f1111d
View file https://github.com/sonukapoor/angular/blob/b1b7ae429490c22aac160265fd2ba83a0093e24f/packages/compiler/src/typecheck/ops/signal_forms.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/68442/{{ revealButtonHref }}
https://github.com/angular/angular/pull/68442/files#diff-ff517a4f6887cc53bdcfcb74578baf9f17000bd5adff9b73e813152db3f1111d
https://github.com/angular/angular/pull/68442/files#diff-ff517a4f6887cc53bdcfcb74578baf9f17000bd5adff9b73e813152db3f1111d
packages/forms/signals/src/directive/control_native.tshttps://github.com/angular/angular/pull/68442/files#diff-bd0f7ce9814a6de72b57bed5d77812236838037f5ddb3edaf439232f6062107a
View file https://github.com/sonukapoor/angular/blob/b1b7ae429490c22aac160265fd2ba83a0093e24f/packages/forms/signals/src/directive/control_native.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/68442/{{ revealButtonHref }}
https://github.com/angular/angular/pull/68442/files#diff-bd0f7ce9814a6de72b57bed5d77812236838037f5ddb3edaf439232f6062107a
https://github.com/angular/angular/pull/68442/files#diff-bd0f7ce9814a6de72b57bed5d77812236838037f5ddb3edaf439232f6062107a
packages/forms/signals/src/directive/native.tshttps://github.com/angular/angular/pull/68442/files#diff-0852806438cb078388422e969b11ced46221d7c30c6aa449108f8b042127e5bc
View file https://github.com/sonukapoor/angular/blob/b1b7ae429490c22aac160265fd2ba83a0093e24f/packages/forms/signals/src/directive/native.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/68442/{{ revealButtonHref }}
https://github.com/angular/angular/pull/68442/files#diff-0852806438cb078388422e969b11ced46221d7c30c6aa449108f8b042127e5bc
https://github.com/angular/angular/pull/68442/files#diff-0852806438cb078388422e969b11ced46221d7c30c6aa449108f8b042127e5bc
https://github.com/angular/angular/pull/68442/files#diff-0852806438cb078388422e969b11ced46221d7c30c6aa449108f8b042127e5bc
https://github.com/angular/angular/pull/68442/files#diff-0852806438cb078388422e969b11ced46221d7c30c6aa449108f8b042127e5bc
packages/forms/signals/test/web/select_numeric.spec.tshttps://github.com/angular/angular/pull/68442/files#diff-35fe552fad696f96f4b1f2fe5e5436c99c5b3717e6f91a58dc5e53b504c9734c
View file https://github.com/sonukapoor/angular/blob/b1b7ae429490c22aac160265fd2ba83a0093e24f/packages/forms/signals/test/web/select_numeric.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/68442/{{ revealButtonHref }}
JeanMechehttps://github.com/JeanMeche
Jul 11, 2026https://github.com/angular/angular/pull/68442/files#r3564571549
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/68442/files
sonukapoorhttps://github.com/sonukapoor
Jul 13, 2026https://github.com/angular/angular/pull/68442/files#r3572213918
Please reload this pagehttps://github.com/angular/angular/pull/68442/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/68442/files
JeanMechehttps://github.com/JeanMeche
Jul 13, 2026https://github.com/angular/angular/pull/68442/files#r3572270365
Please reload this pagehttps://github.com/angular/angular/pull/68442/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#64670https://github.com/angular/angular/issues/64670
Please reload this pagehttps://github.com/angular/angular/pull/68442/files
sonukapoorhttps://github.com/sonukapoor
Jul 13, 2026https://github.com/angular/angular/pull/68442/files#r3572332567
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#64670https://github.com/angular/angular/issues/64670
Please reload this pagehttps://github.com/angular/angular/pull/68442/files
Please reload this pagehttps://github.com/angular/angular/pull/68442/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.