Title: fix(platform-server): prevent SSRF bypasses via protocol-relative and backslash URLs by YLChen-007 · Pull Request #68166 · angular/angular · GitHub
Open Graph Title: fix(platform-server): prevent SSRF bypasses via protocol-relative and backslash URLs by YLChen-007 · Pull Request #68166 · angular/angular
X Title: fix(platform-server): prevent SSRF bypasses via protocol-relative and backslash URLs by YLChen-007 · Pull Request #68166 · angular/angular
Description: Description The parseUrl function in ServerPlatformLocation uses new URL(urlStr, origin) to parse incoming request URLs during SSR. Per the WHATWG URL specification, protocol-relative URLs (//evil.com) and backslash-prefixed URLs (/\evil.com) can override the hostname component of the base URL, causing the relativeUrlsTransformerInterceptorFn interceptor to redirect all subsequent HttpClient requests to attacker-controlled domains (Server-Side Request Forgery). Root Cause When a user sends GET //evil.com/ HTTP/1.1 or GET /\evil.com/ HTTP/1.1, Express passes req.url as //evil.com/ or /\evil.com/. This value flows into renderApplication({url: req.url}) → INITIAL_CONFIG → ServerPlatformLocation constructor → parseUrl(). The WHATWG URL constructor resolves these as hostname: 'evil.com', which the HTTP interceptor then uses to construct outbound request URLs. The backslash variant (/\evil.com) is particularly dangerous because it bypasses any WAF or filter rule that checks for // patterns — the input contains no double-slash, yet the URL parser normalizes backslash to forward slash for special schemes (http/https). Fix This PR adds validation in parseUrl() to detect when a relative URL input attempts to alter the origin's hostname, protocol, or port. When such a hijack attempt is detected, the parsed result is neutralized by reconstructing the URL using only the path components against the original origin, preventing hostname takeover while preserving the intended routing path. Security Impact SSRF to external domains: Attacker forces the SSR server to send HTTP requests to arbitrary hosts Filter bypass: The backslash variant defeats WAF rules and reverse proxy filters that only look for // patterns Affects standard Angular Universal deployments that pass req.url to renderApplication() Testing Added unit tests verifying that protocol-relative URL (//attacker.com/...) hostname hijack is neutralized Added unit tests verifying that backslash URL (/\attacker.com/...) hostname hijack is neutralized All 344 existing specs continue to pass Related CVE-2025-62427 (SSRF in @angular/ssr) Variant: Backslash URL bypass of double-slash filters
Open Graph Description: Description The parseUrl function in ServerPlatformLocation uses new URL(urlStr, origin) to parse incoming request URLs during SSR. Per the WHATWG URL specification, protocol-relative URLs (//evil....
X Description: Description The parseUrl function in ServerPlatformLocation uses new URL(urlStr, origin) to parse incoming request URLs during SSR. Per the WHATWG URL specification, protocol-relative URLs (//evil....
Opengraph URL: https://github.com/angular/angular/pull/68166
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5902c817-6fce-ef52-a972-fc56bf17c978 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AAF4:24F346:4FCE16:6E7E13:6AFDE70C |
| html-safe-nonce | 155679a06a14cbfd56fa85f62cb5cdaa361eadce25d827199ae40c9eefae8903 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUY0OjI0RjM0Njo0RkNFMTY6NkU3RTEzOjZBRkRFNzBDIiwidmlzaXRvcl9pZCI6IjE2NTY4MzYxNjc5NzIwMjIwMjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7e41ca30909820d9e03f60b6d2ea071826b5ac22d40fda6c29c17f0ea99ffac6 |
| hovercard-subject-tag | pull_request:3523153358 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/68166/files |
| twitter:image | https://avatars.githubusercontent.com/u/30854794?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/30854794?s=400&v=4 |
| og:image:alt | Description The parseUrl function in ServerPlatformLocation uses new URL(urlStr, origin) to parse incoming request URLs during SSR. Per the WHATWG URL specification, protocol-relative URLs (//evil.... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 91ef1a291a064ac31ac459ab3f75261dbdd924c41ea5bd027e591c5b46cc9ce7 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d62bc98ce2346f4006e4a2810e9e22f37e7e6422 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width