René's URL Explorer Experiment


Title: feat(compiler): support JS-valid unicode identifiers and improve unicode diagnostics in template parsing by kbrilla · Pull Request #67289 · angular/angular · GitHub

Open Graph Title: feat(compiler): support JS-valid unicode identifiers and improve unicode diagnostics in template parsing by kbrilla · Pull Request #67289 · angular/angular

X Title: feat(compiler): support JS-valid unicode identifiers and improve unicode diagnostics in template parsing by kbrilla · Pull Request #67289 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Feature What is the current behavior? In short: Component({ selector: 'app-child', imports: [], host: {'[style.color]': '我a的() ? "green" : "red"'}, template: `

{{ 我a的() ? 'Angular 🚀' : '😔' }}
`, styles: ``, }) export class UnicodeLibChild { 我a的 = input(); } will cause NG5002: Parser Error: Lexer Error: Unexpected character [我] Angular template expression lexing currently has gaps around Unicode handling and diagnostics quality: Non-ASCII identifier support needed stricter JS-valid semantics and stronger coverage. Some unexpected-character diagnostics could render replacement/ambiguous characters for surrogate/non-BMP cases. Some user-facing diagnostic snippets could split surrogate pairs. Issue Number: #517 What is the new behavior? This PR hardens Unicode handling and diagnostics across relevant compiler paths. @Component({ selector: 'app-child', imports: [], host: {'[style.color]': '我a的() ? "green" : "red"'}, template: `
{{ 我a的() ? 'Angular 🚀' : '😔' }}
`, styles: ``, }) export class UnicodeLibChild { 我a的 = input(); } import {Component} from '@angular/core'; import {UnicodeLibChild} from 'unicode-lib'; @Component({ selector: 'app-root', imports: [UnicodeLibChild], template: ``, }) export class App { 我a的 = '我a的'; } produces : Risk assessment Risk matrix in the comment below Prior Attempts / Addressed Concerns Previous related attempt: #46194. @alexhub concerns from prior attempt and how this PR addresses them: Concern: broad acceptance via codePoint >= 0x80 was over-permissive. Addressed: this PR uses ECMAScript-aligned ID_Start/ID_Continue Concern: "how multi-byte characters may affect source positions and any operation that relies on them". -Addressed: this PR adds code-point-aware advancement where identifier scanning depends on character width, adds diagnostic-formatting tests for Unicode/surrogate behavior, and captures remaining formatter/terminal-width caveats in comments below to be addressed if required. Implementation packages/compiler/src/expression_parser/lexer.ts Supports Unicode identifiers using JS-valid ID_Start / ID_Continue checks. Uses surrogate-aware code point scanning for identifiers. Formats unexpected non-ASCII characters in diagnostics as escaped \u{...} for deterministic output. packages/compiler/src/ml_parser/lexer.ts Improves unexpected-character diagnostics with codepoint-aware rendering and surrogate-safe fallback. packages/core/src/render3/styling/styling_parser.ts Prevents malformed-style marker rendering from splitting surrogate pairs. Test coverage added/expanded packages/compiler/test/expression_parser/lexer_spec.ts Astral identifiers, private identifiers, combining mark / ZWJ / ZWNJ behavior, malformed surrogates, out-of-range code points, escaped-diagnostic format guard. packages/compiler/test/expression_parser/parser_spec.ts Unicode across broader expression contexts (calls, keyed read/write, safe access, assignments, object/array literals), astral/private diagnostics. packages/compiler/test/ml_parser/lexer_spec.ts Non-BMP unexpected-character diagnostic regression. packages/core/test/render3/instructions/styling_parser_spec.ts Surrogate-safe malformed-style diagnostic marker regression. packages/compiler-cli/test/ngtsc/ngtsc_spec.ts Partial/full declaration emission coverage for unicode input aliases. External declaration consumption coverage for unicode input aliases. Also properly handled now by builders/diagnostics - Underline is 2 characters too short. I've explained this in the comment below. Local validation performed pnpm bazel test //packages/compiler/test/expression_parser:expression_parser --test_output=errors pnpm bazel test //packages/compiler/test/ml_parser:ml_parser --test_output=errors pnpm bazel test //packages/core/test/render3:render3 --test_filter='styling parser' --test_output=errors pnpm bazel test //packages/compiler-cli/test/ngtsc:ngtsc --test_filter='unicode input' --test_output=errors Related demo artifacts (optional reviewer experimentation) Demo repo: https://github.com/kbrilla/angular-unicode-input-demo StackBlitz import: https://stackblitz.com/github/kbrilla/angular-unicode-input-demo VSIX artifact in demo repo: artifacts/ng-template-new-features.vsix Does this PR introduce a breaking change? Yes No Other information This approach intentionally avoids broad/non-spec Unicode acceptance and instead aligns with JS identifier classes, addressing concerns from earlier attempts (e.g. broad >= 0x80 acceptance and insufficient surrogate/multi-byte diagnostics coverage). AI disclosure AI assisted with implementation and drafting under user direction; all changes were reviewed and validated with local tests before opening this PR.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...

Opengraph URL: https://github.com/angular/angular/pull/67289

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:79ad37e3-dea9-4ddd-aaed-8a50d848e4be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC5C:3DD488:FB9B4C:13F7353:6B0111AC
html-safe-nonce40f14d4f61b6fe4933b4d6c6c7bbf659b1dfc985182b7fdb8c6d1d73a6ab3d3d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzVDOjNERDQ4ODpGQjlCNEM6MTNGNzM1Mzo2QjAxMTFBQyIsInZpc2l0b3JfaWQiOiI5MDA2MjA2NTk1MTA0ODM4MDYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3dc37c70ab17a61a7bc65a90dbd0f774f6d55a13cef6098e43fc12694475f648
hovercard-subject-tagpull_request:3326841292
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/67289/files
twitter:imagehttps://avatars.githubusercontent.com/u/22288449?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/22288449?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/67289/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F67289%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F67289%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/67289/files
Reloadhttps://github.com/angular/angular/pull/67289/files
Reloadhttps://github.com/angular/angular/pull/67289/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
kbrillahttps://github.com/kbrilla
angular:mainhttps://github.com/angular/angular/tree/main
kbrilla:feat/issue-517-utf-expressionshttps://github.com/kbrilla/angular/tree/feat/issue-517-utf-expressions
Conversation 4 https://github.com/angular/angular/pull/67289
Commits 2 https://github.com/angular/angular/pull/67289/commits
Checks 17 https://github.com/angular/angular/pull/67289/checks
Files changed https://github.com/angular/angular/pull/67289/files
Please reload this pagehttps://github.com/angular/angular/pull/67289/files
feat(compiler): support JS-valid unicode identifiers and improve unicode diagnostics in template parsing https://github.com/angular/angular/pull/67289/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/67289/files
59d8d13 feat(compiler): support unicode identifiers in expression lexer kbrilla Feb 25, 2026 https://github.com/angular/angular/pull/67289/commits/59d8d133af924e6e2aba60b204533180c3703476
ade9479 test(compiler): expand unicode identifier coverage kbrilla Feb 25, 2026 https://github.com/angular/angular/pull/67289/commits/ade947902a95b5e9f0c3272242bb90215dcf5191
Clear filters https://github.com/angular/angular/pull/67289/files
Please reload this pagehttps://github.com/angular/angular/pull/67289/files
Please reload this pagehttps://github.com/angular/angular/pull/67289/files
ngtsc_spec.ts https://github.com/angular/angular/pull/67289/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
lexer.ts https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
lexer.ts https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
lexer_spec.ts https://github.com/angular/angular/pull/67289/files#diff-e023a7395ff42697000d1a63404c058fb0e334bf0c9002d6d24f84557b5b48c2
parser_spec.ts https://github.com/angular/angular/pull/67289/files#diff-f6e4825f64f47f0d247895493187f52d7ace19fe0170df3d3bc5e8de9387f728
lexer_spec.ts https://github.com/angular/angular/pull/67289/files#diff-64156e50d493a3955968129609e66c1e93808a2a92a1771a32670416756d0893
styling_parser.ts https://github.com/angular/angular/pull/67289/files#diff-780f92ef65676317c99beb03f5d8831c1fe5db9da5624b502095d16d87b864e8
styling_parser_spec.ts https://github.com/angular/angular/pull/67289/files#diff-a7abe763f62f95df03c240a5efab37615ccf3504d336e9c2e3a9bfea673cf1ff
packages/compiler-cli/test/ngtsc/ngtsc_spec.tshttps://github.com/angular/angular/pull/67289/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
View file https://github.com/kbrilla/angular/blob/ade947902a95b5e9f0c3272242bb90215dcf5191/packages/compiler-cli/test/ngtsc/ngtsc_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/67289/{{ revealButtonHref }}
https://github.com/angular/angular/pull/67289/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
https://github.com/angular/angular/pull/67289/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
https://github.com/angular/angular/pull/67289/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
https://github.com/angular/angular/pull/67289/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
packages/compiler/src/expression_parser/lexer.tshttps://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
View file https://github.com/kbrilla/angular/blob/ade947902a95b5e9f0c3272242bb90215dcf5191/packages/compiler/src/expression_parser/lexer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/67289/{{ revealButtonHref }}
https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
https://github.com/angular/angular/pull/67289/files#diff-23f53ce5db3a426d680a9ec36f2babf42f4d26c8dc72182ad7dcb055c88d550d
packages/compiler/src/ml_parser/lexer.tshttps://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
View file https://github.com/kbrilla/angular/blob/ade947902a95b5e9f0c3272242bb90215dcf5191/packages/compiler/src/ml_parser/lexer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/67289/{{ revealButtonHref }}
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
https://github.com/angular/angular/pull/67289/files#diff-916c75ef599dda8e385b9967c0b55c00bf20a38e46c27cf9f919632c76b65645
Please reload this pagehttps://github.com/angular/angular/pull/67289/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.