René's URL Explorer Experiment


Title: feat(language-service): integrate progressive init with pull-based diagnostics by kbrilla · Pull Request #66967 · angular/angular · GitHub

Open Graph Title: feat(language-service): integrate progressive init with pull-based diagnostics by kbrilla · Pull Request #66967 · angular/angular

X Title: feat(language-service): integrate progressive init with pull-based diagnostics by kbrilla · Pull Request #66967 · angular/angular

Description: PR: feat(language-service): integrate progressive init with pull-based diagnostics Description Integrates Progressive Project Initialization (#66966) with Pull-Based Diagnostics (#66700) so they work optimally together. When pull-based diagnostics (LSP 3.17) is active, progressive project initialization now sends a single workspace/diagnostic/refresh notification instead of computing and pushing diagnostics for each open file. This eliminates wasted computation since the pull-based client would discard pushed diagnostics anyway. Falls back to the chunked push-based approach when pull diagnostics is not supported by the client. Problem Without this integration, when both features are active: Progressive init computes diagnostics for each open file (getSemanticDiagnostics) and pushes them via connection.sendDiagnostics() The pull-based client ignores these pushed diagnostics (it uses textDocument/diagnostic to request them on-demand) The diagnostic computation in step 1 is entirely wasted Solution private async initializeProjectProgressively(project: ts.server.Project): Promise { // ... if (this.usePullDiagnostics) { // Just notify the client to re-pull — no computation needed this.connection.languages.diagnostics.refresh(); return; } // Fall back to chunked push-based approach // ... } When usePullDiagnostics is true, the method: Sends workspace/diagnostic/refresh to the client Returns immediately — no file-by-file diagnostic computation The client then pulls diagnostics on its own schedule, using the pull diagnostics handler which has its own caching via resultId. Changes File Change vscode-ng-language-service/server/src/session.ts Check usePullDiagnostics in initializeProjectProgressively(), send refresh notification instead of computing diagnostics Dependencies This PR must be merged AFTER both base PRs: #66700 — Pull-Based Diagnostics (provides usePullDiagnostics flag and workspace/diagnostic/refresh) #66966 — Progressive Project Initialization (provides initializeProjectProgressively()) Testing All language service tests pass (modern + legacy) All LSP integration tests pass (including pull diagnostics tests) All server unit tests pass Breaking Changes None AI Disclosure This PR was developed using Claude Opus 4 AI assistant under human orchestration and review by @kbrilla.

Open Graph Description: PR: feat(language-service): integrate progressive init with pull-based diagnostics Description Integrates Progressive Project Initialization (#66966) with Pull-Based Diagnostics (#66700) so they wo...

X Description: PR: feat(language-service): integrate progressive init with pull-based diagnostics Description Integrates Progressive Project Initialization (#66966) with Pull-Based Diagnostics (#66700) so they wo...

Opengraph URL: https://github.com/angular/angular/pull/66967

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1af729a1-e1b4-eff4-30b7-7f58d561e74e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3D6:EAD6D:1491FA4:19C5590:6B0263EA
html-safe-nonce1c3c150eae371cf190c63a9a506f5eb2c022de2244c45a9314c595bc154e1439
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0Q2OkVBRDZEOjE0OTFGQTQ6MTlDNTU5MDo2QjAyNjNFQSIsInZpc2l0b3JfaWQiOiI0NjYwNjg3NTE1ODI5MTM1MTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd1889e3340fa451c92e952dcf5423161dc0e7122deecc3c2255958dbdfbaf4a4
hovercard-subject-tagpull_request:3260330710
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/66967/files
twitter:imagehttps://avatars.githubusercontent.com/u/22288449?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/22288449?s=400&v=4
og:image:altPR: feat(language-service): integrate progressive init with pull-based diagnostics Description Integrates Progressive Project Initialization (#66966) with Pull-Based Diagnostics (#66700) so they wo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/66967/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F66967%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F66967%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/66967/files
Reloadhttps://github.com/angular/angular/pull/66967/files
Reloadhttps://github.com/angular/angular/pull/66967/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
kbrillahttps://github.com/kbrilla
angular:mainhttps://github.com/angular/angular/tree/main
kbrilla:feat/progressive-pull-diagnostics-integrationhttps://github.com/kbrilla/angular/tree/feat/progressive-pull-diagnostics-integration
Conversation 3 https://github.com/angular/angular/pull/66967
Commits 5 https://github.com/angular/angular/pull/66967/commits
Checks 9 https://github.com/angular/angular/pull/66967/checks
Files changed https://github.com/angular/angular/pull/66967/files
Please reload this pagehttps://github.com/angular/angular/pull/66967/files
feat(language-service): integrate progressive init with pull-based diagnostics https://github.com/angular/angular/pull/66967/files#top
Show all changes 5 commits https://github.com/angular/angular/pull/66967/files
8a4bb40 feat(language-service): implement pull-based diagnostics (LSP 3.17) kbrilla Feb 4, 2026 https://github.com/angular/angular/pull/66967/commits/8a4bb40b4035f9c6b4048d249c2bacadd00330e5
a359e7c perf(language-service): progressive project initialization kbrilla Feb 8, 2026 https://github.com/angular/angular/pull/66967/commits/a359e7cbebbd4e7645da95364f58253f79e905a5
46d1fe8 refactor(language-service): replace yieldToEventLoop with setImmediateP kbrilla Feb 8, 2026 https://github.com/angular/angular/pull/66967/commits/46d1fe8879ebf8202cfedcd94c130f63092b02b5
5828353 Merge branch 'perf/progressive-project-init' into feat/progressive-pu… kbrilla Feb 8, 2026 https://github.com/angular/angular/pull/66967/commits/5828353d9909ddfc5da61b7acdd2aca71daec1c1
dd444ab feat(language-service): integrate progressive init with pull-based di… kbrilla Feb 8, 2026 https://github.com/angular/angular/pull/66967/commits/dd444abb2e6daeb2728c409a0a32bc9f27ae9995
Clear filters https://github.com/angular/angular/pull/66967/files
Please reload this pagehttps://github.com/angular/angular/pull/66967/files
Please reload this pagehttps://github.com/angular/angular/pull/66967/files
ivy_spec.ts https://github.com/angular/angular/pull/66967/files#diff-f640fd78339f24ad47d2afa39c636a6a8476a96d8297187c62dec1a1ec3b77e2
test_utils.ts https://github.com/angular/angular/pull/66967/files#diff-372baf7cb304f40425f904942bf0473bd9d90ac49550b442658669d226a8413c
diagnostics.ts https://github.com/angular/angular/pull/66967/files#diff-b876bb14aa1e13c803e979f3773bee94f6844255e80f0e98ad21ab8fe2e9c867
initialization.ts https://github.com/angular/angular/pull/66967/files#diff-2eaed94aa71ac9a7859c4308cb21f8ba890af01dbb2e6a73ad015fbd261b867e
session.ts https://github.com/angular/angular/pull/66967/files#diff-2aa1314c29a6da3788ba851838ec44db8fefb023c04ba6f8c2609ee65b670f3d
vscode-ng-language-service/integration/lsp/ivy_spec.tshttps://github.com/angular/angular/pull/66967/files#diff-f640fd78339f24ad47d2afa39c636a6a8476a96d8297187c62dec1a1ec3b77e2
View file https://github.com/kbrilla/angular/blob/dd444abb2e6daeb2728c409a0a32bc9f27ae9995/vscode-ng-language-service/integration/lsp/ivy_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/66967/{{ revealButtonHref }}
https://github.com/angular/angular/pull/66967/files#diff-f640fd78339f24ad47d2afa39c636a6a8476a96d8297187c62dec1a1ec3b77e2
https://github.com/angular/angular/pull/66967/files#diff-f640fd78339f24ad47d2afa39c636a6a8476a96d8297187c62dec1a1ec3b77e2
vscode-ng-language-service/integration/lsp/test_utils.tshttps://github.com/angular/angular/pull/66967/files#diff-372baf7cb304f40425f904942bf0473bd9d90ac49550b442658669d226a8413c
View file https://github.com/kbrilla/angular/blob/dd444abb2e6daeb2728c409a0a32bc9f27ae9995/vscode-ng-language-service/integration/lsp/test_utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/66967/{{ revealButtonHref }}
https://github.com/angular/angular/pull/66967/files#diff-372baf7cb304f40425f904942bf0473bd9d90ac49550b442658669d226a8413c
https://github.com/angular/angular/pull/66967/files#diff-372baf7cb304f40425f904942bf0473bd9d90ac49550b442658669d226a8413c
https://github.com/angular/angular/pull/66967/files#diff-372baf7cb304f40425f904942bf0473bd9d90ac49550b442658669d226a8413c
Please reload this pagehttps://github.com/angular/angular/pull/66967/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.