René's URL Explorer Experiment


Title: refactor(compiler-cli): relax optional chain non nullable diagnostics on indexed access. by JeanMeche · Pull Request #64007 · angular/angular · GitHub

Open Graph Title: refactor(compiler-cli): relax optional chain non nullable diagnostics on indexed access. by JeanMeche · Pull Request #64007 · angular/angular

X Title: refactor(compiler-cli): relax optional chain non nullable diagnostics on indexed access. by JeanMeche · Pull Request #64007 · angular/angular

Description: …stics on indexed access. When noUncheckedIndexedAccess is not enabled, indexed accesses do not include undefined in the type. This makes the OptionalChainNotNullableCheck inconvenient when wanting to safe guard an indexed access (and when the typings isn't helping you). eg myArra[0]?.foobar; // should not warn/error if noUncheckedIndexedAccess != true Ideally projectw should enable noUncheckedIndexedAccess for better typesafety, but this is often inconveninent (we do not enable it by default) and often not the resort of the developer. So more better coding convinience, OptionalChainNotNullableCheck will not raise an error/warning on indexed Acessed followed by an optional chaining when noUncheckedIndexedAccess is not enabled. See also #63809 which will detect more cases

Open Graph Description: …stics on indexed access. When noUncheckedIndexedAccess is not enabled, indexed accesses do not include undefined in the type. This makes the OptionalChainNotNullableCheck inconvenient when wanting...

X Description: …stics on indexed access. When noUncheckedIndexedAccess is not enabled, indexed accesses do not include undefined in the type. This makes the OptionalChainNotNullableCheck inconvenient when wanting...

Opengraph URL: https://github.com/angular/angular/pull/64007

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6d0d5a7b-68cc-b6e6-2c54-ef12ff888d3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A78:23CF06:12FB4BD:1851B93:6B011222
html-safe-nonce2671bf35f53a22cbc0f541b71f9155a866a2c8a7ee26c310e7e1ae6aa91f4ffd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTc4OjIzQ0YwNjoxMkZCNEJEOjE4NTFCOTM6NkIwMTEyMjIiLCJ2aXNpdG9yX2lkIjoiMzg5MDIyODUyOTIxNTkwMjI0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8338da1064ec6872df1fd2c2df24bf643f50b1d3ee5b54018dfc35d4cb2479c3
hovercard-subject-tagpull_request:2853510246
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/64007/files
twitter:imagehttps://avatars.githubusercontent.com/u/1300985?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1300985?s=400&v=4
og:image:alt…stics on indexed access. When noUncheckedIndexedAccess is not enabled, indexed accesses do not include undefined in the type. This makes the OptionalChainNotNullableCheck inconvenient when wanting...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/64007/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F64007%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F64007%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/64007/files
Reloadhttps://github.com/angular/angular/pull/64007/files
Reloadhttps://github.com/angular/angular/pull/64007/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JeanMechehttps://github.com/JeanMeche
angular:mainhttps://github.com/angular/angular/tree/main
JeanMeche:compiler-indexed-access-checkhttps://github.com/JeanMeche/angular/tree/compiler-indexed-access-check
Conversation 3 https://github.com/angular/angular/pull/64007
Commits 1 https://github.com/angular/angular/pull/64007/commits
Checks 0 https://github.com/angular/angular/pull/64007/checks
Files changed https://github.com/angular/angular/pull/64007/files
Please reload this pagehttps://github.com/angular/angular/pull/64007/files
refactor(compiler-cli): relax optional chain non nullable diagnostics on indexed access. https://github.com/angular/angular/pull/64007/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/64007/files
a95f569 refactor(compiler-cli): Don't emit optional chain non nullable diagno… JeanMeche Sep 23, 2025 https://github.com/angular/angular/pull/64007/commits/a95f569906bbdf64f62bef2f5d072cdbb5d5f405
Clear filters https://github.com/angular/angular/pull/64007/files
Please reload this pagehttps://github.com/angular/angular/pull/64007/files
Please reload this pagehttps://github.com/angular/angular/pull/64007/files
index.ts https://github.com/angular/angular/pull/64007/files#diff-39475956e845e6a9c189fe25fb513e88de99116b7899a1a2ab546a2049787a3e
optional_chain_not_nullable_spec.ts https://github.com/angular/angular/pull/64007/files#diff-80b1c50f47e71c2247900157743a5280063806e65670ee7cd47cf629f53ce7b3
...ges/compiler-cli/src/ngtsc/typecheck/extended/checks/optional_chain_not_nullable/index.tshttps://github.com/angular/angular/pull/64007/files#diff-39475956e845e6a9c189fe25fb513e88de99116b7899a1a2ab546a2049787a3e
View file https://github.com/JeanMeche/angular/blob/a95f569906bbdf64f62bef2f5d072cdbb5d5f405/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/optional_chain_not_nullable/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/64007/{{ revealButtonHref }}
https://github.com/angular/angular/pull/64007/files#diff-39475956e845e6a9c189fe25fb513e88de99116b7899a1a2ab546a2049787a3e
https://github.com/angular/angular/pull/64007/files#diff-39475956e845e6a9c189fe25fb513e88de99116b7899a1a2ab546a2049787a3e
https://github.com/angular/angular/pull/64007/files#diff-39475956e845e6a9c189fe25fb513e88de99116b7899a1a2ab546a2049787a3e
https://github.com/angular/angular/pull/64007/files#diff-39475956e845e6a9c189fe25fb513e88de99116b7899a1a2ab546a2049787a3e
https://github.com/angular/angular/pull/64007/files#diff-39475956e845e6a9c189fe25fb513e88de99116b7899a1a2ab546a2049787a3e
...heck/extended/test/checks/optional_chain_not_nullable/optional_chain_not_nullable_spec.tshttps://github.com/angular/angular/pull/64007/files#diff-80b1c50f47e71c2247900157743a5280063806e65670ee7cd47cf629f53ce7b3
View file https://github.com/JeanMeche/angular/blob/a95f569906bbdf64f62bef2f5d072cdbb5d5f405/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/optional_chain_not_nullable/optional_chain_not_nullable_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/64007/{{ revealButtonHref }}
https://github.com/angular/angular/pull/64007/files#diff-80b1c50f47e71c2247900157743a5280063806e65670ee7cd47cf629f53ce7b3
https://github.com/angular/angular/pull/64007/files#diff-80b1c50f47e71c2247900157743a5280063806e65670ee7cd47cf629f53ce7b3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.