Title: fix(service-worker): update service worker to handle seeking better for videos by Beanminchild · Pull Request #60029 · angular/angular · GitHub
Open Graph Title: fix(service-worker): update service worker to handle seeking better for videos by Beanminchild · Pull Request #60029 · angular/angular
X Title: fix(service-worker): update service worker to handle seeking better for videos by Beanminchild · Pull Request #60029 · angular/angular
Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) <-- {i will do this before i merge if you all think this is a good change} PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? "If you ng run app:build:production and your pwa comes with a Issue Number: #25865 What is the new behavior? Added logic to driver.ts in the worker src folder that does the following: The onFetch method now: Checks for Range headers in incoming requests. Calls the handleRangeRequest function if a Range header is present. The newly added handleRangeRequest function: Parses the Range header to determine the requested byte range. Fetches the full content and extracts the requested byte range. Constructs a response with the appropriate Content-Range and Content-Length headers. Returns a 206 Partial Content response with the requested byte range. These changes ensure that the service worker can handle Range requests, allowing videos to start at the specified currentTime when delivered by the service worker as well as fixing seeking. Does this PR introduce a breaking change? Yes No Should not be a breaking change
Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
Opengraph URL: https://github.com/angular/angular/pull/60029
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b332f1ac-e765-3a51-6eb0-75316d87e1d6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C400:2E7EBB:10B4DFD:15276D6:6B0111FB |
| html-safe-nonce | 64f746576e477a09f12cddce497efebb2c22d3d516bf30b7c67212bfc7ed1a9d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDAwOjJFN0VCQjoxMEI0REZEOjE1Mjc2RDY6NkIwMTExRkIiLCJ2aXNpdG9yX2lkIjoiMjYyODYzMzM4MjY3Mzc4MTI0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8fbff73ccb6c60d414f6f1ab5351e8023060967f0a71307043bc6122ea367ea9 |
| hovercard-subject-tag | pull_request:2345897944 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/60029/files |
| twitter:image | https://avatars.githubusercontent.com/u/199300398?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/199300398?s=400&v=4 |
| og:image:alt | PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width