René's URL Explorer Experiment


Title: fix(service-worker): update service worker to handle seeking better for videos by Beanminchild · Pull Request #60029 · angular/angular · GitHub

Open Graph Title: fix(service-worker): update service worker to handle seeking better for videos by Beanminchild · Pull Request #60029 · angular/angular

X Title: fix(service-worker): update service worker to handle seeking better for videos by Beanminchild · Pull Request #60029 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) <-- {i will do this before i merge if you all think this is a good change} PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? "If you ng run app:build:production and your pwa comes with a Issue Number: #25865 What is the new behavior? Added logic to driver.ts in the worker src folder that does the following: The onFetch method now: Checks for Range headers in incoming requests. Calls the handleRangeRequest function if a Range header is present. The newly added handleRangeRequest function: Parses the Range header to determine the requested byte range. Fetches the full content and extracts the requested byte range. Constructs a response with the appropriate Content-Range and Content-Length headers. Returns a 206 Partial Content response with the requested byte range. These changes ensure that the service worker can handle Range requests, allowing videos to start at the specified currentTime when delivered by the service worker as well as fixing seeking. Does this PR introduce a breaking change? Yes No Should not be a breaking change

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

Opengraph URL: https://github.com/angular/angular/pull/60029

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b332f1ac-e765-3a51-6eb0-75316d87e1d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC400:2E7EBB:10B4DFD:15276D6:6B0111FB
html-safe-nonce64f746576e477a09f12cddce497efebb2c22d3d516bf30b7c67212bfc7ed1a9d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDAwOjJFN0VCQjoxMEI0REZEOjE1Mjc2RDY6NkIwMTExRkIiLCJ2aXNpdG9yX2lkIjoiMjYyODYzMzM4MjY3Mzc4MTI0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8fbff73ccb6c60d414f6f1ab5351e8023060967f0a71307043bc6122ea367ea9
hovercard-subject-tagpull_request:2345897944
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/60029/files
twitter:imagehttps://avatars.githubusercontent.com/u/199300398?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/199300398?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/60029/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F60029%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F60029%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/60029/files
Reloadhttps://github.com/angular/angular/pull/60029/files
Reloadhttps://github.com/angular/angular/pull/60029/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
Beanminchildhttps://github.com/Beanminchild
angular:mainhttps://github.com/angular/angular/tree/main
Beanminchild:mainhttps://github.com/Beanminchild/angular/tree/main
Conversation 18 https://github.com/angular/angular/pull/60029
Commits 1 https://github.com/angular/angular/pull/60029/commits
Checks 0 https://github.com/angular/angular/pull/60029/checks
Files changed https://github.com/angular/angular/pull/60029/files
Please reload this pagehttps://github.com/angular/angular/pull/60029/files
fix(service-worker): update service worker to handle seeking better for videos https://github.com/angular/angular/pull/60029/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/60029/files
6f49312 fix(service-worker): update service worker to handle seeking better f… Beanminchild Feb 19, 2025 https://github.com/angular/angular/pull/60029/commits/6f49312b0a6e452f070557d25d50adb9692cf915
Clear filters https://github.com/angular/angular/pull/60029/files
Please reload this pagehttps://github.com/angular/angular/pull/60029/files
Please reload this pagehttps://github.com/angular/angular/pull/60029/files
ngsw-worker.js https://github.com/angular/angular/pull/60029/files#diff-153b81f5183b4375cd25a901e8c3a5083a688d97485ff5623bcdea3f418a28f9
driver.ts https://github.com/angular/angular/pull/60029/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
packages/examples/service-worker/push/ngsw-worker.jshttps://github.com/angular/angular/pull/60029/files#diff-153b81f5183b4375cd25a901e8c3a5083a688d97485ff5623bcdea3f418a28f9
View file https://github.com/Beanminchild/angular/blob/6f49312b0a6e452f070557d25d50adb9692cf915/packages/examples/service-worker/push/ngsw-worker.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/60029/{{ revealButtonHref }}
https://github.com/angular/angular/pull/60029/files#diff-153b81f5183b4375cd25a901e8c3a5083a688d97485ff5623bcdea3f418a28f9
https://github.com/angular/angular/pull/60029/files#diff-153b81f5183b4375cd25a901e8c3a5083a688d97485ff5623bcdea3f418a28f9
packages/service-worker/worker/src/driver.tshttps://github.com/angular/angular/pull/60029/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
View file https://github.com/Beanminchild/angular/blob/6f49312b0a6e452f070557d25d50adb9692cf915/packages/service-worker/worker/src/driver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/60029/{{ revealButtonHref }}
https://github.com/angular/angular/pull/60029/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/60029/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/60029/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com/angular/angular/pull/60029/files#diff-adf3d3cdc73e397d657478c9adfa0f60e1185440fe8e1ef0832c7b5581f9a9d1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.