Title: fix(service-worker): update service worker to handle seeking better for videos . by Beanminchild · Pull Request #60007 · angular/angular · GitHub
Open Graph Title: fix(service-worker): update service worker to handle seeking better for videos . by Beanminchild · Pull Request #60007 · angular/angular
X Title: fix(service-worker): update service worker to handle seeking better for videos . by Beanminchild · Pull Request #60007 · angular/angular
Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #25865 What is the new behavior? 1.) Fetch Event Listener: The service worker listens for fetch events and checks if the request contains a range header. 2.) Range Request Handling: If a range header is present, the service worker calls the handleRangeRequest function to process the request. 3.) Partial Content Response: The handleRangeRequest function extracts the requested byte range from the range header, retrieves the requested resource from the cache, slices the resource to the specified byte range, and returns a 206 Partial Content response with the appropriate Content-Range header. This ensures that video seeking works correctly when videos are delivered by the service worker. Does this PR introduce a breaking change? Yes No : Has error handling and falls back to normal request if content is not a video I saw this problem was a bit of a necro thread thats been an issue for quite some time. There was a workaround in the chat that did something similar to what im doing here but i figured it would be nice if this logic was just built in instead of people needing to implement a third party hack. Based on my local testing this should work as expected but please feel free to give me any feedback, concerns or needed improvements and ill be happy to implement them to get this bug fix finally squared away :)
Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
Opengraph URL: https://github.com/angular/angular/pull/60007
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:bfe32a35-beb6-680f-f3a2-439fa06e12bd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8D18:DB09F:1FEE7BA:28B07D5:6B0174EB |
| html-safe-nonce | 671b5e35e2c1e23d8f477f92e875c5d296ba3aa7d5e7db40cc7b6cf4466090fd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDE4OkRCMDlGOjFGRUU3QkE6MjhCMDdENTo2QjAxNzRFQiIsInZpc2l0b3JfaWQiOiI0OTIxMTA3OTMyNTE2NTQ1NzcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | aada47bace57fa9bc591f7d72541c1d4f509d56bfaa4b91bf76ce2dac91a6dfe |
| hovercard-subject-tag | pull_request:2343575523 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/60007/files |
| twitter:image | https://avatars.githubusercontent.com/u/199300398?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/199300398?s=400&v=4 |
| og:image:alt | PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width