René's URL Explorer Experiment


Title: fix(service-worker): update service worker to handle seeking better for videos . by Beanminchild · Pull Request #60007 · angular/angular · GitHub

Open Graph Title: fix(service-worker): update service worker to handle seeking better for videos . by Beanminchild · Pull Request #60007 · angular/angular

X Title: fix(service-worker): update service worker to handle seeking better for videos . by Beanminchild · Pull Request #60007 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.dev application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #25865 What is the new behavior? 1.) Fetch Event Listener: The service worker listens for fetch events and checks if the request contains a range header. 2.) Range Request Handling: If a range header is present, the service worker calls the handleRangeRequest function to process the request. 3.) Partial Content Response: The handleRangeRequest function extracts the requested byte range from the range header, retrieves the requested resource from the cache, slices the resource to the specified byte range, and returns a 206 Partial Content response with the appropriate Content-Range header. This ensures that video seeking works correctly when videos are delivered by the service worker. Does this PR introduce a breaking change? Yes No : Has error handling and falls back to normal request if content is not a video I saw this problem was a bit of a necro thread thats been an issue for quite some time. There was a workaround in the chat that did something similar to what im doing here but i figured it would be nice if this logic was just built in instead of people needing to implement a third party hack. Based on my local testing this should work as expected but please feel free to give me any feedback, concerns or needed improvements and ill be happy to implement them to get this bug fix finally squared away :)

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

Opengraph URL: https://github.com/angular/angular/pull/60007

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bfe32a35-beb6-680f-f3a2-439fa06e12bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D18:DB09F:1FEE7BA:28B07D5:6B0174EB
html-safe-nonce671b5e35e2c1e23d8f477f92e875c5d296ba3aa7d5e7db40cc7b6cf4466090fd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDE4OkRCMDlGOjFGRUU3QkE6MjhCMDdENTo2QjAxNzRFQiIsInZpc2l0b3JfaWQiOiI0OTIxMTA3OTMyNTE2NTQ1NzcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaada47bace57fa9bc591f7d72541c1d4f509d56bfaa4b91bf76ce2dac91a6dfe
hovercard-subject-tagpull_request:2343575523
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/60007/files
twitter:imagehttps://avatars.githubusercontent.com/u/199300398?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/199300398?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/60007/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F60007%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F60007%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/60007/files
Reloadhttps://github.com/angular/angular/pull/60007/files
Reloadhttps://github.com/angular/angular/pull/60007/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
Beanminchildhttps://github.com/Beanminchild
angular:mainhttps://github.com/angular/angular/tree/main
Beanminchild:mainhttps://github.com/Beanminchild/angular/tree/main
Conversation 5 https://github.com/angular/angular/pull/60007
Commits 2 https://github.com/angular/angular/pull/60007/commits
Checks 0 https://github.com/angular/angular/pull/60007/checks
Files changed https://github.com/angular/angular/pull/60007/files
Please reload this pagehttps://github.com/angular/angular/pull/60007/files
fix(service-worker): update service worker to handle seeking better for videos . https://github.com/angular/angular/pull/60007/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/60007/files
80a7c52 update service worker to handle seeking better for videos Beanminchild Feb 19, 2025 https://github.com/angular/angular/pull/60007/commits/80a7c522e1f5eb3d3f6de2a02574700900dfedf2
a8a4421 fix(service-worker): update service worker to handle seeking better f… Beanminchild Feb 19, 2025 https://github.com/angular/angular/pull/60007/commits/a8a4421ad4030747b7b8a2daa5302810b233e6ad
Clear filters https://github.com/angular/angular/pull/60007/files
Please reload this pagehttps://github.com/angular/angular/pull/60007/files
Please reload this pagehttps://github.com/angular/angular/pull/60007/files
packages/examples/service-worker/push/ngsw-worker.jshttps://github.com/angular/angular/pull/60007/files#diff-153b81f5183b4375cd25a901e8c3a5083a688d97485ff5623bcdea3f418a28f9
View file https://github.com/Beanminchild/angular/blob/a8a4421ad4030747b7b8a2daa5302810b233e6ad/packages/examples/service-worker/push/ngsw-worker.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/60007/{{ revealButtonHref }}
https://github.com/angular/angular/pull/60007/files#diff-153b81f5183b4375cd25a901e8c3a5083a688d97485ff5623bcdea3f418a28f9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.