René's URL Explorer Experiment


Title: feat(compiler-cli): detect missing structural directive imports by manbearwiz · Pull Request #59443 · angular/angular · GitHub

Open Graph Title: feat(compiler-cli): detect missing structural directive imports by manbearwiz · Pull Request #59443 · angular/angular

X Title: feat(compiler-cli): detect missing structural directive imports by manbearwiz · Pull Request #59443 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Feature What is the current behavior? Issue Number: #37322 Currently, the compiler will warn about missing directive imports if they are one of the "known" structural directives from the CommonModule or use regular binding syntax. This extends that to include custom, user-defined, structural directives. Currently, missing an import for these custom structural directives just fails silently which is a pain point when doing standalone migrations. What is the new behavior? The compiler will now warn on missing custom structural directives. Does this PR introduce a breaking change? Yes No I made minimal changes and left existing logic in order to ensure the changes are not breaking. I am definitely open to taking another approach, adding more test cases, etc.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

Opengraph URL: https://github.com/angular/angular/pull/59443

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d3442aa8-27ba-3e1a-b19a-1230f0538104
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3C8:134361:D3D106:117D2DD:6B00F8D8
html-safe-nonce497a04a9f33b0d8d65e2c4f86879cb11fabe4c22dfaf0fe5995d02fb1b25110c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0M4OjEzNDM2MTpEM0QxMDY6MTE3RDJERDo2QjAwRjhEOCIsInZpc2l0b3JfaWQiOiI4NjcwOTg0Njg5NzA5ODA3ODMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccd2f5afcac82b2b26e21e61a4e5e21579a0536f49d7c476179252223332713ac
hovercard-subject-tagpull_request:2267630523
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/59443/files
twitter:imagehttps://avatars.githubusercontent.com/u/3688847?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3688847?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/59443/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F59443%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F59443%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/59443/files
Reloadhttps://github.com/angular/angular/pull/59443/files
Reloadhttps://github.com/angular/angular/pull/59443/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
manbearwizhttps://github.com/manbearwiz
angular:mainhttps://github.com/angular/angular/tree/main
manbearwiz:check-missing-structural-directiveshttps://github.com/manbearwiz/angular/tree/check-missing-structural-directives
Conversation 73 https://github.com/angular/angular/pull/59443
Commits 7 https://github.com/angular/angular/pull/59443/commits
Checks 0 https://github.com/angular/angular/pull/59443/checks
Files changed https://github.com/angular/angular/pull/59443/files
Please reload this pagehttps://github.com/angular/angular/pull/59443/files
feat(compiler-cli): detect missing structural directive imports https://github.com/angular/angular/pull/59443/files#top
Show all changes 7 commits https://github.com/angular/angular/pull/59443/files
b8e78ff feat(compiler-cli): detect missing structural directive imports manbearwiz Jan 9, 2025 https://github.com/angular/angular/pull/59443/commits/b8e78ffdc2b1b56baf378ee94461c1fb0d3ab562
1e95c36 fixup! feat(compiler-cli): detect missing structural directive imports JeanMeche Mar 28, 2025 https://github.com/angular/angular/pull/59443/commits/1e95c36647fa0b4d7ffbf39352933108c1ea75b3
8e5faa2 fixup! feat(compiler-cli): detect missing structural directive imports JeanMeche Apr 25, 2025 https://github.com/angular/angular/pull/59443/commits/8e5faa2ee298732ba699acc44bfae007d72d4965
c76c88b fixup! feat(compiler-cli): detect missing structural directive imports JeanMeche Apr 28, 2025 https://github.com/angular/angular/pull/59443/commits/c76c88be87e5ce24e50c2742c1e5c5e3ca546a37
61f969c fixup! feat(compiler-cli): detect missing structural directive imports JeanMeche Apr 29, 2025 https://github.com/angular/angular/pull/59443/commits/61f969c56c667e3fdde977b9cf8c262595cd9d10
792434a fixup! feat(compiler-cli): detect missing structural directive imports JeanMeche Apr 29, 2025 https://github.com/angular/angular/pull/59443/commits/792434a6ae3a51b6412fd4346dfc7faa25d426f8
fb47ccb fixup! feat(compiler-cli): detect missing structural directive imports JeanMeche Apr 29, 2025 https://github.com/angular/angular/pull/59443/commits/fb47ccbd3567b0172505cca125115594d051616f
Clear filters https://github.com/angular/angular/pull/59443/files
Please reload this pagehttps://github.com/angular/angular/pull/59443/files
Please reload this pagehttps://github.com/angular/angular/pull/59443/files
NG8116.md https://github.com/angular/angular/pull/59443/files#diff-1803da0e7079a709ea554a22bfc63d1512ee75c80668c0b975d628dbf348e40e
overview.md https://github.com/angular/angular/pull/59443/files#diff-85ff44f949d9f2a9dd8bb288cfda12e5eb0cc9334c3e6b572b8515cb6a3295e4
error_code.api.md https://github.com/angular/angular/pull/59443/files#diff-da99cacc6a8b2cb94d492f713112f612c631d2469e8a70fd00761e429402bab2
extended_template_diagnostic_name.api.md https://github.com/angular/angular/pull/59443/files#diff-ec25c7239924c7b36a3ce97f6786405d848062ad2994ac1d8d435dff8b53ca58
error_code.ts https://github.com/angular/angular/pull/59443/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
extended_template_diagnostic_name.ts https://github.com/angular/angular/pull/59443/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
BUILD.bazel https://github.com/angular/angular/pull/59443/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
BUILD.bazel https://github.com/angular/angular/pull/59443/files#diff-58fe32934f42abc2a941775f1423af2afef3167a3d9efc8e511c337a3a5124b7
index.ts https://github.com/angular/angular/pull/59443/files#diff-801c403997f782b974d9ec9962efe396e482ce03348e8cf5391b14e0fd0f9aab
index.ts https://github.com/angular/angular/pull/59443/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
BUILD.bazel https://github.com/angular/angular/pull/59443/files#diff-aa17f4b3c2d01e0e07ebc422bc4f451b00dfd68992bed10bdaf629e71ab8974f
missing_structural_directive_spec.ts https://github.com/angular/angular/pull/59443/files#diff-5f5d91ac9d8a620a8834e88d6189d8ab363007d2638a8b77da01908261785ca9
symbol_util.ts https://github.com/angular/angular/pull/59443/files#diff-b972d1c6916cf31e6e314cc2e7720391054d1e1a94c098060be9cfef9c7ebde3
tcb_util.ts https://github.com/angular/angular/pull/59443/files#diff-644231dfc6bd893c34b4434bb180eba9fa5e4694c50a898b6831afdfc1702c43
template_symbol_builder.ts https://github.com/angular/angular/pull/59443/files#diff-a8127d2b4d704dfb9e68fff83734ad84ab91cc6bb99e9ded202d9c77409f49ab
BUILD.bazel https://github.com/angular/angular/pull/59443/files#diff-cdeb3b36b0951871f4b294c46104b55906b2b8fa75f98656ea6ecbf594cfca72
type_checker__get_symbol_of_template_node_spec.ts https://github.com/angular/angular/pull/59443/files#diff-f022aefc54d2e7be3c319a396c49aa7a97d8236e834228bb162a4e0fcd00cb79
BUILD.bazel https://github.com/angular/angular/pull/59443/files#diff-b44874bb659e6ed57a9f3df64fb6eeeab4f36171aaee0a4ab28c2cab0017f645
index.ts https://github.com/angular/angular/pull/59443/files#diff-49fe94d4a7d4e7db381db4e750af7e031e9f33f09b3b89e29ab1f3fe7fa77546
adev/src/content/reference/extended-diagnostics/NG8116.mdhttps://github.com/angular/angular/pull/59443/files#diff-1803da0e7079a709ea554a22bfc63d1512ee75c80668c0b975d628dbf348e40e
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/adev/src/content/reference/extended-diagnostics/NG8116.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
adev/src/content/reference/extended-diagnostics/overview.mdhttps://github.com/angular/angular/pull/59443/files#diff-85ff44f949d9f2a9dd8bb288cfda12e5eb0cc9334c3e6b572b8515cb6a3295e4
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/adev/src/content/reference/extended-diagnostics/overview.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
https://github.com/angular/angular/pull/59443/files#diff-85ff44f949d9f2a9dd8bb288cfda12e5eb0cc9334c3e6b572b8515cb6a3295e4
https://github.com/angular/angular/pull/59443/files#diff-85ff44f949d9f2a9dd8bb288cfda12e5eb0cc9334c3e6b572b8515cb6a3295e4
goldens/public-api/compiler-cli/error_code.api.mdhttps://github.com/angular/angular/pull/59443/files#diff-da99cacc6a8b2cb94d492f713112f612c631d2469e8a70fd00761e429402bab2
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/goldens/public-api/compiler-cli/error_code.api.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
https://github.com/angular/angular/pull/59443/files#diff-da99cacc6a8b2cb94d492f713112f612c631d2469e8a70fd00761e429402bab2
https://github.com/angular/angular/pull/59443/files#diff-da99cacc6a8b2cb94d492f713112f612c631d2469e8a70fd00761e429402bab2
goldens/public-api/compiler-cli/extended_template_diagnostic_name.api.mdhttps://github.com/angular/angular/pull/59443/files#diff-ec25c7239924c7b36a3ce97f6786405d848062ad2994ac1d8d435dff8b53ca58
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/goldens/public-api/compiler-cli/extended_template_diagnostic_name.api.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
https://github.com/angular/angular/pull/59443/files#diff-ec25c7239924c7b36a3ce97f6786405d848062ad2994ac1d8d435dff8b53ca58
https://github.com/angular/angular/pull/59443/files#diff-ec25c7239924c7b36a3ce97f6786405d848062ad2994ac1d8d435dff8b53ca58
packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.tshttps://github.com/angular/angular/pull/59443/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
https://github.com/angular/angular/pull/59443/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
https://github.com/angular/angular/pull/59443/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.tshttps://github.com/angular/angular/pull/59443/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
https://github.com/angular/angular/pull/59443/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
https://github.com/angular/angular/pull/59443/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazelhttps://github.com/angular/angular/pull/59443/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/packages/compiler-cli/src/ngtsc/typecheck/extended/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
https://github.com/angular/angular/pull/59443/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
https://github.com/angular/angular/pull/59443/files#diff-b48321e80b9a52e62e847f12731c83d49336da4b1ab867994027edf9b31e8c6e
...compiler-cli/src/ngtsc/typecheck/extended/checks/missing_structural_directive/BUILD.bazelhttps://github.com/angular/angular/pull/59443/files#diff-58fe32934f42abc2a941775f1423af2afef3167a3d9efc8e511c337a3a5124b7
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_structural_directive/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
...es/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_structural_directive/index.tshttps://github.com/angular/angular/pull/59443/files#diff-801c403997f782b974d9ec9962efe396e482ce03348e8cf5391b14e0fd0f9aab
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_structural_directive/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
packages/compiler-cli/src/ngtsc/typecheck/extended/index.tshttps://github.com/angular/angular/pull/59443/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/packages/compiler-cli/src/ngtsc/typecheck/extended/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
https://github.com/angular/angular/pull/59443/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
https://github.com/angular/angular/pull/59443/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
https://github.com/angular/angular/pull/59443/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
...ler-cli/src/ngtsc/typecheck/extended/test/checks/missing_structural_directive/BUILD.bazelhttps://github.com/angular/angular/pull/59443/files#diff-aa17f4b3c2d01e0e07ebc422bc4f451b00dfd68992bed10bdaf629e71ab8974f
View file https://github.com/manbearwiz/angular/blob/fb47ccbd3567b0172505cca125115594d051616f/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/missing_structural_directive/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/59443/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular/pull/59443/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.