René's URL Explorer Experiment


Title: fix(core): Handle @let declaration with array in `preparingForHydration` by JeanMeche · Pull Request #57816 · angular/angular · GitHub

Open Graph Title: fix(core): Handle @let declaration with array in `preparingForHydration` by JeanMeche · Pull Request #57816 · angular/angular

X Title: fix(core): Handle @let declaration with array in `preparingForHydration` by JeanMeche · Pull Request #57816 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Before this commit, @let declerations with an array were mistaken for a component in the lView and throwing an unexpected error. This commit fixes this.

X Description: Before this commit, @let declerations with an array were mistaken for a component in the lView and throwing an unexpected error. This commit fixes this.

Opengraph URL: https://github.com/angular/angular/pull/57816

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:152dafdd-fa11-ab9b-99dd-784be9c490fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD312:154D88:28E2562:34490AC:6B01E2B8
html-safe-nonce563429e38a4308ef8497eeea0dde12545c8165b34025b7b985edcae5c88d9890
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzEyOjE1NEQ4ODoyOEUyNTYyOjM0NDkwQUM6NkIwMUUyQjgiLCJ2aXNpdG9yX2lkIjoiNjE3NjQ5NjQwNzkxMjA0NTM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7ba52cb73449eb5f9ac0d76dc03ee2f57e5b1da1ec52ff51a6a2b59b4331971e
hovercard-subject-tagpull_request:2072314086
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/57816/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e35405f355e37a90b8fe21828da137ee098e2d805ac015c7c7f69d8e80f1345a/angular/angular/pull/57816
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e35405f355e37a90b8fe21828da137ee098e2d805ac015c7c7f69d8e80f1345a/angular/angular/pull/57816
og:image:altBefore this commit, @let declerations with an array were mistaken for a component in the lView and throwing an unexpected error. This commit fixes this.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJeanMeche
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/57816#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F57816
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F57816
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/57816
Reloadhttps://github.com/angular/angular/pull/57816
Reloadhttps://github.com/angular/angular/pull/57816
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
JeanMechehttps://github.com/JeanMeche
angular:mainhttps://github.com/angular/angular/tree/main
JeanMeche:fix/let-array-hydrationhttps://github.com/JeanMeche/angular/tree/fix/let-array-hydration
Conversationhttps://github.com/angular/angular/pull/57816
Commits2 (2)https://github.com/angular/angular/pull/57816/commits
Checkshttps://github.com/angular/angular/pull/57816/checks
Files changedhttps://github.com/angular/angular/pull/57816/files
fix(core): Handle @let declaration with array in preparingForHydrationhttps://github.com/angular/angular/pull/57816#top
JeanMechehttps://github.com/JeanMeche
angular:mainhttps://github.com/angular/angular/tree/main
JeanMeche:fix/let-array-hydrationhttps://github.com/JeanMeche/angular/tree/fix/let-array-hydration
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Sep 14, 2024https://github.com/angular/angular/pull/57816#issue-2526423782
Please reload this pagehttps://github.com/angular/angular/pull/57816
Please reload this pagehttps://github.com/angular/angular/pull/57816
https://github.com/JeanMeche
fix(core): Handlehttps://github.com/angular/angular/pull/57816/commits/0ad7957bdda6bb1a413bc62df3811c6037a93e38
@lethttps://github.com/let
declaration with array when `preparingForHydra…https://github.com/angular/angular/pull/57816/commits/0ad7957bdda6bb1a413bc62df3811c6037a93e38
0ad7957https://github.com/angular/angular/pull/57816/commits/0ad7957bdda6bb1a413bc62df3811c6037a93e38
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
Sep 14, 2024https://github.com/angular/angular/pull/57816#event-14259012157
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Sep 14, 2024https://github.com/angular/angular/pull/57816#event-14259012678
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
Sep 14, 2024https://github.com/angular/angular/pull/57816#event-14259348285
https://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
September 14, 2024 14:54https://github.com/angular/angular/pull/57816#event-14259350608
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
atscotthttps://github.com/atscott
September 14, 2024 14:54https://github.com/angular/angular/pull/57816#event-14259351163
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Sep 14, 2024 https://github.com/angular/angular/pull/57816#pullrequestreview-2304751385
View reviewed changes https://github.com/angular/angular/pull/57816/files/0ad7957bdda6bb1a413bc62df3811c6037a93e38
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Sep 14, 2024 https://github.com/angular/angular/pull/57816#pullrequestreview-2304791410
View reviewed changes https://github.com/angular/angular/pull/57816/files/0ad7957bdda6bb1a413bc62df3811c6037a93e38
packages/core/src/hydration/annotate.tshttps://github.com/angular/angular/pull/57816/files/0ad7957bdda6bb1a413bc62df3811c6037a93e38#diff-bf8ba0babd1375efd507768cc09a97f0107f23739689de00469af8134920fea9
AndrewKushnirhttps://github.com/AndrewKushnir
Sep 14, 2024https://github.com/angular/angular/pull/57816#discussion_r1759764896
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/57816
JeanMechehttps://github.com/JeanMeche
Sep 14, 2024https://github.com/angular/angular/pull/57816#discussion_r1759769797
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/57816
AndrewKushnirhttps://github.com/AndrewKushnir
Sep 14, 2024https://github.com/angular/angular/pull/57816#discussion_r1759792452
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@JeanMechehttps://github.com/JeanMeche
Please reload this pagehttps://github.com/angular/angular/pull/57816
JeanMechehttps://github.com/JeanMeche
Sep 16, 2024https://github.com/angular/angular/pull/57816#discussion_r1761428400
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@crisbetohttps://github.com/crisbeto
Please reload this pagehttps://github.com/angular/angular/pull/57816
AndrewKushnirhttps://github.com/AndrewKushnir
Sep 16, 2024https://github.com/angular/angular/pull/57816#discussion_r1761953599
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/57816
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Sep 14, 2024https://github.com/angular/angular/pull/57816#event-14259870893
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
atscotthttps://github.com/atscott
September 14, 2024 16:50https://github.com/angular/angular/pull/57816#event-14259871595
https://github.com/JeanMeche
fixup! fix(core): Handlehttps://github.com/angular/angular/pull/57816/commits/6a3153b37772c3120bdd156ea678050ed48a9c35
@lethttps://github.com/let
declaration with array when `preparingF…https://github.com/angular/angular/pull/57816/commits/6a3153b37772c3120bdd156ea678050ed48a9c35
6a3153bhttps://github.com/angular/angular/pull/57816/commits/6a3153b37772c3120bdd156ea678050ed48a9c35
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Sep 14, 2024 https://github.com/angular/angular/pull/57816#pullrequestreview-2305075582
View reviewed changes https://github.com/angular/angular/pull/57816/files/6a3153b37772c3120bdd156ea678050ed48a9c35
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/57816#pullrequestreview-2305075582
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#57816 (comment)https://github.com/angular/angular/pull/57816#discussion_r1759792452
Please reload this pagehttps://github.com/angular/angular/pull/57816
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Sep 14, 2024https://github.com/angular/angular/pull/57816#event-14260496084
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Sep 14, 2024https://github.com/angular/angular/pull/57816#issuecomment-2351112966
Presubmithttp://test/OCL:674692273:BASE:674692289:1726341208258:105a3b34
Please reload this pagehttps://github.com/angular/angular/pull/57816
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Sep 16, 2024https://github.com/angular/angular/pull/57816#issuecomment-2354006676
Please reload this pagehttps://github.com/angular/angular/pull/57816
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Sep 16, 2024https://github.com/angular/angular/pull/57816#event-14280998771
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Sep 16, 2024https://github.com/angular/angular/pull/57816#issuecomment-2354007097
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
Please reload this pagehttps://github.com/angular/angular/pull/57816
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 17, 2024https://github.com/angular/angular/pull/57816#issuecomment-2356025650
4231e8fhttps://github.com/angular/angular/commit/4231e8f28ffe8f55dddc2af0647b5b04fa8445d7
Please reload this pagehttps://github.com/angular/angular/pull/57816
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Sep 17, 2024 https://github.com/angular/angular/pull/57816#ref-commit-76709d5
https://github.com/JeanMeche
https://github.com/pkozlowski-opensource
fix(core): Handlehttps://github.com/angular/angular/commit/76709d5d6ec1f83e3f44641704b540636f91b5f4
@lethttps://github.com/let
declaration with array when `preparingForHydra…https://github.com/angular/angular/commit/76709d5d6ec1f83e3f44641704b540636f91b5f4
76709d5https://github.com/angular/angular/commit/76709d5d6ec1f83e3f44641704b540636f91b5f4
#57816https://github.com/angular/angular/pull/57816
#57816https://github.com/angular/angular/pull/57816
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
4231e8fhttps://github.com/angular/angular/commit/4231e8f28ffe8f55dddc2af0647b5b04fa8445d7
Sep 17, 2024https://github.com/angular/angular/pull/57816#event-14292423678
https://github.com/rajmcaitm
rajmcaitmhttps://github.com/rajmcaitm
Sep 20, 2024 https://github.com/angular/angular/pull/57816#ref-pullrequest-2538170433
[Snyk] Upgrade: , , , , , , , , , , bootstrap rajmcaitm/YashManagement#15 https://github.com/rajmcaitm/YashManagement/pull/15
https://github.com/gdemarchi-newf
gdemarchi-newfhttps://github.com/gdemarchi-newf
Sep 20, 2024 https://github.com/angular/angular/pull/57816#ref-pullrequest-2538921873
[Snyk] Upgrade: , , , , , , , , tslib, rxjs, zone.js Newforma/ad-file-upload#33 https://github.com/Newforma/ad-file-upload/pull/33
https://github.com/davidjbradshaw
davidjbradshawhttps://github.com/davidjbradshaw
Oct 3, 2024 https://github.com/angular/angular/pull/57816#ref-pullrequest-2563773133
[Snyk] Upgrade @angular/core from 18.2.5 to 18.2.6 davidjbradshaw/iframe-resizer#1344 https://github.com/davidjbradshaw/iframe-resizer/pull/1344
https://github.com/AlexanderPumaPucho
AlexanderPumaPuchohttps://github.com/AlexanderPumaPucho
Oct 12, 2024 https://github.com/angular/angular/pull/57816#ref-pullrequest-2582591252
[Snyk] Upgrade @angular/common from 18.1.2 to 18.2.5 AlexanderPumaPucho/angular#1 https://github.com/AlexanderPumaPucho/angular/pull/1
[Snyk] Upgrade @angular/compiler from 18.1.2 to 18.2.5 AlexanderPumaPucho/angular#2 https://github.com/AlexanderPumaPucho/angular/pull/2
[Snyk] Upgrade @angular/core from 18.1.2 to 18.2.5 AlexanderPumaPucho/angular#3 https://github.com/AlexanderPumaPucho/angular/pull/3
[Snyk] Upgrade @angular/forms from 18.1.2 to 18.2.5 AlexanderPumaPucho/angular#4 https://github.com/AlexanderPumaPucho/angular/pull/4
[Snyk] Upgrade @angular/platform-browser from 18.1.2 to 18.2.5 AlexanderPumaPucho/angular#5 https://github.com/AlexanderPumaPucho/angular/pull/5
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Oct 18, 2024https://github.com/angular/angular/pull/57816#issuecomment-2420900003
automatic conversation locking policyhttps://github.com/angular/angular/blob/f0fbced1c55bc8b8ed9df01cea99df42f3e7eae3/contributing-docs/auto-issue-locking.md
Please reload this pagehttps://github.com/angular/angular/pull/57816
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Oct 18, 2024https://github.com/angular/angular/pull/57816#event-14707973153
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F57816
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/57816/files/0ad7957bdda6bb1a413bc62df3811c6037a93e38
https://github.com/crisbeto
crisbeto https://github.com/crisbeto
https://github.com/angular/angular/pull/57816/files/0ad7957bdda6bb1a413bc62df3811c6037a93e38
Please reload this pagehttps://github.com/angular/angular/pull/57816
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/57816
https://github.com/JeanMeche
https://github.com/AndrewKushnir
https://github.com/pkozlowski-opensource
https://github.com/crisbeto
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.