René's URL Explorer Experiment


Title: fix(DomRenderer): assume boolean attributes when an attribute binding… by vicb · Pull Request #5761 · angular/angular · GitHub

Open Graph Title: fix(DomRenderer): assume boolean attributes when an attribute binding… by vicb · Pull Request #5761 · angular/angular

X Title: fix(DomRenderer): assume boolean attributes when an attribute binding… by vicb · Pull Request #5761 · angular/angular

Description: … evaluate to false BREAKING CHANGE: Renderer.setElementAttribute() attributeValue parameter could be anything (was a string). It is up to the implememtation to decide what to do with the value, The DomRenderer has been updated to remove the attribute when the expression evaluates to false (boolean). It used to set the attribute value to "false" (string). relates to #4150

Open Graph Description: … evaluate to false BREAKING CHANGE: Renderer.setElementAttribute() attributeValue parameter could be anything (was a string). It is up to the implememtation to decide what to do with the value, T...

X Description: … evaluate to false BREAKING CHANGE: Renderer.setElementAttribute() attributeValue parameter could be anything (was a string). It is up to the implememtation to decide what to do with the value, T...

Opengraph URL: https://github.com/angular/angular/pull/5761

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7104205c-6bce-8bb8-a75c-2981882a4c86
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA430:2F41E1:A33A5:D6303:6B01595A
html-safe-noncec31fbfb689ac6351e6d5c971e057db4ec419e1a5a40a09d67863c5a2fb8c1c52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDMwOjJGNDFFMTpBMzNBNTpENjMwMzo2QjAxNTk1QSIsInZpc2l0b3JfaWQiOiIxNzAwODE3NzQxMTg0ODUwMjY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac56adc96478ea135e9f8fbd636e12d276aade5a744dd8634f446d3641eea0be59
hovercard-subject-tagpull_request:53194940
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/5761/files
twitter:imagehttps://avatars.githubusercontent.com/u/248818?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/248818?s=400&v=4
og:image:alt… evaluate to false BREAKING CHANGE: Renderer.setElementAttribute() attributeValue parameter could be anything (was a string). It is up to the implememtation to decide what to do with the value, T...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/5761/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F5761%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F5761%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/5761/files
Reloadhttps://github.com/angular/angular/pull/5761/files
Reloadhttps://github.com/angular/angular/pull/5761/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
vicbhttps://github.com/vicb
angular:masterhttps://github.com/angular/angular/tree/master
vicb:1209-boolhttps://github.com/vicb/angular/tree/1209-bool
Conversation 24 https://github.com/angular/angular/pull/5761
Commits 1 https://github.com/angular/angular/pull/5761/commits
Checks 0 https://github.com/angular/angular/pull/5761/checks
Files changed https://github.com/angular/angular/pull/5761/files
Please reload this pagehttps://github.com/angular/angular/pull/5761/files
fix(DomRenderer): assume boolean attributes when an attribute binding… https://github.com/angular/angular/pull/5761/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/5761/files
12a2ac8 fix(DomRenderer): assume boolean attributes when an attribute binding… vicb Dec 9, 2015 https://github.com/angular/angular/pull/5761/commits/12a2ac8a799a105dad40288736f1cc0341c62811
Clear filters https://github.com/angular/angular/pull/5761/files
Please reload this pagehttps://github.com/angular/angular/pull/5761/files
Please reload this pagehttps://github.com/angular/angular/pull/5761/files
view.ts https://github.com/angular/angular/pull/5761/files#diff-05b6778a181328e3f9f3c19c47e77b58e295d03c0818c71658d0cbef04d2f056
api.ts https://github.com/angular/angular/pull/5761/files#diff-9f397bfa3168b6c506e99788fd27521d0925cc2b7c8f51b598c6ccee224842aa
dom_renderer.ts https://github.com/angular/angular/pull/5761/files#diff-06d813dd6ed96adc6cbaf64ddf99d928ee45ae62158abdc4bc7b1c8ee553b028
renderer.ts https://github.com/angular/angular/pull/5761/files#diff-e82721b8ac77dd41e440c373f8c491cca6621343591b122d9b201dc8f62e067e
dom_renderer_integration_spec.ts https://github.com/angular/angular/pull/5761/files#diff-252fc0e7943ca66e4b30b777cf1ad0cea9955b0038307134b1db019f2c56c5de
button.ts https://github.com/angular/angular/pull/5761/files#diff-b5d4c67f24dec252a27c9cad1429101cc443d19f4ef6dd27d23ecf1aefa296a9
checkbox.ts https://github.com/angular/angular/pull/5761/files#diff-3d3520056665405afdf28ce13ae6931faf2297846acb23e59e76991331e866e4
radio_button.ts https://github.com/angular/angular/pull/5761/files#diff-9b9f2f083219c08aca4799dc80c7942b5e6304a4b1bfc269cdca554de3633fe5
switch.ts https://github.com/angular/angular/pull/5761/files#diff-cd486fb5cfaf0c9b5fc5399c8ebdeca088bc1b480714e583f174601c099be998
modules/angular2/src/core/linker/view.tshttps://github.com/angular/angular/pull/5761/files#diff-05b6778a181328e3f9f3c19c47e77b58e295d03c0818c71658d0cbef04d2f056
View file https://github.com/vicb/angular/blob/12a2ac8a799a105dad40288736f1cc0341c62811/modules/angular2/src/core/linker/view.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5761/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5761/files#diff-05b6778a181328e3f9f3c19c47e77b58e295d03c0818c71658d0cbef04d2f056
https://github.com/angular/angular/pull/5761/files#diff-05b6778a181328e3f9f3c19c47e77b58e295d03c0818c71658d0cbef04d2f056
modules/angular2/src/core/render/api.tshttps://github.com/angular/angular/pull/5761/files#diff-9f397bfa3168b6c506e99788fd27521d0925cc2b7c8f51b598c6ccee224842aa
View file https://github.com/vicb/angular/blob/12a2ac8a799a105dad40288736f1cc0341c62811/modules/angular2/src/core/render/api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5761/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5761/files#diff-9f397bfa3168b6c506e99788fd27521d0925cc2b7c8f51b598c6ccee224842aa
https://github.com/angular/angular/pull/5761/files#diff-9f397bfa3168b6c506e99788fd27521d0925cc2b7c8f51b598c6ccee224842aa
modules/angular2/src/platform/dom/dom_renderer.tshttps://github.com/angular/angular/pull/5761/files#diff-06d813dd6ed96adc6cbaf64ddf99d928ee45ae62158abdc4bc7b1c8ee553b028
View file https://github.com/vicb/angular/blob/12a2ac8a799a105dad40288736f1cc0341c62811/modules/angular2/src/platform/dom/dom_renderer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5761/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5761/files#diff-06d813dd6ed96adc6cbaf64ddf99d928ee45ae62158abdc4bc7b1c8ee553b028
https://github.com/angular/angular/pull/5761/files#diff-06d813dd6ed96adc6cbaf64ddf99d928ee45ae62158abdc4bc7b1c8ee553b028
modules/angular2/src/web_workers/worker/renderer.tshttps://github.com/angular/angular/pull/5761/files#diff-e82721b8ac77dd41e440c373f8c491cca6621343591b122d9b201dc8f62e067e
View file https://github.com/vicb/angular/blob/12a2ac8a799a105dad40288736f1cc0341c62811/modules/angular2/src/web_workers/worker/renderer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5761/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5761/files#diff-e82721b8ac77dd41e440c373f8c491cca6621343591b122d9b201dc8f62e067e
https://github.com/angular/angular/pull/5761/files#diff-e82721b8ac77dd41e440c373f8c491cca6621343591b122d9b201dc8f62e067e
modules/angular2/test/platform/dom/dom_renderer_integration_spec.tshttps://github.com/angular/angular/pull/5761/files#diff-252fc0e7943ca66e4b30b777cf1ad0cea9955b0038307134b1db019f2c56c5de
View file https://github.com/vicb/angular/blob/12a2ac8a799a105dad40288736f1cc0341c62811/modules/angular2/test/platform/dom/dom_renderer_integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5761/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5761/files#diff-252fc0e7943ca66e4b30b777cf1ad0cea9955b0038307134b1db019f2c56c5de
modules/angular2_material/src/components/button/button.tshttps://github.com/angular/angular/pull/5761/files#diff-b5d4c67f24dec252a27c9cad1429101cc443d19f4ef6dd27d23ecf1aefa296a9
View file https://github.com/vicb/angular/blob/12a2ac8a799a105dad40288736f1cc0341c62811/modules/angular2_material/src/components/button/button.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5761/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5761/files#diff-b5d4c67f24dec252a27c9cad1429101cc443d19f4ef6dd27d23ecf1aefa296a9
https://github.com/angular/angular/pull/5761/files#diff-b5d4c67f24dec252a27c9cad1429101cc443d19f4ef6dd27d23ecf1aefa296a9
https://github.com/angular/angular/pull/5761/files#diff-b5d4c67f24dec252a27c9cad1429101cc443d19f4ef6dd27d23ecf1aefa296a9
modules/angular2_material/src/components/checkbox/checkbox.tshttps://github.com/angular/angular/pull/5761/files#diff-3d3520056665405afdf28ce13ae6931faf2297846acb23e59e76991331e866e4
View file https://github.com/vicb/angular/blob/12a2ac8a799a105dad40288736f1cc0341c62811/modules/angular2_material/src/components/checkbox/checkbox.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5761/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5761/files#diff-3d3520056665405afdf28ce13ae6931faf2297846acb23e59e76991331e866e4
https://github.com/angular/angular/pull/5761/files#diff-3d3520056665405afdf28ce13ae6931faf2297846acb23e59e76991331e866e4
modules/angular2_material/src/components/radio/radio_button.tshttps://github.com/angular/angular/pull/5761/files#diff-9b9f2f083219c08aca4799dc80c7942b5e6304a4b1bfc269cdca554de3633fe5
View file https://github.com/vicb/angular/blob/12a2ac8a799a105dad40288736f1cc0341c62811/modules/angular2_material/src/components/radio/radio_button.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5761/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5761/files#diff-9b9f2f083219c08aca4799dc80c7942b5e6304a4b1bfc269cdca554de3633fe5
https://github.com/angular/angular/pull/5761/files#diff-9b9f2f083219c08aca4799dc80c7942b5e6304a4b1bfc269cdca554de3633fe5
https://github.com/angular/angular/pull/5761/files#diff-9b9f2f083219c08aca4799dc80c7942b5e6304a4b1bfc269cdca554de3633fe5
https://github.com/angular/angular/pull/5761/files#diff-9b9f2f083219c08aca4799dc80c7942b5e6304a4b1bfc269cdca554de3633fe5
modules/angular2_material/src/components/switcher/switch.tshttps://github.com/angular/angular/pull/5761/files#diff-cd486fb5cfaf0c9b5fc5399c8ebdeca088bc1b480714e583f174601c099be998
View file https://github.com/vicb/angular/blob/12a2ac8a799a105dad40288736f1cc0341c62811/modules/angular2_material/src/components/switcher/switch.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5761/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5761/files#diff-cd486fb5cfaf0c9b5fc5399c8ebdeca088bc1b480714e583f174601c099be998
https://github.com/angular/angular/pull/5761/files#diff-cd486fb5cfaf0c9b5fc5399c8ebdeca088bc1b480714e583f174601c099be998
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.