René's URL Explorer Experiment


Title: HtmlLexer: allow "<" in text nodes by vicb · Pull Request #5657 · angular/angular · GitHub

Open Graph Title: HtmlLexer: allow "<" in text nodes by vicb · Pull Request #5657 · angular/angular

X Title: HtmlLexer: allow "<" in text nodes by vicb · Pull Request #5657 · angular/angular

Description: As reported in #5550, {{ a < b ? c : d }} would throw because the lexer interpret "<" as the start of an element. While the error is legit according to HTML specs, replacing < with > would be ugly in angular expression. This use case is probable with Angular and browsers would handle it. This PR makes the lexer more lenient and <... is now interpreted as a text node when it would otherwise start a malformed start tag. A drawback is that some other error cases could not be reported any more, see the updates in the spec file for more info. Notes: The second commit fixes a bug that was allowing spaces in between < and the tag name This lenient behavior does not apply for malformed end tag

Open Graph Description: As reported in #5550, {{ a < b ? c : d }} would throw because the lexer interpret "<" as the start of an element. While the error is legit according to HTML specs, replacing < wi...

X Description: As reported in #5550, {{ a &lt; b ? c : d }} would throw because the lexer interpret &quot;&lt;&quot; as the start of an element. While the error is legit according to HTML specs, r...

Opengraph URL: https://github.com/angular/angular/pull/5657

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1afc32b2-419f-6232-f2b2-4be530afc815
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEE3C:ADA9D:24AD145:2F1196B:6B017BE4
html-safe-nonce6b1e4eca4a1a2f870c491d267d309cc75a1d815af6f6b44e5a16894c4d65f758
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRTNDOkFEQTlEOjI0QUQxNDU6MkYxMTk2Qjo2QjAxN0JFNCIsInZpc2l0b3JfaWQiOiIzMTQ3MTQxMTU3NzA0NzkzMDYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac63204743b920091854a8a85a4445d544eb1a769bbd7ab58611eaf916bfaa4a9b
hovercard-subject-tagpull_request:52790764
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/5657/files
twitter:imagehttps://avatars.githubusercontent.com/u/248818?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/248818?s=400&v=4
og:image:altAs reported in #5550, {{ a < b ? c : d }} would throw because the lexer interpret "<" as the start of an element. While the error is legit according to HTML specs, replacing < wi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/5657/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F5657%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F5657%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/5657/files
Reloadhttps://github.com/angular/angular/pull/5657/files
Reloadhttps://github.com/angular/angular/pull/5657/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
vicbhttps://github.com/vicb
angular:masterhttps://github.com/angular/angular/tree/master
vicb:1206-lexLThttps://github.com/vicb/angular/tree/1206-lexLT
Conversation 3 https://github.com/angular/angular/pull/5657
Commits 2 https://github.com/angular/angular/pull/5657/commits
Checks 0 https://github.com/angular/angular/pull/5657/checks
Files changed https://github.com/angular/angular/pull/5657/files
Please reload this pagehttps://github.com/angular/angular/pull/5657/files
HtmlLexer: allow "<" in text nodes https://github.com/angular/angular/pull/5657/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/5657/files
44cb3e3 feat(HtmlLexer): allow "<" in text tokens vicb Dec 6, 2015 https://github.com/angular/angular/pull/5657/commits/44cb3e3d64109125f852412d897e365148fd8061
36da998 fix(HtmlLexer): tag name must follow "<" without space vicb Dec 6, 2015 https://github.com/angular/angular/pull/5657/commits/36da998cfd024703c0ba83907c7ca1ee37f1d315
Clear filters https://github.com/angular/angular/pull/5657/files
Please reload this pagehttps://github.com/angular/angular/pull/5657/files
Please reload this pagehttps://github.com/angular/angular/pull/5657/files
html_lexer.ts https://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
html_lexer_spec.ts https://github.com/angular/angular/pull/5657/files#diff-d62693c61e4b4e2d1f16831d5e0cb8b2bf9875c365a85725271c5f30e950b68d
modules/angular2/src/compiler/html_lexer.tshttps://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
View file https://github.com/vicb/angular/blob/36da998cfd024703c0ba83907c7ca1ee37f1d315/modules/angular2/src/compiler/html_lexer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5657/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
https://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
https://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
https://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
https://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
https://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
https://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
https://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
https://github.com/angular/angular/pull/5657/files#diff-c0a89f3fe8264f55fc70e4ba5a0c440f08288c17c01faeb40f000756fb483f1b
modules/angular2/test/compiler/html_lexer_spec.tshttps://github.com/angular/angular/pull/5657/files#diff-d62693c61e4b4e2d1f16831d5e0cb8b2bf9875c365a85725271c5f30e950b68d
View file https://github.com/vicb/angular/blob/36da998cfd024703c0ba83907c7ca1ee37f1d315/modules/angular2/test/compiler/html_lexer_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5657/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5657/files#diff-d62693c61e4b4e2d1f16831d5e0cb8b2bf9875c365a85725271c5f30e950b68d
https://github.com/angular/angular/pull/5657/files#diff-d62693c61e4b4e2d1f16831d5e0cb8b2bf9875c365a85725271c5f30e950b68d
https://github.com/angular/angular/pull/5657/files#diff-d62693c61e4b4e2d1f16831d5e0cb8b2bf9875c365a85725271c5f30e950b68d
https://github.com/angular/angular/pull/5657/files#diff-d62693c61e4b4e2d1f16831d5e0cb8b2bf9875c365a85725271c5f30e950b68d
https://github.com/angular/angular/pull/5657/files#diff-d62693c61e4b4e2d1f16831d5e0cb8b2bf9875c365a85725271c5f30e950b68d
https://github.com/angular/angular/pull/5657/files#diff-d62693c61e4b4e2d1f16831d5e0cb8b2bf9875c365a85725271c5f30e950b68d
https://github.com/angular/angular/pull/5657/files#diff-d62693c61e4b4e2d1f16831d5e0cb8b2bf9875c365a85725271c5f30e950b68d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.