René's URL Explorer Experiment


Title: fix(zone.js): do not mutate event listener options (may be readonly) by arturovt · Pull Request #55796 · angular/angular · GitHub

Open Graph Title: fix(zone.js): do not mutate event listener options (may be readonly) by arturovt · Pull Request #55796 · angular/angular

X Title: fix(zone.js): do not mutate event listener options (may be readonly) by arturovt · Pull Request #55796 · angular/angular

Description: Prior to this commit, event listener options were mutated directly, for example, options.signal = undefined or options.once = false. This issue arises in apps using third-party libraries where the responsibility lies with the library provider. Some libraries, like WalletConnect, pass an abort controller as addEventListener options. Because the abort controller has the signal property, this is a valid case. Thus, mutating options would throw an error since signal is a readonly property. Even though zone.js is being deprecated as Angular moves towards zoneless change detection, this fix is necessary for apps that still use zone.js and cannot migrate to zoneless change detection because they rely on third-party libraries and are not responsible for the code used in them. Closes #54142

Open Graph Description: Prior to this commit, event listener options were mutated directly, for example, options.signal = undefined or options.once = false. This issue arises in apps using third-party libraries where the ...

X Description: Prior to this commit, event listener options were mutated directly, for example, options.signal = undefined or options.once = false. This issue arises in apps using third-party libraries where the ...

Opengraph URL: https://github.com/angular/angular/pull/55796

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:21893998-6ae2-d8c3-182c-4552c4cd4534
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA536:ADA9D:1F94066:2888AB3:6B015CD4
html-safe-nonce0f86ba8775ece571a2c1ac05c817b0e860cf5cedb73cd0850c079fc982dc5eeb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTM2OkFEQTlEOjFGOTQwNjY6Mjg4OEFCMzo2QjAxNUNENCIsInZpc2l0b3JfaWQiOiI1NzE2MjYyMDU4Njg1NzE3NzE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0ad54a51dff398d9d0b2264ab3dbfc37b8a2230d8cc1c5edd42f60509aa76d5d
hovercard-subject-tagpull_request:1869550563
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/55796/files
twitter:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
og:image:altPrior to this commit, event listener options were mutated directly, for example, options.signal = undefined or options.once = false. This issue arises in apps using third-party libraries where the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/55796/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F55796%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F55796%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/55796/files
Reloadhttps://github.com/angular/angular/pull/55796/files
Reloadhttps://github.com/angular/angular/pull/55796/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
arturovthttps://github.com/arturovt
angular:mainhttps://github.com/angular/angular/tree/main
arturovt:fix/54142-zone-achttps://github.com/arturovt/angular/tree/fix/54142-zone-ac
Conversation 7 https://github.com/angular/angular/pull/55796
Commits 1 https://github.com/angular/angular/pull/55796/commits
Checks 0 https://github.com/angular/angular/pull/55796/checks
Files changed https://github.com/angular/angular/pull/55796/files
Please reload this pagehttps://github.com/angular/angular/pull/55796/files
fix(zone.js): do not mutate event listener options (may be readonly) https://github.com/angular/angular/pull/55796/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/55796/files
6679674 fix(zone.js): do not mutate event listener options (may be readonly) arturovt May 14, 2024 https://github.com/angular/angular/pull/55796/commits/6679674d9980d8ea1e0f4174f70fa9b5dd1e4377
Clear filters https://github.com/angular/angular/pull/55796/files
Please reload this pagehttps://github.com/angular/angular/pull/55796/files
Please reload this pagehttps://github.com/angular/angular/pull/55796/files
events.ts https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
browser.spec.ts https://github.com/angular/angular/pull/55796/files#diff-9e399a075e24c6b6ce45c38f98c390f713df4dae4c6a54bbed36bd3961e28754
packages/zone.js/lib/common/events.tshttps://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
View file https://github.com/arturovt/angular/blob/6679674d9980d8ea1e0f4174f70fa9b5dd1e4377/packages/zone.js/lib/common/events.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55796/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
https://github.com/angular/angular/pull/55796/files#diff-08d8fc6c9e986dfc70c1cb881850be682b6294bf645e2d4b53b74a9c4a358c3a
packages/zone.js/test/browser/browser.spec.tshttps://github.com/angular/angular/pull/55796/files#diff-9e399a075e24c6b6ce45c38f98c390f713df4dae4c6a54bbed36bd3961e28754
View file https://github.com/arturovt/angular/blob/6679674d9980d8ea1e0f4174f70fa9b5dd1e4377/packages/zone.js/test/browser/browser.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55796/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55796/files#diff-9e399a075e24c6b6ce45c38f98c390f713df4dae4c6a54bbed36bd3961e28754
https://github.com/angular/angular/pull/55796/files#diff-9e399a075e24c6b6ce45c38f98c390f713df4dae4c6a54bbed36bd3961e28754
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.