René's URL Explorer Experiment


Title: fix(http): resolve `withRequestsMadeViaParent` behavior with `withFetch` by alan-agius4 · Pull Request #55652 · angular/angular · GitHub

Open Graph Title: fix(http): resolve `withRequestsMadeViaParent` behavior with `withFetch` by alan-agius4 · Pull Request #55652 · angular/angular

X Title: fix(http): resolve `withRequestsMadeViaParent` behavior with `withFetch` by alan-agius4 · Pull Request #55652 · angular/angular

Description: This commit addresses dependency injection defects when using the withFetch API. Formerly, utilizing withFetch led to the automatic setting of HttpBackend to FetchBackend, which proved problematic in certain scenarios. Notably, conflicts arose when integrating withRequestsMadeViaParent and manually overriding tokens, as observed in instances like InMemoryWebApiModule. Reviewer note: I suggest that you enable hide whitespace.

Open Graph Description: This commit addresses dependency injection defects when using the withFetch API. Formerly, utilizing withFetch led to the automatic setting of HttpBackend to FetchBackend, which proved problematic ...

X Description: This commit addresses dependency injection defects when using the withFetch API. Formerly, utilizing withFetch led to the automatic setting of HttpBackend to FetchBackend, which proved problematic ...

Opengraph URL: https://github.com/angular/angular/pull/55652

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c23613a3-545b-7cca-91c6-3ba7017384bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC32E:347701:81C3BD:B25937:6AFDF2A2
html-safe-nonced76f70fe6471d76dd4c52fb2d50f75a22f76666cd0f6c463e140a523bf79b857
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzJFOjM0NzcwMTo4MUMzQkQ6QjI1OTM3OjZBRkRGMkEyIiwidmlzaXRvcl9pZCI6IjcyOTM2MzYzNzc3ODkxOTkwMTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac01f0d3c3efb1cf908a803615a72b17ac03df10bcec69849648465651ab3fedde
hovercard-subject-tagpull_request:1853012140
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/55652/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altThis commit addresses dependency injection defects when using the withFetch API. Formerly, utilizing withFetch led to the automatic setting of HttpBackend to FetchBackend, which proved problematic ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedd812ec581ecac95855f5ec917ef9827506c39a9da1443f43ddb4179a46471eb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32ac708bac264dafdc28e10ff49b4d137f0c34a7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/55652/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F55652%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F55652%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/55652/files
Reloadhttps://github.com/angular/angular/pull/55652/files
Reloadhttps://github.com/angular/angular/pull/55652/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues833 (833)https://github.com/angular/angular/issues
Pull requests122 (122)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular/tree/main
alan-agius4:http-fetchhttps://github.com/alan-agius4/angular/tree/http-fetch
Conversation 5 https://github.com/angular/angular/pull/55652
Commits 1 https://github.com/angular/angular/pull/55652/commits
Checks 0 https://github.com/angular/angular/pull/55652/checks
Files changed https://github.com/angular/angular/pull/55652/files
Please reload this pagehttps://github.com/angular/angular/pull/55652/files
fix(http): resolve withRequestsMadeViaParent behavior with withFetch https://github.com/angular/angular/pull/55652/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/55652/files
501a6af fix(http): resolve `withRequestsMadeViaParent` behavior with `withFetch` alan-agius4 May 3, 2024 https://github.com/angular/angular/pull/55652/commits/501a6af3d655976c83dab43eb4762622a2fac524
Clear filters https://github.com/angular/angular/pull/55652/files
Please reload this pagehttps://github.com/angular/angular/pull/55652/files
Please reload this pagehttps://github.com/angular/angular/pull/55652/files
app.config.ts https://github.com/angular/angular/pull/55652/files#diff-7c5307af9e24d8d67cef44bc811bb0fb538c0a177723a5a0be4d2d43d4f7905e
interceptor.ts https://github.com/angular/angular/pull/55652/files#diff-b37862b4311dc76823402becf69e9e46b3b1e0c8130adbacc56a19366da4789b
private_export.ts https://github.com/angular/angular/pull/55652/files#diff-cfd93ac46b9e8dd13d75cbb5389257a63239373e182cead3fa985e2a58defd36
provider.ts https://github.com/angular/angular/pull/55652/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
provider_spec.ts https://github.com/angular/angular/pull/55652/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
http-client-in-memory-web-api-module.ts https://github.com/angular/angular/pull/55652/files#diff-3ddcb1dfad30badd780a35ba179c8a39ded0aec5a4cafb0f3e274ef459e0c539
in-memory-web-api-module.ts https://github.com/angular/angular/pull/55652/files#diff-fe7dddd9a2fec449385c41bcc40914a004d0aa0ad7adb3236d0666b6501f6de4
adev/src/content/examples/ssr/src/app/app.config.tshttps://github.com/angular/angular/pull/55652/files#diff-7c5307af9e24d8d67cef44bc811bb0fb538c0a177723a5a0be4d2d43d4f7905e
View file https://github.com/alan-agius4/angular/blob/501a6af3d655976c83dab43eb4762622a2fac524/adev/src/content/examples/ssr/src/app/app.config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55652/files#diff-7c5307af9e24d8d67cef44bc811bb0fb538c0a177723a5a0be4d2d43d4f7905e
https://github.com/angular/angular/pull/55652/files#diff-7c5307af9e24d8d67cef44bc811bb0fb538c0a177723a5a0be4d2d43d4f7905e
packages/common/http/src/interceptor.tshttps://github.com/angular/angular/pull/55652/files#diff-b37862b4311dc76823402becf69e9e46b3b1e0c8130adbacc56a19366da4789b
View file https://github.com/alan-agius4/angular/blob/501a6af3d655976c83dab43eb4762622a2fac524/packages/common/http/src/interceptor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55652/files#diff-b37862b4311dc76823402becf69e9e46b3b1e0c8130adbacc56a19366da4789b
https://github.com/angular/angular/pull/55652/files#diff-b37862b4311dc76823402becf69e9e46b3b1e0c8130adbacc56a19366da4789b
https://github.com/angular/angular/pull/55652/files#diff-b37862b4311dc76823402becf69e9e46b3b1e0c8130adbacc56a19366da4789b
https://github.com/angular/angular/pull/55652/files#diff-b37862b4311dc76823402becf69e9e46b3b1e0c8130adbacc56a19366da4789b
packages/common/http/src/private_export.tshttps://github.com/angular/angular/pull/55652/files#diff-cfd93ac46b9e8dd13d75cbb5389257a63239373e182cead3fa985e2a58defd36
View file https://github.com/alan-agius4/angular/blob/501a6af3d655976c83dab43eb4762622a2fac524/packages/common/http/src/private_export.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55652/files#diff-cfd93ac46b9e8dd13d75cbb5389257a63239373e182cead3fa985e2a58defd36
packages/common/http/src/provider.tshttps://github.com/angular/angular/pull/55652/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
View file https://github.com/alan-agius4/angular/blob/501a6af3d655976c83dab43eb4762622a2fac524/packages/common/http/src/provider.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55652/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
https://github.com/angular/angular/pull/55652/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
https://github.com/angular/angular/pull/55652/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
https://github.com/angular/angular/pull/55652/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
https://github.com/angular/angular/pull/55652/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
alan-agius4https://github.com/alan-agius4
May 3, 2024https://github.com/angular/angular/pull/55652/files#r1588907931
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/55652/files
packages/common/http/test/provider_spec.tshttps://github.com/angular/angular/pull/55652/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
View file https://github.com/alan-agius4/angular/blob/501a6af3d655976c83dab43eb4762622a2fac524/packages/common/http/test/provider_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55652/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
https://github.com/angular/angular/pull/55652/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
https://github.com/angular/angular/pull/55652/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
https://github.com/angular/angular/pull/55652/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
https://github.com/angular/angular/pull/55652/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
Please reload this pagehttps://github.com/angular/angular/pull/55652/files
https://github.com/angular/angular/pull/55652/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
packages/misc/angular-in-memory-web-api/src/http-client-in-memory-web-api-module.tshttps://github.com/angular/angular/pull/55652/files#diff-3ddcb1dfad30badd780a35ba179c8a39ded0aec5a4cafb0f3e274ef459e0c539
View file https://github.com/alan-agius4/angular/blob/501a6af3d655976c83dab43eb4762622a2fac524/packages/misc/angular-in-memory-web-api/src/http-client-in-memory-web-api-module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55652/files#diff-3ddcb1dfad30badd780a35ba179c8a39ded0aec5a4cafb0f3e274ef459e0c539
https://github.com/angular/angular/pull/55652/files#diff-3ddcb1dfad30badd780a35ba179c8a39ded0aec5a4cafb0f3e274ef459e0c539
https://github.com/angular/angular/pull/55652/files#diff-3ddcb1dfad30badd780a35ba179c8a39ded0aec5a4cafb0f3e274ef459e0c539
https://github.com/angular/angular/pull/55652/files#diff-3ddcb1dfad30badd780a35ba179c8a39ded0aec5a4cafb0f3e274ef459e0c539
packages/misc/angular-in-memory-web-api/src/in-memory-web-api-module.tshttps://github.com/angular/angular/pull/55652/files#diff-fe7dddd9a2fec449385c41bcc40914a004d0aa0ad7adb3236d0666b6501f6de4
View file https://github.com/alan-agius4/angular/blob/501a6af3d655976c83dab43eb4762622a2fac524/packages/misc/angular-in-memory-web-api/src/in-memory-web-api-module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55652/files#diff-fe7dddd9a2fec449385c41bcc40914a004d0aa0ad7adb3236d0666b6501f6de4
https://github.com/angular/angular/pull/55652/files#diff-fe7dddd9a2fec449385c41bcc40914a004d0aa0ad7adb3236d0666b6501f6de4
https://github.com/angular/angular/pull/55652/files#diff-fe7dddd9a2fec449385c41bcc40914a004d0aa0ad7adb3236d0666b6501f6de4
https://github.com/angular/angular/pull/55652/files#diff-fe7dddd9a2fec449385c41bcc40914a004d0aa0ad7adb3236d0666b6501f6de4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.