René's URL Explorer Experiment


Title: fix(http): throw error if `withFetch()` and `withRequestsMadeViaParen… by rainerhahnekamp · Pull Request #55394 · angular/angular · GitHub

Open Graph Title: fix(http): throw error if `withFetch()` and `withRequestsMadeViaParen… by rainerhahnekamp · Pull Request #55394 · angular/angular

X Title: fix(http): throw error if `withFetch()` and `withRequestsMadeViaParen… by rainerhahnekamp · Pull Request #55394 · angular/angular

Description: These changes will ensure that an error is thrown when withRequestsMadeViaParent() and withFetch() are used together in the same call to provideHttpClient(), as this configuration is contradictory and would lead to problems in the execution, i.e. the interceptors from the parent's don't run. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? If withFetch and withRequestsMadeViaParent() run together, the parents' interceptors don't work, and the user might not know why. What is the new behavior? It is the same as before, but with an additional error message during the dev mode. Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: These changes will ensure that an error is thrown when withRequestsMadeViaParent() and withFetch() are used together in the same call to provideHttpClient(), as this configuration is contradictory ...

X Description: These changes will ensure that an error is thrown when withRequestsMadeViaParent() and withFetch() are used together in the same call to provideHttpClient(), as this configuration is contradictory ...

Opengraph URL: https://github.com/angular/angular/pull/55394

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ecc12be7-6fbd-7525-c455-a19052acc272
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8D6:2D1E5E:1BC132:243C07:6AFE48F6
html-safe-nonce4d506535212f134603a1258df1610cb604498d6724d20a1e696fb1c80901469d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEQ2OjJEMUU1RToxQkMxMzI6MjQzQzA3OjZBRkU0OEY2IiwidmlzaXRvcl9pZCI6IjI1NjYzMTA2MjQwNjk4MzA5MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2435141a67a9db1bffeb84555af9767258e60f954725818656c745c4049c47e9
hovercard-subject-tagpull_request:1829191360
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/55394/files
twitter:imagehttps://avatars.githubusercontent.com/u/5721205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5721205?s=400&v=4
og:image:altThese changes will ensure that an error is thrown when withRequestsMadeViaParent() and withFetch() are used together in the same call to provideHttpClient(), as this configuration is contradictory ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef1a5901e2377b0af2a0b303f9528678f1475d04b9219dca1e993344196eaa07c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasece393ea11ad276623b946bc9663d3e7d6f564275
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/55394/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F55394%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F55394%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/55394/files
Reloadhttps://github.com/angular/angular/pull/55394/files
Reloadhttps://github.com/angular/angular/pull/55394/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests124 (124)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
rainerhahnekamphttps://github.com/rainerhahnekamp
angular:mainhttps://github.com/angular/angular/tree/main
rainerhahnekamp:fix-http-fetch-parent-mismatchhttps://github.com/rainerhahnekamp/angular/tree/fix-http-fetch-parent-mismatch
Conversation 7 https://github.com/angular/angular/pull/55394
Commits 1 https://github.com/angular/angular/pull/55394/commits
Checks 0 https://github.com/angular/angular/pull/55394/checks
Files changed https://github.com/angular/angular/pull/55394/files
Please reload this pagehttps://github.com/angular/angular/pull/55394/files
fix(http): throw error if withFetch() and `withRequestsMadeViaParen… https://github.com/angular/angular/pull/55394/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/55394/files
88f2cac fix(http): throw error if `withFetch()` and `withRequestsMadeViaParen… rainerhahnekamp Apr 18, 2024 https://github.com/angular/angular/pull/55394/commits/88f2cac00ab13b45fb9e5a6baf0e6630989a0c80
Clear filters https://github.com/angular/angular/pull/55394/files
Please reload this pagehttps://github.com/angular/angular/pull/55394/files
Please reload this pagehttps://github.com/angular/angular/pull/55394/files
provider.ts https://github.com/angular/angular/pull/55394/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
provider_spec.ts https://github.com/angular/angular/pull/55394/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
packages/common/http/src/provider.tshttps://github.com/angular/angular/pull/55394/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
View file https://github.com/rainerhahnekamp/angular/blob/88f2cac00ab13b45fb9e5a6baf0e6630989a0c80/packages/common/http/src/provider.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55394/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55394/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
https://github.com/angular/angular/pull/55394/files#diff-420f602453fb6113c5b5e1c62eff631aaabe37cf884726749e5b278a9a397354
packages/common/http/test/provider_spec.tshttps://github.com/angular/angular/pull/55394/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
View file https://github.com/rainerhahnekamp/angular/blob/88f2cac00ab13b45fb9e5a6baf0e6630989a0c80/packages/common/http/test/provider_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55394/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55394/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
https://github.com/angular/angular/pull/55394/files#diff-0dec0e7cd5fa1f761c0db8b21f4ab31d4ccfa13f4702bf8c874f646929019df0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.