René's URL Explorer Experiment


Title: build(docs-infra): fix version mismatch of local built packages by devversion · Pull Request #55282 · angular/angular · GitHub

Open Graph Title: build(docs-infra): fix version mismatch of local built packages by devversion · Pull Request #55282 · angular/angular

X Title: build(docs-infra): fix version mismatch of local built packages by devversion · Pull Request #55282 · angular/angular

Description: There is quite some trickery going on with the adev build related to local packages: Adev builds using npm packages from /node_modules At runtime, we are adding HEAD packages for e.g. @angular/core to the bundles. At build time, the CLI, or Angular devkit may accidentally resolve to @angular/core from /node_modules/— which is the core version from npm, transitively installed via @angular/docs. This causes a version mismatch, leading to issues like: CLI throwing because of a mismatch. #54858 (comment) Compiler changes not being picked up. #54858 (comment) This commit attempts to fix this by: Linking all Angular HEAD packages into adev/node_modules. The current logic attempts to link into /node_modules, but this does not override existing @angular/core! Linking all direct external NPM packages, like @angular_devkit/build-angular into adev/node_modules without their transitive deps. This allows proper resolution of e.g. compiler as node looks in adev/node_modules first, and falls back for the rest to the execroot node_modules, or symlink target destination (if preserveSymlinks=false). Note: This is still not 100% ideal because a direct external NPM dependency may have a transitive dependency that has another transitive dependency on @angular/core. In those cases, the may be a conflict that is not resolvable until we switch to a Bazel toolchain with better first party resolution support. Related to: #54858 (not closing because a real long-term sustainable fix is a better toolchain)

Open Graph Description: There is quite some trickery going on with the adev build related to local packages: Adev builds using npm packages from /node_modules At runtime, we are adding HEAD packages for e.g. @angular/cor...

X Description: There is quite some trickery going on with the adev build related to local packages: Adev builds using npm packages from /node_modules At runtime, we are adding HEAD packages for e.g. @angular/cor...

Opengraph URL: https://github.com/angular/angular/pull/55282

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8fd9dfa6-da6c-36ee-7a38-bef308f98753
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0C2:BBAAA:1C91E89:259FEF2:6B01546B
html-safe-nonce597d019540de8c79c1dfc530992bd5316cd7dae69ef5974f8e46ee9d0c0ab9ed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEMyOkJCQUFBOjFDOTFFODk6MjU5RkVGMjo2QjAxNTQ2QiIsInZpc2l0b3JfaWQiOiI2MTgxNDAwNzc2MjU1MDM0NDc1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1c9be9f86a62a6019ecb30428d978a3fcd47bcb3e0491e4b25f11aa2e7c51950
hovercard-subject-tagpull_request:1816149515
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/55282/files
twitter:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
og:image:altThere is quite some trickery going on with the adev build related to local packages: Adev builds using npm packages from /node_modules At runtime, we are adding HEAD packages for e.g. @angular/cor...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/55282/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F55282%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F55282%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/55282/files
Reloadhttps://github.com/angular/angular/pull/55282/files
Reloadhttps://github.com/angular/angular/pull/55282/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
devversionhttps://github.com/devversion
angular:mainhttps://github.com/angular/angular/tree/main
devversion:filter-transitive-depshttps://github.com/devversion/angular/tree/filter-transitive-deps
Conversation 5 https://github.com/angular/angular/pull/55282
Commits 3 https://github.com/angular/angular/pull/55282/commits
Checks 0 https://github.com/angular/angular/pull/55282/checks
Files changed https://github.com/angular/angular/pull/55282/files
Please reload this pagehttps://github.com/angular/angular/pull/55282/files
build(docs-infra): fix version mismatch of local built packages https://github.com/angular/angular/pull/55282/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/55282/files
bed8ff9 build(docs-infra): fix version mismatch of local built packages devversion Apr 10, 2024 https://github.com/angular/angular/pull/55282/commits/bed8ff97fce3374e22585b7b57bd3643faae60e7
ca399ef build(docs-infra): disable caching of adev inside bazel devversion Apr 10, 2024 https://github.com/angular/angular/pull/55282/commits/ca399ef819f1d5521628e29ec722c845dccf2386
72b8373 build: do not clear stdout of architect-cli when building adev devversion Apr 10, 2024 https://github.com/angular/angular/pull/55282/commits/72b8373d181d7529c511c67061896048e9d2e20a
Clear filters https://github.com/angular/angular/pull/55282/files
Please reload this pagehttps://github.com/angular/angular/pull/55282/files
Please reload this pagehttps://github.com/angular/angular/pull/55282/files
.pullapprove.yml https://github.com/angular/angular/pull/55282/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
BUILD.bazel https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
angular.json https://github.com/angular/angular/pull/55282/files#diff-8a55096653cc52bea7f3217908291c978b22648138d23ef81a49f7721ab06438
BUILD.bazel https://github.com/angular/angular/pull/55282/files#diff-02d115b98fad81676405172a25133a344c791ab0c228f6683f557bb8e1c9f848
filter_external_npm_deps.bzl https://github.com/angular/angular/pull/55282/files#diff-db4184976e41fc499f50b430a2e255b96995b66e394de5f8ebf22d5231076e1d
index.bzl https://github.com/angular/angular/pull/55282/files#diff-d32141fa8e0d9299f2a9b65ba50fb54863d12e339170e92088fe1e2beac42b61
packages.bzl https://github.com/angular/angular/pull/55282/files#diff-5ef0ea9ea291d74d4ad4ad321d0aea5488a66ea0560aff9eb210911b6809bbe2
@angular-devkit+architect-cli+0.1703.3.patch https://github.com/angular/angular/pull/55282/files#diff-791070d15cafb14f18e850bfb972b5297afeb67581c33dfc9f0403b58126803a
.pullapprove.ymlhttps://github.com/angular/angular/pull/55282/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
View file https://github.com/devversion/angular/blob/72b8373d181d7529c511c67061896048e9d2e20a/.pullapprove.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55282/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55282/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
https://github.com/angular/angular/pull/55282/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
adev/BUILD.bazelhttps://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
View file https://github.com/devversion/angular/blob/72b8373d181d7529c511c67061896048e9d2e20a/adev/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55282/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
https://github.com/angular/angular/pull/55282/files#diff-d19c4c6508a9a558d9a765cfa9b456c47aa3dc94244f65ed144f711116dd9e68
adev/angular.jsonhttps://github.com/angular/angular/pull/55282/files#diff-8a55096653cc52bea7f3217908291c978b22648138d23ef81a49f7721ab06438
View file https://github.com/devversion/angular/blob/72b8373d181d7529c511c67061896048e9d2e20a/adev/angular.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55282/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55282/files#diff-8a55096653cc52bea7f3217908291c978b22648138d23ef81a49f7721ab06438
https://github.com/angular/angular/pull/55282/files#diff-8a55096653cc52bea7f3217908291c978b22648138d23ef81a49f7721ab06438
https://github.com/angular/angular/pull/55282/files#diff-8a55096653cc52bea7f3217908291c978b22648138d23ef81a49f7721ab06438
adev/tools/local_deps/BUILD.bazelhttps://github.com/angular/angular/pull/55282/files#diff-02d115b98fad81676405172a25133a344c791ab0c228f6683f557bb8e1c9f848
View file https://github.com/devversion/angular/blob/72b8373d181d7529c511c67061896048e9d2e20a/adev/tools/local_deps/BUILD.bazel
Open in desktop https://desktop.github.com
adev/tools/local_deps/filter_external_npm_deps.bzlhttps://github.com/angular/angular/pull/55282/files#diff-db4184976e41fc499f50b430a2e255b96995b66e394de5f8ebf22d5231076e1d
View file https://github.com/devversion/angular/blob/72b8373d181d7529c511c67061896048e9d2e20a/adev/tools/local_deps/filter_external_npm_deps.bzl
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55282/{{ revealButtonHref }}
adev/tools/local_deps/index.bzlhttps://github.com/angular/angular/pull/55282/files#diff-d32141fa8e0d9299f2a9b65ba50fb54863d12e339170e92088fe1e2beac42b61
View file https://github.com/devversion/angular/blob/72b8373d181d7529c511c67061896048e9d2e20a/adev/tools/local_deps/index.bzl
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55282/{{ revealButtonHref }}
packages.bzlhttps://github.com/angular/angular/pull/55282/files#diff-5ef0ea9ea291d74d4ad4ad321d0aea5488a66ea0560aff9eb210911b6809bbe2
View file https://github.com/devversion/angular/blob/72b8373d181d7529c511c67061896048e9d2e20a/packages.bzl
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55282/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55282/files#diff-5ef0ea9ea291d74d4ad4ad321d0aea5488a66ea0560aff9eb210911b6809bbe2
https://github.com/angular/angular/pull/55282/files#diff-5ef0ea9ea291d74d4ad4ad321d0aea5488a66ea0560aff9eb210911b6809bbe2
https://github.com/angular/angular/pull/55282/files#diff-5ef0ea9ea291d74d4ad4ad321d0aea5488a66ea0560aff9eb210911b6809bbe2
tools/npm-patches/@angular-devkit+architect-cli+0.1703.3.patchhttps://github.com/angular/angular/pull/55282/files#diff-791070d15cafb14f18e850bfb972b5297afeb67581c33dfc9f0403b58126803a
View file https://github.com/devversion/angular/blob/72b8373d181d7529c511c67061896048e9d2e20a/tools/npm-patches/%40angular-devkit%2Barchitect-cli%2B0.1703.3.patch
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55282/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.