René's URL Explorer Experiment


Title: feat(language-service): Try to get the module specifier from the path… by ivanwonder · Pull Request #55139 · angular/angular · GitHub

Open Graph Title: feat(language-service): Try to get the module specifier from the path… by ivanwonder · Pull Request #55139 · angular/angular

X Title: feat(language-service): Try to get the module specifier from the path… by ivanwonder · Pull Request #55139 · angular/angular

Description: …s in the tsconfig when generating the import statement This algorithm is copied from the typescript and only picks the part of it. The assumption here is that the component/directive imported is located in the ts files. For example: src/bar.component.ts <- [src/bar.component, src/bar.component.ts] <- "@app/*": ["./src/*.ts"] <- (none)||@app/bar.component PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: …s in the tsconfig when generating the import statement This algorithm is copied from the typescript and only picks the part of it. The assumption here is that the component/directive imported is l...

X Description: …s in the tsconfig when generating the import statement This algorithm is copied from the typescript and only picks the part of it. The assumption here is that the component/directive imported is l...

Opengraph URL: https://github.com/angular/angular/pull/55139

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:15822c4b-2b49-2a7d-5be8-b452dc0d7a51
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAFA:37820D:E34A1A:12FA71C:6B00F6E3
html-safe-nonce693f75eed5c696a4f2a756196c0baa1499e0ad0c1a4282660bc82b6fbb1fb1e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUZBOjM3ODIwRDpFMzRBMUE6MTJGQTcxQzo2QjAwRjZFMyIsInZpc2l0b3JfaWQiOiI4MzA4NzQ5MTcwODk0NzYzNzQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf86ae616feac03fcef50b89f9edf70f1a9c52bd89cd1a92a7adf1e04a8bdf2e5
hovercard-subject-tagpull_request:1799300543
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/55139/files
twitter:imagehttps://avatars.githubusercontent.com/u/15815660?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15815660?s=400&v=4
og:image:alt…s in the tsconfig when generating the import statement This algorithm is copied from the typescript and only picks the part of it. The assumption here is that the component/directive imported is l...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/55139/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F55139%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F55139%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/55139/files
Reloadhttps://github.com/angular/angular/pull/55139/files
Reloadhttps://github.com/angular/angular/pull/55139/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ivanwonderhttps://github.com/ivanwonder
angular:mainhttps://github.com/angular/angular/tree/main
ivanwonder:import-module-specifier-from-path-in-the-tsconfighttps://github.com/ivanwonder/angular/tree/import-module-specifier-from-path-in-the-tsconfig
Conversation 12 https://github.com/angular/angular/pull/55139
Commits 1 https://github.com/angular/angular/pull/55139/commits
Checks 0 https://github.com/angular/angular/pull/55139/checks
Files changed https://github.com/angular/angular/pull/55139/files
Please reload this pagehttps://github.com/angular/angular/pull/55139/files
feat(language-service): Try to get the module specifier from the path… https://github.com/angular/angular/pull/55139/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/55139/files
b877fc0 feat(language-service): Try to get the module specifier from the path… ivanwonder Mar 25, 2024 https://github.com/angular/angular/pull/55139/commits/b877fc0ef3cbfb3ba617a55e962e6d67bef4db38
Clear filters https://github.com/angular/angular/pull/55139/files
Please reload this pagehttps://github.com/angular/angular/pull/55139/files
Please reload this pagehttps://github.com/angular/angular/pull/55139/files
code_fixes.ts https://github.com/angular/angular/pull/55139/files#diff-c92a1e69e5b0deaf7e7cfa84e9eafe6572825d019950b653ab8b91921c27866e
fix_missing_import.ts https://github.com/angular/angular/pull/55139/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
utils.ts https://github.com/angular/angular/pull/55139/files#diff-110089991f4edb118dc18cc4cc6747031fa6316854034622802bf84f5e0d7833
completions.ts https://github.com/angular/angular/pull/55139/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
language_service.ts https://github.com/angular/angular/pull/55139/files#diff-612cc2e10a72c69cbd24ffce20d68d90d8826ea879978f9ef24471265491384a
BUILD.bazel https://github.com/angular/angular/pull/55139/files#diff-40fdbf1a979581d8fce35d96f44685c83a8c93611db074705b8ea5a16b8ca153
module_specifiers.ts https://github.com/angular/angular/pull/55139/files#diff-8b148ca1664083366899f88ea3a26cf638998615ee851dce61973ef74dca294d
ts_utils.ts https://github.com/angular/angular/pull/55139/files#diff-d302d04c7bbda793b624adc58bd17c57b7cafa33c59e25e104a1fd1efaa14ab3
code_fixes_spec.ts https://github.com/angular/angular/pull/55139/files#diff-7ab64bd746252eaf87b95882ead1cf3801df59300221c6268eec87e342a386bf
env.ts https://github.com/angular/angular/pull/55139/files#diff-07202a1f21f85dd3baca8ad4bacd55e6b2456afe5482d8d9b00f90811221ede2
project.ts https://github.com/angular/angular/pull/55139/files#diff-3529cfa529a6ddd61724c87d9269c139c1235294d857d2e12b0577a4a164a068
util.ts https://github.com/angular/angular/pull/55139/files#diff-de3176a37931e86177fa1b7ad1a7c868ee831a4a3651f23f4e5dc112e05fbc11
packages/language-service/src/codefixes/code_fixes.tshttps://github.com/angular/angular/pull/55139/files#diff-c92a1e69e5b0deaf7e7cfa84e9eafe6572825d019950b653ab8b91921c27866e
View file https://github.com/ivanwonder/angular/blob/b877fc0ef3cbfb3ba617a55e962e6d67bef4db38/packages/language-service/src/codefixes/code_fixes.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55139/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55139/files#diff-c92a1e69e5b0deaf7e7cfa84e9eafe6572825d019950b653ab8b91921c27866e
https://github.com/angular/angular/pull/55139/files#diff-c92a1e69e5b0deaf7e7cfa84e9eafe6572825d019950b653ab8b91921c27866e
https://github.com/angular/angular/pull/55139/files#diff-c92a1e69e5b0deaf7e7cfa84e9eafe6572825d019950b653ab8b91921c27866e
https://github.com/angular/angular/pull/55139/files#diff-c92a1e69e5b0deaf7e7cfa84e9eafe6572825d019950b653ab8b91921c27866e
https://github.com/angular/angular/pull/55139/files#diff-c92a1e69e5b0deaf7e7cfa84e9eafe6572825d019950b653ab8b91921c27866e
packages/language-service/src/codefixes/fix_missing_import.tshttps://github.com/angular/angular/pull/55139/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
View file https://github.com/ivanwonder/angular/blob/b877fc0ef3cbfb3ba617a55e962e6d67bef4db38/packages/language-service/src/codefixes/fix_missing_import.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55139/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55139/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
https://github.com/angular/angular/pull/55139/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
https://github.com/angular/angular/pull/55139/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
https://github.com/angular/angular/pull/55139/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
packages/language-service/src/codefixes/utils.tshttps://github.com/angular/angular/pull/55139/files#diff-110089991f4edb118dc18cc4cc6747031fa6316854034622802bf84f5e0d7833
View file https://github.com/ivanwonder/angular/blob/b877fc0ef3cbfb3ba617a55e962e6d67bef4db38/packages/language-service/src/codefixes/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55139/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55139/files#diff-110089991f4edb118dc18cc4cc6747031fa6316854034622802bf84f5e0d7833
https://github.com/angular/angular/pull/55139/files#diff-110089991f4edb118dc18cc4cc6747031fa6316854034622802bf84f5e0d7833
https://github.com/angular/angular/pull/55139/files#diff-110089991f4edb118dc18cc4cc6747031fa6316854034622802bf84f5e0d7833
packages/language-service/src/completions.tshttps://github.com/angular/angular/pull/55139/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
View file https://github.com/ivanwonder/angular/blob/b877fc0ef3cbfb3ba617a55e962e6d67bef4db38/packages/language-service/src/completions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55139/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55139/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
https://github.com/angular/angular/pull/55139/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
https://github.com/angular/angular/pull/55139/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
https://github.com/angular/angular/pull/55139/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
https://github.com/angular/angular/pull/55139/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
https://github.com/angular/angular/pull/55139/files#diff-0dbc44b3fef98374d5d3e635e1173221fda1169d422fd3761ae4cd06b063e126
packages/language-service/src/language_service.tshttps://github.com/angular/angular/pull/55139/files#diff-612cc2e10a72c69cbd24ffce20d68d90d8826ea879978f9ef24471265491384a
View file https://github.com/ivanwonder/angular/blob/b877fc0ef3cbfb3ba617a55e962e6d67bef4db38/packages/language-service/src/language_service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55139/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55139/files#diff-612cc2e10a72c69cbd24ffce20d68d90d8826ea879978f9ef24471265491384a
https://github.com/angular/angular/pull/55139/files#diff-612cc2e10a72c69cbd24ffce20d68d90d8826ea879978f9ef24471265491384a
https://github.com/angular/angular/pull/55139/files#diff-612cc2e10a72c69cbd24ffce20d68d90d8826ea879978f9ef24471265491384a
https://github.com/angular/angular/pull/55139/files#diff-612cc2e10a72c69cbd24ffce20d68d90d8826ea879978f9ef24471265491384a
https://github.com/angular/angular/pull/55139/files#diff-612cc2e10a72c69cbd24ffce20d68d90d8826ea879978f9ef24471265491384a
https://github.com/angular/angular/pull/55139/files#diff-612cc2e10a72c69cbd24ffce20d68d90d8826ea879978f9ef24471265491384a
packages/language-service/src/utils/BUILD.bazelhttps://github.com/angular/angular/pull/55139/files#diff-40fdbf1a979581d8fce35d96f44685c83a8c93611db074705b8ea5a16b8ca153
View file https://github.com/ivanwonder/angular/blob/b877fc0ef3cbfb3ba617a55e962e6d67bef4db38/packages/language-service/src/utils/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55139/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55139/files#diff-40fdbf1a979581d8fce35d96f44685c83a8c93611db074705b8ea5a16b8ca153
packages/language-service/src/utils/module_specifiers.tshttps://github.com/angular/angular/pull/55139/files#diff-8b148ca1664083366899f88ea3a26cf638998615ee851dce61973ef74dca294d
View file https://github.com/ivanwonder/angular/blob/b877fc0ef3cbfb3ba617a55e962e6d67bef4db38/packages/language-service/src/utils/module_specifiers.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55139/{{ revealButtonHref }}
clydinhttps://github.com/clydin
Apr 15, 2025https://github.com/angular/angular/pull/55139/files#r2044540173
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/55139/files
ivanwonderhttps://github.com/ivanwonder
Apr 16, 2025https://github.com/angular/angular/pull/55139/files#r2046897564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/55139/files
ivanwonderhttps://github.com/ivanwonder
Apr 16, 2025https://github.com/angular/angular/pull/55139/files#r2046911447
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/microsoft/TypeScript/blob/1efdcd9ff7d6566cf9bf10975b6fc8ffb0b53c9b/src/services/exportInfoMap.ts#L259https://github.com/microsoft/TypeScript/blob/1efdcd9ff7d6566cf9bf10975b6fc8ffb0b53c9b/src/services/exportInfoMap.ts#L259
Please reload this pagehttps://github.com/angular/angular/pull/55139/files
ivanwonderhttps://github.com/ivanwonder
May 5, 2025https://github.com/angular/angular/pull/55139/files#r2073363803
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#61122https://github.com/angular/angular/pull/61122
Please reload this pagehttps://github.com/angular/angular/pull/55139/files
clydinhttps://github.com/clydin
Apr 15, 2025https://github.com/angular/angular/pull/55139/files#r2044542656
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/55139/files
ivanwonderhttps://github.com/ivanwonder
Apr 16, 2025https://github.com/angular/angular/pull/55139/files#r2046901198
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/55139/files
packages/language-service/src/utils/ts_utils.tshttps://github.com/angular/angular/pull/55139/files#diff-d302d04c7bbda793b624adc58bd17c57b7cafa33c59e25e104a1fd1efaa14ab3
View file https://github.com/ivanwonder/angular/blob/b877fc0ef3cbfb3ba617a55e962e6d67bef4db38/packages/language-service/src/utils/ts_utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/55139/{{ revealButtonHref }}
https://github.com/angular/angular/pull/55139/files#diff-d302d04c7bbda793b624adc58bd17c57b7cafa33c59e25e104a1fd1efaa14ab3
https://github.com/angular/angular/pull/55139/files#diff-d302d04c7bbda793b624adc58bd17c57b7cafa33c59e25e104a1fd1efaa14ab3
https://github.com/angular/angular/pull/55139/files#diff-d302d04c7bbda793b624adc58bd17c57b7cafa33c59e25e104a1fd1efaa14ab3
https://github.com/angular/angular/pull/55139/files#diff-d302d04c7bbda793b624adc58bd17c57b7cafa33c59e25e104a1fd1efaa14ab3
https://github.com/angular/angular/pull/55139/files#diff-d302d04c7bbda793b624adc58bd17c57b7cafa33c59e25e104a1fd1efaa14ab3
https://github.com/angular/angular/pull/55139/files#diff-d302d04c7bbda793b624adc58bd17c57b7cafa33c59e25e104a1fd1efaa14ab3
https://github.com/angular/angular/pull/55139/files#diff-d302d04c7bbda793b624adc58bd17c57b7cafa33c59e25e104a1fd1efaa14ab3
Please reload this pagehttps://github.com/angular/angular/pull/55139/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.