René's URL Explorer Experiment


Title: chore(build): fix flakiness of the element probe global test by marclaval · Pull Request #5493 · angular/angular · GitHub

Open Graph Title: chore(build): fix flakiness of the element probe global test by marclaval · Pull Request #5493 · angular/angular

X Title: chore(build): fix flakiness of the element probe global test by marclaval · Pull Request #5493 · angular/angular

Description: 2 bugs here: the tools pollutes the global environment with an undefined ng property setValueOnPath() fails if there is an undefined or null property existing in the path. It is used to set the DebugElement getter on window.ng.probe. With the 2 combined, the test element probe should provide a global function to inspect elements fails if it is executed after the tools' tests, which happens from time to time, hence the flake.

Open Graph Description: 2 bugs here: the tools pollutes the global environment with an undefined ng property setValueOnPath() fails if there is an undefined or null property existing in the path. It is used to set the De...

X Description: 2 bugs here: the tools pollutes the global environment with an undefined ng property setValueOnPath() fails if there is an undefined or null property existing in the path. It is used to set the De...

Opengraph URL: https://github.com/angular/angular/pull/5493

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:83202179-2678-22f0-8f17-e62bbd1754ef
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8210:2E124E:2191EFF:2AD6AC5:6B017F65
html-safe-nonce8ad90ea7630f14eb14d7a01e361168321e30a8b20fd996993af9379d888fd1d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjEwOjJFMTI0RToyMTkxRUZGOjJBRDZBQzU6NkIwMTdGNjUiLCJ2aXNpdG9yX2lkIjoiNjk4MTAyMzAzNDIxMTY2MzcxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac35239cd09a6c9e2c7e5b40dfc2d4dbc959b78a5afa558eb78c5cf31884593c0a
hovercard-subject-tagpull_request:51945590
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/5493/files
twitter:imagehttps://avatars.githubusercontent.com/u/2316643?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2316643?s=400&v=4
og:image:alt2 bugs here: the tools pollutes the global environment with an undefined ng property setValueOnPath() fails if there is an undefined or null property existing in the path. It is used to set the De...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/5493/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F5493%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F5493%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/5493/files
Reloadhttps://github.com/angular/angular/pull/5493/files
Reloadhttps://github.com/angular/angular/pull/5493/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
marclavalhttps://github.com/marclaval
angular:masterhttps://github.com/angular/angular/tree/master
marclaval:fixProbeFlakehttps://github.com/marclaval/angular/tree/fixProbeFlake
Conversation 2 https://github.com/angular/angular/pull/5493
Commits 1 https://github.com/angular/angular/pull/5493/commits
Checks 0 https://github.com/angular/angular/pull/5493/checks
Files changed https://github.com/angular/angular/pull/5493/files
Please reload this pagehttps://github.com/angular/angular/pull/5493/files
chore(build): fix flakiness of the element probe global test https://github.com/angular/angular/pull/5493/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/5493/files
66aa892 chore(build): fix flakiness of the element probe global test marclaval Nov 26, 2015 https://github.com/angular/angular/pull/5493/commits/66aa892f1e67153f8c3a4ac490f7c6f0d350053b
Clear filters https://github.com/angular/angular/pull/5493/files
Please reload this pagehttps://github.com/angular/angular/pull/5493/files
Please reload this pagehttps://github.com/angular/angular/pull/5493/files
lang.ts https://github.com/angular/angular/pull/5493/files#diff-a1c50c27fe88c7903f8690052fb77aa378e7f4251e1dbc6ea29e2b7fea766458
tools.ts https://github.com/angular/angular/pull/5493/files#diff-1785e305c9bedb741e4055e2ed2467fe01eb6af72d74c04b6d5d2e0d8ba92719
debug_element_view_listener.ts https://github.com/angular/angular/pull/5493/files#diff-5237d8d34b0d6f755242326606f04db9f7c8bad8bcc1a4e3bbd7f3ebb4fed508
debug_element_view_listener_spec.ts https://github.com/angular/angular/pull/5493/files#diff-252d235341842cf8eae5c9928a73f4a5bf9967ae0dac4e90e29928ffa650933e
modules/angular2/src/facade/lang.tshttps://github.com/angular/angular/pull/5493/files#diff-a1c50c27fe88c7903f8690052fb77aa378e7f4251e1dbc6ea29e2b7fea766458
View file https://github.com/marclaval/angular/blob/66aa892f1e67153f8c3a4ac490f7c6f0d350053b/modules/angular2/src/facade/lang.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5493/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5493/files#diff-a1c50c27fe88c7903f8690052fb77aa378e7f4251e1dbc6ea29e2b7fea766458
https://github.com/angular/angular/pull/5493/files#diff-a1c50c27fe88c7903f8690052fb77aa378e7f4251e1dbc6ea29e2b7fea766458
modules/angular2/src/platform/browser/tools/tools.tshttps://github.com/angular/angular/pull/5493/files#diff-1785e305c9bedb741e4055e2ed2467fe01eb6af72d74c04b6d5d2e0d8ba92719
View file https://github.com/marclaval/angular/blob/66aa892f1e67153f8c3a4ac490f7c6f0d350053b/modules/angular2/src/platform/browser/tools/tools.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5493/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5493/files#diff-1785e305c9bedb741e4055e2ed2467fe01eb6af72d74c04b6d5d2e0d8ba92719
modules/angular2/src/platform/dom/debug/debug_element_view_listener.tshttps://github.com/angular/angular/pull/5493/files#diff-5237d8d34b0d6f755242326606f04db9f7c8bad8bcc1a4e3bbd7f3ebb4fed508
View file https://github.com/marclaval/angular/blob/66aa892f1e67153f8c3a4ac490f7c6f0d350053b/modules/angular2/src/platform/dom/debug/debug_element_view_listener.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5493/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5493/files#diff-5237d8d34b0d6f755242326606f04db9f7c8bad8bcc1a4e3bbd7f3ebb4fed508
modules/angular2/test/platform/browser/debug/debug_element_view_listener_spec.tshttps://github.com/angular/angular/pull/5493/files#diff-252d235341842cf8eae5c9928a73f4a5bf9967ae0dac4e90e29928ffa650933e
View file https://github.com/marclaval/angular/blob/66aa892f1e67153f8c3a4ac490f7c6f0d350053b/modules/angular2/test/platform/browser/debug/debug_element_view_listener_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/5493/{{ revealButtonHref }}
https://github.com/angular/angular/pull/5493/files#diff-252d235341842cf8eae5c9928a73f4a5bf9967ae0dac4e90e29928ffa650933e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.