René's URL Explorer Experiment


Title: feat(router): Add reusable types for router guards by atscott · Pull Request #54580 · angular/angular · GitHub

Open Graph Title: feat(router): Add reusable types for router guards by atscott · Pull Request #54580 · angular/angular

X Title: feat(router): Add reusable types for router guards by atscott · Pull Request #54580 · angular/angular

Description: This refactor makes it easier to update the return types of guards. Rather than having to track what types guards can return, which may change with new features over time, MaybeAsync can be used instead. Reviewer note: This is a separate feat commit from #45023. Doing this in a commit ahead of time makes it possible to adjust internal code ahead of the breaking change that adds a type to the GuardResult. This means code can be made forward-compatible first and #45023 can be merged without needing to include updates to internal code at the same time the sync happens.

Open Graph Description: This refactor makes it easier to update the return types of guards. Rather than having to track what types guards can return, which may change with new features over time, MaybeAsync<GuardResult...

X Description: This refactor makes it easier to update the return types of guards. Rather than having to track what types guards can return, which may change with new features over time, MaybeAsync&lt;GuardRe...

Opengraph URL: https://github.com/angular/angular/pull/54580

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eab803e7-a697-3246-62a7-34ae91d5c180
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B36:7A60E:EAE44E:12F5C78:6B00FDB5
html-safe-nonce7a248a1263b8b1bb7659ec3cd0d2566132bc267d309dc04ac236e9523e1e6dc0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjM2OjdBNjBFOkVBRTQ0RToxMkY1Qzc4OjZCMDBGREI1IiwidmlzaXRvcl9pZCI6IjU4MzI1NDE5Mjg3ODgzOTMzOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd6ef8e98d8cbee767ccaaa794bb89cfbf5bbbbbad8254090813a6c646e070be4
hovercard-subject-tagpull_request:1739653119
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/54580/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altThis refactor makes it easier to update the return types of guards. Rather than having to track what types guards can return, which may change with new features over time, MaybeAsync<GuardResult...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/54580/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54580%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54580%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/54580/files
Reloadhttps://github.com/angular/angular/pull/54580/files
Reloadhttps://github.com/angular/angular/pull/54580/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:guardReturnTypeshttps://github.com/atscott/angular/tree/guardReturnTypes
Conversation 6 https://github.com/angular/angular/pull/54580
Commits 1 https://github.com/angular/angular/pull/54580/commits
Checks 0 https://github.com/angular/angular/pull/54580/checks
Files changed https://github.com/angular/angular/pull/54580/files
Please reload this pagehttps://github.com/angular/angular/pull/54580/files
feat(router): Add reusable types for router guards https://github.com/angular/angular/pull/54580/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/54580/files
5465d36 feat(router): Add reusable types for router guards atscott Oct 18, 2021 https://github.com/angular/angular/pull/54580/commits/5465d36efb73ae314be370670547989341cd1807
Clear filters https://github.com/angular/angular/pull/54580/files
Please reload this pagehttps://github.com/angular/angular/pull/54580/files
Please reload this pagehttps://github.com/angular/angular/pull/54580/files
index.md https://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
index.ts https://github.com/angular/angular/pull/54580/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
models.ts https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
check_guards.ts https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
prioritized_guard_value.ts https://github.com/angular/angular/pull/54580/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf
goldens/public-api/router/index.mdhttps://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
View file https://github.com/atscott/angular/blob/5465d36efb73ae314be370670547989341cd1807/goldens/public-api/router/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54580/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/54580/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
packages/router/src/index.tshttps://github.com/angular/angular/pull/54580/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
View file https://github.com/atscott/angular/blob/5465d36efb73ae314be370670547989341cd1807/packages/router/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54580/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54580/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
https://github.com/angular/angular/pull/54580/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
packages/router/src/models.tshttps://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
View file https://github.com/atscott/angular/blob/5465d36efb73ae314be370670547989341cd1807/packages/router/src/models.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54580/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
https://github.com/angular/angular/pull/54580/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
packages/router/src/operators/check_guards.tshttps://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
View file https://github.com/atscott/angular/blob/5465d36efb73ae314be370670547989341cd1807/packages/router/src/operators/check_guards.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54580/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/54580/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
packages/router/src/operators/prioritized_guard_value.tshttps://github.com/angular/angular/pull/54580/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf
View file https://github.com/atscott/angular/blob/5465d36efb73ae314be370670547989341cd1807/packages/router/src/operators/prioritized_guard_value.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54580/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54580/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf
https://github.com/angular/angular/pull/54580/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf
https://github.com/angular/angular/pull/54580/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.