René's URL Explorer Experiment


Title: fix(core): do not crash for signal query that does not have any matches by JoostK · Pull Request #54353 · angular/angular · GitHub

Open Graph Title: fix(core): do not crash for signal query that does not have any matches by JoostK · Pull Request #54353 · angular/angular

X Title: fix(core): do not crash for signal query that does not have any matches by JoostK · Pull Request #54353 · angular/angular

Description: The newly introduced signal queries would error if no match exists, due to an invalid read within the query internals. This commit addresses the crash by allowing there to be no matches.

Open Graph Description: The newly introduced signal queries would error if no match exists, due to an invalid read within the query internals. This commit addresses the crash by allowing there to be no matches.

X Description: The newly introduced signal queries would error if no match exists, due to an invalid read within the query internals. This commit addresses the crash by allowing there to be no matches.

Opengraph URL: https://github.com/angular/angular/pull/54353

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f8ca29b5-21aa-96d0-2f23-3526d7c8215b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE8B8:2BE220:BF0A68:1008AE8:6B00F8D5
html-safe-nonce1f4ff936adb9dd49dce935b9b3676f21189e22d28ab491d1f7bdf8d2407c65f7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEI4OjJCRTIyMDpCRjBBNjg6MTAwOEFFODo2QjAwRjhENSIsInZpc2l0b3JfaWQiOiI1ODcxMzE0ODEwNDc3NTQxNTg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc315451289579722c71208676d2fef694c67a4c839e2884fcbd8f1870f0e723c
hovercard-subject-tagpull_request:1718383302
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/54353/files
twitter:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
og:image:altThe newly introduced signal queries would error if no match exists, due to an invalid read within the query internals. This commit addresses the crash by allowing there to be no matches.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/54353/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54353%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54353%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/54353/files
Reloadhttps://github.com/angular/angular/pull/54353/files
Reloadhttps://github.com/angular/angular/pull/54353/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JoostKhttps://github.com/JoostK
angular:mainhttps://github.com/angular/angular/tree/main
JoostK:core/signal-queries-emptyhttps://github.com/JoostK/angular/tree/core/signal-queries-empty
Conversation 6 https://github.com/angular/angular/pull/54353
Commits 1 https://github.com/angular/angular/pull/54353/commits
Checks 0 https://github.com/angular/angular/pull/54353/checks
Files changed https://github.com/angular/angular/pull/54353/files
Please reload this pagehttps://github.com/angular/angular/pull/54353/files
fix(core): do not crash for signal query that does not have any matches https://github.com/angular/angular/pull/54353/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/54353/files
a6eff00 fix(core): do not crash for signal query that does not have any matches JoostK Feb 8, 2024 https://github.com/angular/angular/pull/54353/commits/a6eff00a01a7a5c0a3989b8d43834bf67959beaf
Clear filters https://github.com/angular/angular/pull/54353/files
Please reload this pagehttps://github.com/angular/angular/pull/54353/files
Please reload this pagehttps://github.com/angular/angular/pull/54353/files
query.ts https://github.com/angular/angular/pull/54353/files#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff
signal_queries_spec.ts https://github.com/angular/angular/pull/54353/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
packages/core/src/render3/query.tshttps://github.com/angular/angular/pull/54353/files#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff
View file https://github.com/JoostK/angular/blob/a6eff00a01a7a5c0a3989b8d43834bf67959beaf/packages/core/src/render3/query.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54353/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54353/files#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Feb 8, 2024https://github.com/angular/angular/pull/54353/files#r1483610370
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/54353/files
JoostKhttps://github.com/JoostK
Feb 8, 2024https://github.com/angular/angular/pull/54353/files#r1483614135
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/54353/files
https://github.com/angular/angular/pull/54353/files#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff
packages/core/test/acceptance/authoring/signal_queries_spec.tshttps://github.com/angular/angular/pull/54353/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
View file https://github.com/JoostK/angular/blob/a6eff00a01a7a5c0a3989b8d43834bf67959beaf/packages/core/test/acceptance/authoring/signal_queries_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54353/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54353/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
https://github.com/angular/angular/pull/54353/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
https://github.com/angular/angular/pull/54353/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.