| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f8ca29b5-21aa-96d0-2f23-3526d7c8215b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E8B8:2BE220:BF0A68:1008AE8:6B00F8D5 |
| html-safe-nonce | 1f4ff936adb9dd49dce935b9b3676f21189e22d28ab491d1f7bdf8d2407c65f7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEI4OjJCRTIyMDpCRjBBNjg6MTAwOEFFODo2QjAwRjhENSIsInZpc2l0b3JfaWQiOiI1ODcxMzE0ODEwNDc3NTQxNTg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c315451289579722c71208676d2fef694c67a4c839e2884fcbd8f1870f0e723c |
| hovercard-subject-tag | pull_request:1718383302 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/54353/files |
| twitter:image | https://avatars.githubusercontent.com/u/123679?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/123679?s=400&v=4 |
| og:image:alt | The newly introduced signal queries would error if no match exists, due to an invalid read within the query internals.
This commit addresses the crash by allowing there to be no matches. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/54353/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54353%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54353%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/54353/files |
| Reload | https://github.com/angular/angular/pull/54353/files |
| Reload | https://github.com/angular/angular/pull/54353/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| JoostK | https://github.com/JoostK |
| angular:main | https://github.com/angular/angular/tree/main |
| JoostK:core/signal-queries-empty | https://github.com/JoostK/angular/tree/core/signal-queries-empty |
|
Conversation
6
| https://github.com/angular/angular/pull/54353 |
|
Commits
1
| https://github.com/angular/angular/pull/54353/commits |
|
Checks
0
| https://github.com/angular/angular/pull/54353/checks |
|
Files changed
| https://github.com/angular/angular/pull/54353/files |
| Please reload this page | https://github.com/angular/angular/pull/54353/files |
|
fix(core): do not crash for signal query that does not have any matches
| https://github.com/angular/angular/pull/54353/files#top |
|
Show all changes
1 commit
| https://github.com/angular/angular/pull/54353/files |
|
a6eff00
fix(core): do not crash for signal query that does not have any matches
JoostK Feb 8, 2024
| https://github.com/angular/angular/pull/54353/commits/a6eff00a01a7a5c0a3989b8d43834bf67959beaf |
|
Clear filters
| https://github.com/angular/angular/pull/54353/files |
| Please reload this page | https://github.com/angular/angular/pull/54353/files |
| Please reload this page | https://github.com/angular/angular/pull/54353/files |
|
query.ts
| https://github.com/angular/angular/pull/54353/files#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff |
|
signal_queries_spec.ts
| https://github.com/angular/angular/pull/54353/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40 |
| packages/core/src/render3/query.ts | https://github.com/angular/angular/pull/54353/files#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff |
|
View file
| https://github.com/JoostK/angular/blob/a6eff00a01a7a5c0a3989b8d43834bf67959beaf/packages/core/src/render3/query.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/54353/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/54353/files#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| Feb 8, 2024 | https://github.com/angular/angular/pull/54353/files#r1483610370 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/54353/files |
| JoostK | https://github.com/JoostK |
| Feb 8, 2024 | https://github.com/angular/angular/pull/54353/files#r1483614135 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/54353/files |
|
| https://github.com/angular/angular/pull/54353/files#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff |
| packages/core/test/acceptance/authoring/signal_queries_spec.ts | https://github.com/angular/angular/pull/54353/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40 |
|
View file
| https://github.com/JoostK/angular/blob/a6eff00a01a7a5c0a3989b8d43834bf67959beaf/packages/core/test/acceptance/authoring/signal_queries_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/54353/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/54353/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40 |
|
| https://github.com/angular/angular/pull/54353/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40 |
|
| https://github.com/angular/angular/pull/54353/files#diff-bee8e0a18c1aa2f111d1a951a65a9eb35b02a2780854cdae3daaf1ec42fc8b40 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |