René's URL Explorer Experiment


Title: fix(core): do not crash for signal query that does not have any matches by JoostK · Pull Request #54353 · angular/angular · GitHub

Open Graph Title: fix(core): do not crash for signal query that does not have any matches by JoostK · Pull Request #54353 · angular/angular

X Title: fix(core): do not crash for signal query that does not have any matches by JoostK · Pull Request #54353 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: The newly introduced signal queries would error if no match exists, due to an invalid read within the query internals. This commit addresses the crash by allowing there to be no matches.

X Description: The newly introduced signal queries would error if no match exists, due to an invalid read within the query internals. This commit addresses the crash by allowing there to be no matches.

Opengraph URL: https://github.com/angular/angular/pull/54353

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2a18a326-a9aa-3707-ff47-f57d40751966
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED84:21E3E7:C4ACAD:104F062:6B00F439
html-safe-nonce2648bc52729c3e2a1884ed829e5c1f97fe0d4174f49fd9dd8f8959f9684f9b3f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDg0OjIxRTNFNzpDNEFDQUQ6MTA0RjA2Mjo2QjAwRjQzOSIsInZpc2l0b3JfaWQiOiI0Nzc2NTc5MTM0Nzk1MDg0ODU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2e5404fadb0804b032c6a54e0b4ff18cbf239c0f0ddd29df5597425bb95bc108
hovercard-subject-tagpull_request:1718383302
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/54353/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3bc9e0946b3edcd88936e471e62d5d5c594584611a1dc5b769bd2b4113d72fd8/angular/angular/pull/54353
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3bc9e0946b3edcd88936e471e62d5d5c594584611a1dc5b769bd2b4113d72fd8/angular/angular/pull/54353
og:image:altThe newly introduced signal queries would error if no match exists, due to an invalid read within the query internals. This commit addresses the crash by allowing there to be no matches.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJoostK
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/54353#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54353
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54353
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/54353
Reloadhttps://github.com/angular/angular/pull/54353
Reloadhttps://github.com/angular/angular/pull/54353
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
JoostKhttps://github.com/JoostK
angular:mainhttps://github.com/angular/angular/tree/main
JoostK:core/signal-queries-emptyhttps://github.com/JoostK/angular/tree/core/signal-queries-empty
Conversationhttps://github.com/angular/angular/pull/54353
Commits1 (1)https://github.com/angular/angular/pull/54353/commits
Checkshttps://github.com/angular/angular/pull/54353/checks
Files changedhttps://github.com/angular/angular/pull/54353/files
fix(core): do not crash for signal query that does not have any matcheshttps://github.com/angular/angular/pull/54353#top
JoostKhttps://github.com/JoostK
angular:mainhttps://github.com/angular/angular/tree/main
JoostK:core/signal-queries-emptyhttps://github.com/JoostK/angular/tree/core/signal-queries-empty
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Feb 8, 2024https://github.com/angular/angular/pull/54353#issue-2126049696
Please reload this pagehttps://github.com/angular/angular/pull/54353
https://github.com/JoostK
fix(core): do not crash for signal query that does not have any matcheshttps://github.com/angular/angular/pull/54353/commits/a6eff00a01a7a5c0a3989b8d43834bf67959beaf
a6eff00https://github.com/angular/angular/pull/54353/commits/a6eff00a01a7a5c0a3989b8d43834bf67959beaf
https://github.com/JoostK
JoostKhttps://github.com/JoostK
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: queries https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20queries%22
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
Feb 8, 2024https://github.com/angular/angular/pull/54353#event-11751143988
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Feb 8, 2024https://github.com/angular/angular/pull/54353#event-11751144281
https://github.com/JoostK
JoostKhttps://github.com/JoostK
February 8, 2024 21:16https://github.com/angular/angular/pull/54353#event-11751347674
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
jessicajaniukhttps://github.com/jessicajaniuk
February 8, 2024 21:16https://github.com/angular/angular/pull/54353#event-11751348813
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Feb 8, 2024 https://github.com/angular/angular/pull/54353#pullrequestreview-1871291208
View reviewed changes https://github.com/angular/angular/pull/54353/files/a6eff00a01a7a5c0a3989b8d43834bf67959beaf
packages/core/src/render3/query.tshttps://github.com/angular/angular/pull/54353/files/a6eff00a01a7a5c0a3989b8d43834bf67959beaf#diff-5c0bc312cf386ba447ca45011052b03c0ee2d75efef4c78a69aad917cb3a53ff
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Feb 8, 2024https://github.com/angular/angular/pull/54353#discussion_r1483610370
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/54353
JoostKhttps://github.com/JoostK
Feb 8, 2024https://github.com/angular/angular/pull/54353#discussion_r1483614135
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/54353
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Feb 8, 2024 https://github.com/angular/angular/pull/54353#pullrequestreview-1871293017
View reviewed changes https://github.com/angular/angular/pull/54353/files/a6eff00a01a7a5c0a3989b8d43834bf67959beaf
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
https://github.com/angular/angular/pull/54353#pullrequestreview-1871293017
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@JoostKhttps://github.com/JoostK
Please reload this pagehttps://github.com/angular/angular/pull/54353
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Feb 8, 2024https://github.com/angular/angular/pull/54353#event-11751459257
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
jessicajaniukhttps://github.com/jessicajaniuk
February 8, 2024 21:29https://github.com/angular/angular/pull/54353#event-11751463170
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
Feb 8, 2024https://github.com/angular/angular/pull/54353#event-11752056576
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Feb 8, 2024https://github.com/angular/angular/pull/54353#issuecomment-1935051553
Please reload this pagehttps://github.com/angular/angular/pull/54353
https://github.com/jessicajaniuk
jessicajaniukhttps://github.com/jessicajaniuk
abf6371https://github.com/angular/angular/commit/abf637165b8705b614546067c7f409dca08b2635
Feb 9, 2024https://github.com/angular/angular/pull/54353#event-11759060138
jessicajaniukhttps://github.com/jessicajaniuk
Feb 9, 2024 https://github.com/angular/angular/pull/54353#ref-commit-62b87b4
https://github.com/JoostK
https://github.com/thePunderWoman
fix(core): do not crash for signal query that does not have any match…https://github.com/angular/angular/commit/62b87b4551d77815f58af152d1921de3733621ba
62b87b4https://github.com/angular/angular/commit/62b87b4551d77815f58af152d1921de3733621ba
#54353https://github.com/angular/angular/pull/54353
#54353https://github.com/angular/angular/pull/54353
https://github.com/jessicajaniuk
jessicajaniukhttps://github.com/jessicajaniuk
Feb 9, 2024https://github.com/angular/angular/pull/54353#issuecomment-1936084043
abf6371https://github.com/angular/angular/commit/abf637165b8705b614546067c7f409dca08b2635
Please reload this pagehttps://github.com/angular/angular/pull/54353
atscotthttps://github.com/atscott
Feb 16, 2024 https://github.com/angular/angular/pull/54353#ref-commit-83b1e4b
https://github.com/JoostK
https://github.com/atscott
fix(core): do not crash for signal query that does not have any match…https://github.com/atscott/angular/commit/83b1e4be89568fa2efc042babd4c3aae461d85dd
83b1e4bhttps://github.com/atscott/angular/commit/83b1e4be89568fa2efc042babd4c3aae461d85dd
angular#54353https://github.com/angular/angular/pull/54353
angular#54353https://github.com/angular/angular/pull/54353
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 11, 2024https://github.com/angular/angular/pull/54353#issuecomment-1987424228
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/54353
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 11, 2024https://github.com/angular/angular/pull/54353#event-12066767543
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54353
https://github.com/pkozlowski-opensource
pkozlowski-opensource https://github.com/pkozlowski-opensource
https://github.com/angular/angular/pull/54353/files/a6eff00a01a7a5c0a3989b8d43834bf67959beaf
Please reload this pagehttps://github.com/angular/angular/pull/54353
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: queries https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20queries%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/54353
https://github.com/JoostK
https://github.com/pkozlowski-opensource
https://github.com/jessicajaniuk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.