René's URL Explorer Experiment


Title: fix(core): add toString implementation to signals by crisbeto · Pull Request #54002 · angular/angular · GitHub

Open Graph Title: fix(core): add toString implementation to signals by crisbeto · Pull Request #54002 · angular/angular

X Title: fix(core): add toString implementation to signals by crisbeto · Pull Request #54002 · angular/angular

Description: Since signals are functions, currently stringifying them reveals the implementation of the function. This can lead to confusion since it contains internal implementation details. These changes add static toString function to address the issue. Note: it's tempting to have toString output the actual value of the signal, but that would encourage users not to call the function which will be problematic in the long run. That's why these changes are using a static string instead.

Open Graph Description: Since signals are functions, currently stringifying them reveals the implementation of the function. This can lead to confusion since it contains internal implementation details. These changes add ...

X Description: Since signals are functions, currently stringifying them reveals the implementation of the function. This can lead to confusion since it contains internal implementation details. These changes add ...

Opengraph URL: https://github.com/angular/angular/pull/54002

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:29a7e539-ac89-2bf1-a2ed-d696f28779c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idACBA:2DBB21:BDA3E6:FE051E:6B00F8C1
html-safe-nonceb0cd3552ea45e106ee229bfd39b88b2985619811104cc353d2ee1cc6842e69cf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQ0JBOjJEQkIyMTpCREEzRTY6RkUwNTFFOjZCMDBGOEMxIiwidmlzaXRvcl9pZCI6IjU5OTgyNzQwODI0MDIwMDcyMzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfb30474446d74a9804761d133e347eef25e9fef6d496d983e9deb7f080b6f5b8
hovercard-subject-tagpull_request:1688139879
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/54002/files
twitter:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
og:image:altSince signals are functions, currently stringifying them reveals the implementation of the function. This can lead to confusion since it contains internal implementation details. These changes add ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/54002/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54002%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F54002%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/54002/files
Reloadhttps://github.com/angular/angular/pull/54002/files
Reloadhttps://github.com/angular/angular/pull/54002/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
crisbeto:signals-tostringhttps://github.com/crisbeto/angular/tree/signals-tostring
Conversation 13 https://github.com/angular/angular/pull/54002
Commits 1 https://github.com/angular/angular/pull/54002/commits
Checks 0 https://github.com/angular/angular/pull/54002/checks
Files changed https://github.com/angular/angular/pull/54002/files
Please reload this pagehttps://github.com/angular/angular/pull/54002/files
fix(core): add toString implementation to signals https://github.com/angular/angular/pull/54002/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/54002/files
1eeee66 fix(core): add toString implementation to signals crisbeto Jan 25, 2024 https://github.com/angular/angular/pull/54002/commits/1eeee66b2aabbc930f9b9f060b6951c8faeb7d13
Clear filters https://github.com/angular/angular/pull/54002/files
Please reload this pagehttps://github.com/angular/angular/pull/54002/files
Please reload this pagehttps://github.com/angular/angular/pull/54002/files
computed.ts https://github.com/angular/angular/pull/54002/files#diff-1a048dcd11e2a52dead82119d81fe85762b529813fdb26f36722066566232c1e
signal.ts https://github.com/angular/angular/pull/54002/files#diff-fb5965417e1486c695674f5447fa193df0a9f4f9dea5695e7d46d66b3d4b23a3
input_signal.ts https://github.com/angular/angular/pull/54002/files#diff-c4769a0b164d139e5feba351e6d1d66e82dfc57bd61ebf9d7664d49d9ff23cee
query_reactive.ts https://github.com/angular/angular/pull/54002/files#diff-d27060d0100f2ae0ec92550b253e94cbfc36e7680d6c084306d9940175127b6e
input_signal_spec.ts https://github.com/angular/angular/pull/54002/files#diff-693b813f843f45608e5b05dae53bf6bb1973e152c0e332f2654763a09d3fc65f
computed_spec.ts https://github.com/angular/angular/pull/54002/files#diff-416172464fb261e6408ff7b02bb7359aae8b2d823532f6cb48ecf479d49eee52
signal_spec.ts https://github.com/angular/angular/pull/54002/files#diff-fe733038b34f355940c724dbed0c5ab2e5453a754591f2924e42bdf4ee3c2424
packages/core/primitives/signals/src/computed.tshttps://github.com/angular/angular/pull/54002/files#diff-1a048dcd11e2a52dead82119d81fe85762b529813fdb26f36722066566232c1e
View file https://github.com/crisbeto/angular/blob/1eeee66b2aabbc930f9b9f060b6951c8faeb7d13/packages/core/primitives/signals/src/computed.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54002/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54002/files#diff-1a048dcd11e2a52dead82119d81fe85762b529813fdb26f36722066566232c1e
https://github.com/angular/angular/pull/54002/files#diff-1a048dcd11e2a52dead82119d81fe85762b529813fdb26f36722066566232c1e
https://github.com/angular/angular/pull/54002/files#diff-1a048dcd11e2a52dead82119d81fe85762b529813fdb26f36722066566232c1e
packages/core/primitives/signals/src/signal.tshttps://github.com/angular/angular/pull/54002/files#diff-fb5965417e1486c695674f5447fa193df0a9f4f9dea5695e7d46d66b3d4b23a3
View file https://github.com/crisbeto/angular/blob/1eeee66b2aabbc930f9b9f060b6951c8faeb7d13/packages/core/primitives/signals/src/signal.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54002/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54002/files#diff-fb5965417e1486c695674f5447fa193df0a9f4f9dea5695e7d46d66b3d4b23a3
https://github.com/angular/angular/pull/54002/files#diff-fb5965417e1486c695674f5447fa193df0a9f4f9dea5695e7d46d66b3d4b23a3
https://github.com/angular/angular/pull/54002/files#diff-fb5965417e1486c695674f5447fa193df0a9f4f9dea5695e7d46d66b3d4b23a3
packages/core/src/authoring/input_signal.tshttps://github.com/angular/angular/pull/54002/files#diff-c4769a0b164d139e5feba351e6d1d66e82dfc57bd61ebf9d7664d49d9ff23cee
View file https://github.com/crisbeto/angular/blob/1eeee66b2aabbc930f9b9f060b6951c8faeb7d13/packages/core/src/authoring/input_signal.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54002/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54002/files#diff-c4769a0b164d139e5feba351e6d1d66e82dfc57bd61ebf9d7664d49d9ff23cee
https://github.com/angular/angular/pull/54002/files#diff-c4769a0b164d139e5feba351e6d1d66e82dfc57bd61ebf9d7664d49d9ff23cee
https://github.com/angular/angular/pull/54002/files#diff-c4769a0b164d139e5feba351e6d1d66e82dfc57bd61ebf9d7664d49d9ff23cee
Please reload this pagehttps://github.com/angular/angular/pull/54002/files
packages/core/src/render3/query_reactive.tshttps://github.com/angular/angular/pull/54002/files#diff-d27060d0100f2ae0ec92550b253e94cbfc36e7680d6c084306d9940175127b6e
View file https://github.com/crisbeto/angular/blob/1eeee66b2aabbc930f9b9f060b6951c8faeb7d13/packages/core/src/render3/query_reactive.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54002/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54002/files#diff-d27060d0100f2ae0ec92550b253e94cbfc36e7680d6c084306d9940175127b6e
https://github.com/angular/angular/pull/54002/files#diff-d27060d0100f2ae0ec92550b253e94cbfc36e7680d6c084306d9940175127b6e
https://github.com/angular/angular/pull/54002/files#diff-d27060d0100f2ae0ec92550b253e94cbfc36e7680d6c084306d9940175127b6e
https://github.com/angular/angular/pull/54002/files#diff-d27060d0100f2ae0ec92550b253e94cbfc36e7680d6c084306d9940175127b6e
packages/core/test/authoring/input_signal_spec.tshttps://github.com/angular/angular/pull/54002/files#diff-693b813f843f45608e5b05dae53bf6bb1973e152c0e332f2654763a09d3fc65f
View file https://github.com/crisbeto/angular/blob/1eeee66b2aabbc930f9b9f060b6951c8faeb7d13/packages/core/test/authoring/input_signal_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54002/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54002/files#diff-693b813f843f45608e5b05dae53bf6bb1973e152c0e332f2654763a09d3fc65f
packages/core/test/signals/computed_spec.tshttps://github.com/angular/angular/pull/54002/files#diff-416172464fb261e6408ff7b02bb7359aae8b2d823532f6cb48ecf479d49eee52
View file https://github.com/crisbeto/angular/blob/1eeee66b2aabbc930f9b9f060b6951c8faeb7d13/packages/core/test/signals/computed_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54002/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54002/files#diff-416172464fb261e6408ff7b02bb7359aae8b2d823532f6cb48ecf479d49eee52
packages/core/test/signals/signal_spec.tshttps://github.com/angular/angular/pull/54002/files#diff-fe733038b34f355940c724dbed0c5ab2e5453a754591f2924e42bdf4ee3c2424
View file https://github.com/crisbeto/angular/blob/1eeee66b2aabbc930f9b9f060b6951c8faeb7d13/packages/core/test/signals/signal_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/54002/{{ revealButtonHref }}
https://github.com/angular/angular/pull/54002/files#diff-fe733038b34f355940c724dbed0c5ab2e5453a754591f2924e42bdf4ee3c2424
https://github.com/angular/angular/pull/54002/files#diff-fe733038b34f355940c724dbed0c5ab2e5453a754591f2924e42bdf4ee3c2424
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.