René's URL Explorer Experiment


Title: feat(compiler-cli): support host directives for local compilation mode by pmvald · Pull Request #53877 · angular/angular · GitHub

Open Graph Title: feat(compiler-cli): support host directives for local compilation mode by pmvald · Pull Request #53877 · angular/angular

X Title: feat(compiler-cli): support host directives for local compilation mode by pmvald · Pull Request #53877 · angular/angular

Description: At the moment local compilation breaks for host directives because the current logic relies on global static analysis. This change creates a local version by cutting the diagnostics and copying the directive identifier as it is to the generated code without attempting to statically resolve it. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: At the moment local compilation breaks for host directives because the current logic relies on global static analysis. This change creates a local version by cutting the diagnostics and copying the...

X Description: At the moment local compilation breaks for host directives because the current logic relies on global static analysis. This change creates a local version by cutting the diagnostics and copying the...

Opengraph URL: https://github.com/angular/angular/pull/53877

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:104c3fd1-ac75-65c3-5240-d310ada89e8d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id822C:296654:BF5408:1017EE2:6B00F8C3
html-safe-nonceea7c0b5ad02a56bab647a78d36138eb92c0e618ec7f9af4aff0b42f8fcf1079d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjJDOjI5NjY1NDpCRjU0MDg6MTAxN0VFMjo2QjAwRjhDMyIsInZpc2l0b3JfaWQiOiIxNjIwOTgxNzU5NTEwMzc4NjkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacff17a20f4450b770e7d0d7995d356d5da7ed0a08189d7e30b5a484876e0bd018
hovercard-subject-tagpull_request:1673419408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/53877/files
twitter:imagehttps://avatars.githubusercontent.com/u/31361906?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31361906?s=400&v=4
og:image:altAt the moment local compilation breaks for host directives because the current logic relies on global static analysis. This change creates a local version by cutting the diagnostics and copying the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/53877/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F53877%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F53877%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/53877/files
Reloadhttps://github.com/angular/angular/pull/53877/files
Reloadhttps://github.com/angular/angular/pull/53877/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
pmvaldhttps://github.com/pmvald
angular:mainhttps://github.com/angular/angular/tree/main
pmvald:lcm-host-dirhttps://github.com/pmvald/angular/tree/lcm-host-dir
Conversation 31 https://github.com/angular/angular/pull/53877
Commits 1 https://github.com/angular/angular/pull/53877/commits
Checks 0 https://github.com/angular/angular/pull/53877/checks
Files changed https://github.com/angular/angular/pull/53877/files
Please reload this pagehttps://github.com/angular/angular/pull/53877/files
feat(compiler-cli): support host directives for local compilation mode https://github.com/angular/angular/pull/53877/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/53877/files
3161b52 feat(compiler-cli): support host directives for local compilation mode pmvald Jan 11, 2024 https://github.com/angular/angular/pull/53877/commits/3161b52a61d339e40f44a50dd715d58285896a58
Clear filters https://github.com/angular/angular/pull/53877/files
Please reload this pagehttps://github.com/angular/angular/pull/53877/files
Please reload this pagehttps://github.com/angular/angular/pull/53877/files
error_code.md https://github.com/angular/angular/pull/53877/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
diagnostics.ts https://github.com/angular/angular/pull/53877/files#diff-c80be5cf1dd57148f4615273f0dccba60d386e4ad43154e2caa6e242c2f4b521
shared.ts https://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
error_code.ts https://github.com/angular/angular/pull/53877/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
index.ts https://github.com/angular/angular/pull/53877/files#diff-25b9ed520815380c5302cc8bc83ed427cb662cc43fa2face5a661f3bdc18f26e
api.ts https://github.com/angular/angular/pull/53877/files#diff-9e23176371d64fc1dd48192e70bf86e05a78397d11e197d218b0c8826027a97d
host_directives_resolver.ts https://github.com/angular/angular/pull/53877/files#diff-014ab25f23ab3073412fb4b2591b13d1db53e648602af6692b29955c36771d3e
util.ts https://github.com/angular/angular/pull/53877/files#diff-62b17e2ad553a44423b136f6169253bffe3f1d86b5b46800f0426946dc151828
dts_spec.ts https://github.com/angular/angular/pull/53877/files#diff-a126b1f6133ddc6cd5ef58a92c6a6e7b4649da5786b1b375024fc9a94ae6c9c2
template_symbol_builder.ts https://github.com/angular/angular/pull/53877/files#diff-a8127d2b4d704dfb9e68fff83734ad84ab91cc6bb99e9ded202d9c77409f49ab
local_compilation_spec.ts https://github.com/angular/angular/pull/53877/files#diff-8fcec51539461b799aad5597fed66ee5b9e6d3ab9dc450f25089cc12bf60f7ef
goldens/public-api/compiler-cli/error_code.mdhttps://github.com/angular/angular/pull/53877/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
View file https://github.com/pmvald/angular/blob/3161b52a61d339e40f44a50dd715d58285896a58/goldens/public-api/compiler-cli/error_code.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53877/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53877/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
https://github.com/angular/angular/pull/53877/files#diff-b801283160c94a20b0cb73aaaea21753750ba545825d6c4540eff3e90e166879
packages/compiler-cli/src/ngtsc/annotations/common/src/diagnostics.tshttps://github.com/angular/angular/pull/53877/files#diff-c80be5cf1dd57148f4615273f0dccba60d386e4ad43154e2caa6e242c2f4b521
View file https://github.com/pmvald/angular/blob/3161b52a61d339e40f44a50dd715d58285896a58/packages/compiler-cli/src/ngtsc/annotations/common/src/diagnostics.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53877/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53877/files#diff-c80be5cf1dd57148f4615273f0dccba60d386e4ad43154e2caa6e242c2f4b521
https://github.com/angular/angular/pull/53877/files#diff-c80be5cf1dd57148f4615273f0dccba60d386e4ad43154e2caa6e242c2f4b521
https://github.com/angular/angular/pull/53877/files#diff-c80be5cf1dd57148f4615273f0dccba60d386e4ad43154e2caa6e242c2f4b521
https://github.com/angular/angular/pull/53877/files#diff-c80be5cf1dd57148f4615273f0dccba60d386e4ad43154e2caa6e242c2f4b521
https://github.com/angular/angular/pull/53877/files#diff-c80be5cf1dd57148f4615273f0dccba60d386e4ad43154e2caa6e242c2f4b521
https://github.com/angular/angular/pull/53877/files#diff-c80be5cf1dd57148f4615273f0dccba60d386e4ad43154e2caa6e242c2f4b521
packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.tshttps://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
View file https://github.com/pmvald/angular/blob/3161b52a61d339e40f44a50dd715d58285896a58/packages/compiler-cli/src/ngtsc/annotations/directive/src/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53877/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
https://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
https://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
Please reload this pagehttps://github.com/angular/angular/pull/53877/files
https://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
https://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
https://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
https://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
https://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
https://github.com/angular/angular/pull/53877/files#diff-6539c6c9f245161cef7096ea5364fbf7010526032313d621a64d0457a9f6133b
packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.tshttps://github.com/angular/angular/pull/53877/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
View file https://github.com/pmvald/angular/blob/3161b52a61d339e40f44a50dd715d58285896a58/packages/compiler-cli/src/ngtsc/diagnostics/src/error_code.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53877/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53877/files#diff-4869d31b9dcf287a264969d4e9e862f4dccf7af149a9071a1b4de927292a492e
packages/compiler-cli/src/ngtsc/metadata/index.tshttps://github.com/angular/angular/pull/53877/files#diff-25b9ed520815380c5302cc8bc83ed427cb662cc43fa2face5a661f3bdc18f26e
View file https://github.com/pmvald/angular/blob/3161b52a61d339e40f44a50dd715d58285896a58/packages/compiler-cli/src/ngtsc/metadata/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53877/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53877/files#diff-25b9ed520815380c5302cc8bc83ed427cb662cc43fa2face5a661f3bdc18f26e
packages/compiler-cli/src/ngtsc/metadata/src/api.tshttps://github.com/angular/angular/pull/53877/files#diff-9e23176371d64fc1dd48192e70bf86e05a78397d11e197d218b0c8826027a97d
View file https://github.com/pmvald/angular/blob/3161b52a61d339e40f44a50dd715d58285896a58/packages/compiler-cli/src/ngtsc/metadata/src/api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53877/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53877/files#diff-9e23176371d64fc1dd48192e70bf86e05a78397d11e197d218b0c8826027a97d
https://github.com/angular/angular/pull/53877/files#diff-9e23176371d64fc1dd48192e70bf86e05a78397d11e197d218b0c8826027a97d
https://github.com/angular/angular/pull/53877/files#diff-9e23176371d64fc1dd48192e70bf86e05a78397d11e197d218b0c8826027a97d
Please reload this pagehttps://github.com/angular/angular/pull/53877/files
https://github.com/angular/angular/pull/53877/files#diff-9e23176371d64fc1dd48192e70bf86e05a78397d11e197d218b0c8826027a97d
https://github.com/angular/angular/pull/53877/files#diff-9e23176371d64fc1dd48192e70bf86e05a78397d11e197d218b0c8826027a97d
packages/compiler-cli/src/ngtsc/metadata/src/host_directives_resolver.tshttps://github.com/angular/angular/pull/53877/files#diff-014ab25f23ab3073412fb4b2591b13d1db53e648602af6692b29955c36771d3e
View file https://github.com/pmvald/angular/blob/3161b52a61d339e40f44a50dd715d58285896a58/packages/compiler-cli/src/ngtsc/metadata/src/host_directives_resolver.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53877/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53877/files#diff-014ab25f23ab3073412fb4b2591b13d1db53e648602af6692b29955c36771d3e
https://github.com/angular/angular/pull/53877/files#diff-014ab25f23ab3073412fb4b2591b13d1db53e648602af6692b29955c36771d3e
https://github.com/angular/angular/pull/53877/files#diff-014ab25f23ab3073412fb4b2591b13d1db53e648602af6692b29955c36771d3e
https://github.com/angular/angular/pull/53877/files#diff-014ab25f23ab3073412fb4b2591b13d1db53e648602af6692b29955c36771d3e
packages/compiler-cli/src/ngtsc/metadata/src/util.tshttps://github.com/angular/angular/pull/53877/files#diff-62b17e2ad553a44423b136f6169253bffe3f1d86b5b46800f0426946dc151828
View file https://github.com/pmvald/angular/blob/3161b52a61d339e40f44a50dd715d58285896a58/packages/compiler-cli/src/ngtsc/metadata/src/util.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53877/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53877/files#diff-62b17e2ad553a44423b136f6169253bffe3f1d86b5b46800f0426946dc151828
https://github.com/angular/angular/pull/53877/files#diff-62b17e2ad553a44423b136f6169253bffe3f1d86b5b46800f0426946dc151828
https://github.com/angular/angular/pull/53877/files#diff-62b17e2ad553a44423b136f6169253bffe3f1d86b5b46800f0426946dc151828
packages/compiler-cli/src/ngtsc/metadata/test/dts_spec.tshttps://github.com/angular/angular/pull/53877/files#diff-a126b1f6133ddc6cd5ef58a92c6a6e7b4649da5786b1b375024fc9a94ae6c9c2
View file https://github.com/pmvald/angular/blob/3161b52a61d339e40f44a50dd715d58285896a58/packages/compiler-cli/src/ngtsc/metadata/test/dts_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53877/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53877/files#diff-a126b1f6133ddc6cd5ef58a92c6a6e7b4649da5786b1b375024fc9a94ae6c9c2
https://github.com/angular/angular/pull/53877/files#diff-a126b1f6133ddc6cd5ef58a92c6a6e7b4649da5786b1b375024fc9a94ae6c9c2
https://github.com/angular/angular/pull/53877/files#diff-a126b1f6133ddc6cd5ef58a92c6a6e7b4649da5786b1b375024fc9a94ae6c9c2
https://github.com/angular/angular/pull/53877/files#diff-a126b1f6133ddc6cd5ef58a92c6a6e7b4649da5786b1b375024fc9a94ae6c9c2
packages/compiler-cli/src/ngtsc/typecheck/src/template_symbol_builder.tshttps://github.com/angular/angular/pull/53877/files#diff-a8127d2b4d704dfb9e68fff83734ad84ab91cc6bb99e9ded202d9c77409f49ab
View file https://github.com/pmvald/angular/blob/3161b52a61d339e40f44a50dd715d58285896a58/packages/compiler-cli/src/ngtsc/typecheck/src/template_symbol_builder.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53877/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53877/files#diff-a8127d2b4d704dfb9e68fff83734ad84ab91cc6bb99e9ded202d9c77409f49ab
https://github.com/angular/angular/pull/53877/files#diff-a8127d2b4d704dfb9e68fff83734ad84ab91cc6bb99e9ded202d9c77409f49ab
https://github.com/angular/angular/pull/53877/files#diff-a8127d2b4d704dfb9e68fff83734ad84ab91cc6bb99e9ded202d9c77409f49ab
https://github.com/angular/angular/pull/53877/files#diff-a8127d2b4d704dfb9e68fff83734ad84ab91cc6bb99e9ded202d9c77409f49ab
Please reload this pagehttps://github.com/angular/angular/pull/53877/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.